Commit Graph
5471 Commits
Author SHA1 Message Date
Johan T. Halseth 4581aa313c server: handle case where both policies are not present in fetchLastChanUpdateByOutPoint 2018-08-17 23:24:13 +02:00
Johan T. Halseth 5deffd228c peer: call disableChannel with disabled=false after loading channels
This to ensure now active channel is available in the router, for path
finding, as it might have been disabled if the peer has been offline a
while.
2018-08-17 23:24:13 +02:00
Johan T. Halseth e9cc7492a9 server: add goroutine watchChannelStatus
This commit adds a goroutine watchChannelStatus to the server, which
will query the switch for the status of all open channels every
InactiveChanTimeout / 4. If a channel's status has remained unchanged
during the last InactiveChanTimeout it'll send out a ChannelUpdate
setting the disabled bit accordingly.
2018-08-17 23:24:13 +02:00
Johan T. Halseth 9e44b38eee config: define InactiveChanTimeout 2018-08-17 23:24:13 +02:00
Johan T. Halseth b5bfdd72b5 server+peer: rename disableChannel->announceChanStatus
Now takes a boolean whether to disable/activate, and keeps track of the
last update sent to avoid sending duplicates.
2018-08-17 23:24:12 +02:00
Johan T. Halseth 887722f38f htlcswitch/switch: add method HasActiveLink 2018-08-17 23:24:12 +02:00
Johan T. Halseth 940d0735f8 lnd_test: use dave to listen for ChannelUpdates in testSendUpdateDisableChannel
This commit changes the test testSendUpdateDisableChannel to use Dave to
listen for channel updates, as was originally intended.

Since a ChannelUpdate won't propagate in the network if the channel is
already closed (if the closing transaction has been mined), we change
the closing procedure to initiate the closing process, wait for the
ChannelUpdates, then finally mining the closing transaction. This avoids
a propagation race between the mined block and the ChannelUpdate.
2018-08-17 23:24:12 +02:00
Johan T. Halseth 304577f617 server: make sure timestamp always increases when creating new ChannelUpdate 2018-08-17 23:24:12 +02:00
Johan T. Halseth 8826db32e8 server: let gossiper hand policy update to router
ProcessLocalAnnouncement will attempt to call UpdateEdge with the new
policy. If we call it manually before handing it to the gossiper, that
call will fail with "Outdated" and the announcement won't propagate.
2018-08-17 23:24:12 +02:00
Olaoluwa Osuntokun c6318eb614 Merge pull request #1741 from halseth/autopilot-no-dc
autopilot: check if already connected before returning error
2018-08-17 14:11:58 -07:00
Johan T. Halseth a57a972b26 dep: remove gographviz dependency 2018-08-17 09:38:50 +02:00
Johan T. Halseth c39c2d7c37 lncli: remove --render option from describegraph 2018-08-17 09:36:56 +02:00
Johan T. Halseth 2a3b52535e autopilot: check if already connected before returning error
This commit fixes a small bug that could cause us to disconnect an
already connected peer if no addresses where provided to the ConnectPeer
method. Now we instead first check if we are already connected, and
return early.
2018-08-17 09:26:54 +02:00
Wilmer Paulino 169ebad6c5 lnd_test: add test for funding channels with unconfirmed outputs 2018-08-16 20:22:43 -07:00
Wilmer Paulino 9ec6433863 lntest: extend OpenChannel to specify whether confirmed funds should be
used
2018-08-16 20:22:42 -07:00
Wilmer Paulino 130124bb79 lntest: add SendCoinsUnconfimed method
In this commit, we add a new method to the network harness that allows
us to send funds to another party without confirming the transaction.
This will be useful for testing funding channels with outputs that have
not been confirmed yet.
2018-08-16 20:22:42 -07:00
Wilmer Paulino 0a335bbea2 lntest: extract WaitForBalance into a method 2018-08-16 20:22:41 -07:00
Wilmer Paulino aa7c2e6d47 autopilot: add OnChannelPendingOpen state update 2018-08-16 20:22:40 -07:00
Wilmer Paulino 956acdfa14 autopilot/agent_test: pass in agent's quit chan to heuristic
In this commit, we alter our mock heuristic to also take in a quit chan.
It's possible that at the end of a test the agent is blocked on a
NeedMoreChans/Select call as their mock implementations use channels. To
prevent this, we use the agent's quit chan so that the heuristic can
safely exit once the agent does.
2018-08-16 20:19:33 -07:00
Wilmer Paulino dd5b6394d9 autopilot: read quit chan when sending state updates 2018-08-16 20:19:32 -07:00
Wilmer Paulino 7724d86801 config+pilot: add flag to specify min confs for autopilot agent 2018-08-16 20:19:31 -07:00
Wilmer Paulino ae3e66dccc fundingmanager+lnwallet: allow specifying number of min confs for coin selection 2018-08-16 20:19:30 -07:00
Wilmer Paulino a3cec7e036 rpcserver: set minConfs field in openChanReq 2018-08-16 20:19:29 -07:00
Wilmer Paulino 8e15b48a05 cmd/lncli: expose min confs parameter for OpenChannel command 2018-08-16 20:19:28 -07:00
Wilmer Paulino 85729208fb lnrpc: add MinConfs field to OpenChannelRequest proto 2018-08-16 20:19:27 -07:00
Wilmer Paulino 2908f672c3 server: add minConfs field to openChanReq 2018-08-16 20:19:27 -07:00
Wilmer Paulino 5c414bb1d0 multi: make OpenChannel take in openChanReq 2018-08-16 20:19:26 -07:00
Wilmer Paulino d76f97d497 fundingmanager+lnwallet: make InitChannelReservation take in req rather than many args 2018-08-16 20:19:25 -07:00
Wilmer Paulino 51fc193ddc lnwallet/wallet: export InitFundingReserveMsg and required fields 2018-08-16 20:19:24 -07:00
Olaoluwa Osuntokun 643618b4f6 Merge pull request #1694 from wpaulino/autopilot-reachability-test
autopilot: add peer reachability test before tracking funding as pending
2018-08-16 20:18:49 -07:00
Wilmer Paulino 454b549c7e autopilot+pilot: refactor connection logic out of OpenChannel
In this commit, we refactor the existing connection logic outside of the
ChanController's OpenChannel method. We do this as previously it was
possible for peers to stall us while attempting to connect to them. In
order to remedy this, we now attempt to connect the peer before tracking
them in our set of pending opens.
2018-08-16 20:17:03 -07:00
Olaoluwa Osuntokun fb927442c5 Merge pull request #1739 from Roasbeef/graph-private-chan-node-cleanup
channeldb: ensure we remove update index entries for nodes upon deletion
2018-08-16 19:20:00 -07:00
Wilmer Paulino 2fbe95ebba autopilot: modify OpenChannel to no longer take in set of addrs 2018-08-16 19:19:30 -07:00
Olaoluwa Osuntokun 9353ab00b1 channeldb: ensure that we remove update index entries for nodes upon deletion 2018-08-16 18:22:55 -07:00
Olaoluwa Osuntokun 06d03b55a3 channeldb: add new TestNodePruningUpdateIndexDeletion test
In this commit, we add a new test to expose a lurking bug within the
graph database code. As is, when we go to delete a node from the
database, we don't also remove the entries within the update index. As a
result, if a user attempted to call NodeUpdatesInHorizon (or typically
as part of the p2p handshake), we would error out, as we would try to
read a node that no longer existed in the graph, as it was pruned.
2018-08-16 18:20:58 -07:00
Olaoluwa Osuntokun 4492cb934f Merge pull request #1732 from wpaulino/no-macaroons-change-password
walletunlocker: avoid returning error if macaroon files don't exist
2018-08-16 17:15:12 -07:00
Wilmer Paulino b3edc5c257 walletunlocker: avoid returning error if macaroon files don't exist
In this commit, we fix a bug where it's possible that changing the
wallet's password fails due to not being able to remove non-existent
macaroon files. Since it's possible to run lnd without creating them,
changing the wallet's password would always result in a failure.
2018-08-16 16:17:54 -07:00
Olaoluwa Osuntokun 90cdc9da8f channeldb: add String() method for EdgePoint
In this commit we fix a minor logging artifact. After the switch to
EdgePoint, the FilteredChainView implementations will try to log the
struct directly, as prior they would have an outpoint object. We restore
this behavior by adding a String() method to EdgePoint which will simply
proxy through to the outpoint so we can log that directly.
2018-08-15 21:43:39 -07:00
Olaoluwa Osuntokun bd62ef6411 funding: properly log pubkey of peer within handleInitFundingMsg
Before this commit, we would log the struct of the pubkey, rather than
the serialized compressed version.
2018-08-15 21:41:53 -07:00
Olaoluwa Osuntokun 4731e1a3e2 Merge pull request #1692 from wpaulino/unadvertised-autopilot
autopilot+config: support opening private channels with autopilot agent
2018-08-15 21:26:05 -07:00
Olaoluwa Osuntokun 15eededf45 Merge pull request #1658 from cfromknecht/async-peer-start
[server]: Start Peers Asynchronously
2018-08-15 20:49:56 -07:00
Olaoluwa Osuntokun fc8626c806 Merge pull request #1726 from Roasbeef/fix-closed-chan-summaries-and-chancfg
multi: ensure closed channel summaries are fully populated, ensure KeyLocators are always set
2018-08-15 20:11:01 -07:00
Olaoluwa Osuntokun b59139f533 build: update to latest version of neutrino 2018-08-15 16:14:28 -07:00
Olaoluwa Osuntokun 917f929e70 keychain: use t.Helper() instead of manually fetching the line no from the runtime 2018-08-15 16:14:02 -07:00
Olaoluwa Osuntokun 1ff596ecd7 build: update btcwallet to point to latest version 2018-08-14 19:11:42 -07:00
Olaoluwa Osuntokun 26032f5956 channeldb: extend TestFetchClosedChannels to populate local chan cfg properly 2018-08-14 19:11:41 -07:00
Olaoluwa Osuntokun cf06b041a4 keychain: extend TestKeyRingDerivation to check KeyLocators of derived keys 2018-08-14 19:11:41 -07:00
Olaoluwa Osuntokun ad25ae1a07 keychain: ensure we properly set the KeyLocator for keys from DeriveNextKey
In this commit, we fix a slight bug in the existing implementation of
DeriveNextKey for btcwallet. Before this commit, we would only set the
public key, and not also the derivation path. It's important that we
also set the path information, as in the near future we'll be using the
KeyDescriptors returned from this method to create static channel back
ups. With these static backups, the key alone may be insufficient to
re-derive the private key as we may need to fallback to brute forcing in
order to re-derive the key as it's possible we add new key families in
the future.
2018-08-14 19:11:40 -07:00
Olaoluwa Osuntokun e97e4c1f5d contractcourt: set auxiliary chan recovery info for all created chan close summaries 2018-08-14 19:11:40 -07:00
Olaoluwa Osuntokun c37c9db2de funding: properly set auxiliary channel recovery info in close chan summaries 2018-08-14 19:11:40 -07:00