Commit Graph
100 Commits
Author SHA1 Message Date
Olaoluwa Osuntokun 30a0e6c745 Merge pull request #5533 from ErikEk/invoices-return-payment-address-addholdinvoice
invoices: return payment address and add index from addholdinvoice
2021-07-21 16:54:20 -07:00
Olaoluwa Osuntokun 115c99d0e0 docs/release-notes: add section re merge commit exemption 2021-07-20 16:22:46 -07:00
Olaoluwa Osuntokun fee92941f1 scripts: account for master branch merges in release notes script
Without this commit, the build may break if a PR commit is created, as
that shows the `PR_NUMBER` field we parse out as "master", reflecting
that its a merge commit into the master branch.
2021-07-20 16:22:37 -07:00
Olaoluwa Osuntokun 7176a212f7 Merge pull request #5520 from Roasbeef/actions-require-release-notes
build: add new GH actions to require release note updates
2021-07-16 14:21:27 -07:00
Olaoluwa Osuntokun 121979546b docs/release-notes: add entry for new release notes pre-submit check 2021-07-16 11:01:04 -07:00
Olaoluwa Osuntokun 6570749f7f build: add new GH actions to require release note updates
In this commit, we add a simple bash script to parse out the current PR
number from an environment variable in the GH actions context, and use
that to check to see if the PR has been referenced in the release notes
or not. This isn't 100% fool proof, but it should catch most of the
common cases.
2021-07-16 11:00:56 -07:00
Olaoluwa Osuntokun edd4152682 Merge pull request #5449 from yyforyongyu/itest-refactor-assertion
Break down the lnd_test.go file into smaller files
2021-07-13 16:41:55 -07:00
Olaoluwa Osuntokun 7e606c257a Merge pull request #5383 from Crypt-iQ/update_fuzz_docs_06142021
docs+Makefile: update fuzz.md to explain new build/run process
2021-07-13 16:23:48 -07:00
Olaoluwa Osuntokun c23d6fb0e2 Merge pull request #5504 from Zero-1729/patch-1
README: minor typo fix
2021-07-12 18:19:16 -07:00
Olaoluwa Osuntokun c733c139e9 Merge pull request #5462 from ErikEk/typo-labeltx
trivial: walletrpc typo
2021-07-09 17:36:21 -07:00
Olaoluwa Osuntokun 8df611f74c Merge pull request #5472 from joostjager/filter-leases
btcwallet: filter out expired leases
2021-07-09 17:31:03 -07:00
Olaoluwa Osuntokun 7e4b2b82f1 Merge pull request #5448 from xanoni/sample-lnd-conf-cleanup
sample-lnd.conf: remove duplicate setting and clean up section separators
2021-07-09 14:37:32 -07:00
Olaoluwa Osuntokun ab1149f26d Merge pull request #5471 from joostjager/db-itest-prep
itest: prepare for multiple db backends
2021-07-09 14:37:06 -07:00
Olaoluwa Osuntokun 47732ec59e Merge pull request #5475 from katokishin/patch-1
Fixed typo in comment
2021-07-09 14:35:50 -07:00
Olaoluwa Osuntokun ccd7421488 Merge pull request #5487 from C-Otto/fix-5367
htlcswitch: log amount for failures
2021-07-09 14:35:31 -07:00
Olaoluwa Osuntokun db3819fcef Merge pull request #5236 from offerm/preimage-to-settleevent
feature: expose preimage in forward+settle event
2021-07-09 14:35:11 -07:00
Olaoluwa Osuntokun 583dee9916 Merge pull request #5479 from Roasbeef/fix-send-to-route-error-propagation
lnrpc/routerrrpc+routing: fix send to route error propagation
2021-07-07 16:01:56 -07:00
Olaoluwa Osuntokun 079ab1c2bf channeldb: fix typo in PaymentControl.Fail 2021-07-07 15:31:27 -07:00
Olaoluwa Osuntokun 525ef594c7 routing: don't return an error from failPayment within handleSendError
In this commit, we fix a regression introduced by a recent bug fix in
this area. Before this change, we'd inspect the error returned by
`processSendError`, and then fail the payment from the PoV of mission
control using the returned error.

A recent refactoring removed `processSendError` and combined the logic
with `tryApplyChannelUpdate` in order to introduce a new
`handleSendError` method that consolidates the logic within the
`shardHandler`. Along the way, the behavior of the prior check was
replicated in the form of a new internal `failPayment` closure. However,
the new function closure ends up returning a `channeldb.FailureReason`
instance, which is actually an `error`.

In the wild, when `SendToRoute` fails due to an error at the
destination, then this new logic caused the `handleSendErorr` method to
fail with an error, returning an unstructured error back to the caller,
instead of the usual payment failure details.

We fix this by no longer checking the `handleSendErorr` for an error as
normal. The `handleSendErorr` function as is will always return an error
of type `*channeldb.FailureReason`, therefore we don't need to treat it
as a normal error. Instead, we check for the type of error returned, and
update the control tower state accordingly.

With this commit, the test added in the prior commit now passes.

Fixes #5477.
2021-07-07 15:31:22 -07:00
Olaoluwa Osuntokun b24edb2833 routing: modify TestSendToRouteStructuredError to return non-second chance error
In this commit, we modify the existing `TestSendToRouteStructuredError`
test to return an error that doesn't trigger the second chance logic.
Otherwise, we'll get a nil failure result from the mission control
interpretation, meaning we won't exercise the full code path. Instead,
we use a terminal error to ensure that the expected code path is hit.

As is, this test will fail as a recent refactoring causes us to return a
`channeldb.FailureReason` error, since the newly added `handleSendError`
code path in the `SendToRoute` method will return the raw error, rather
than the `shardError`, which is of the expected type.
2021-07-07 15:31:19 -07:00
Olaoluwa Osuntokun 9c9f821ded Merge pull request #5478 from Roasbeef/fix-may-add-htlc
lnwallet: fix payment regression introduced by MayAddOutgoingHtlc
2021-07-07 14:35:03 -07:00
Olaoluwa Osuntokun af43a863cb lnwallet: ensure MayAddOutgoingHtlc doesn't add zero-value HTLCs
In this commit, in order to allow the test added in the prior commit to
pass, we'll increment the mockHTLCAmt value by 1 to ensure we never
attempt to add a zero value HTLC.

Fixes #5468
2021-07-06 16:50:19 -07:00
Olaoluwa Osuntokun 49b18b4d35 lnwallet: add test case to exercise MayAddOutgoingHtlc bug
As is, if the remote party proposes a min HTLC of 0 `mSat` to us, then
we won't ever be able to _send outgoing_ in the channel as the
`MayAddOutgoingHtlc` will attempt to add a zero-value HTLC, which isn't
allowed within the protocol.

The default channels created actually already use a min HTLC value of
zero within the tests, so this test case fails as is.
2021-07-06 16:50:14 -07:00
Olaoluwa Osuntokun bb5c3f3b51 Merge pull request #5447 from bhandras/etcd_le_docs
docs: leader election docs
2021-07-06 16:43:40 -07:00
Olaoluwa Osuntokun 756a0ab392 Merge pull request #5463 from Roasbeef/v0.13.1-rc1-branch-prep
lnd: v0.13.1 rc1 branch prep
2021-07-02 17:40:46 -07:00
Olaoluwa Osuntokun f67d4d346b docs/release-notes: update release notes for 0.13.1 2021-07-01 18:26:10 -07:00
Olaoluwa Osuntokun 39ac0ebe41 lntest/itest: add new whitelisted error 2021-07-01 18:26:04 -07:00
Olaoluwa Osuntokun 2a59c43d14 Merge pull request #5457 from guggero/wallet-password-file-fallback
lnd+config+sample-lnd.conf: add wallet-unlock-allow-create flag
2021-07-01 18:04:38 -07:00
Olaoluwa Osuntokun 6d5ab035c5 Merge pull request #5280 from champo/interceptor_dont_leak_htlcs
htlcswitch: set sourceRef when resolving packets through interceptor
2021-07-01 17:35:26 -07:00
Olaoluwa Osuntokun b04efec130 Merge pull request #5452 from guggero/export-aezeed
aezeed: export wordlist and properties
2021-06-30 17:58:11 -07:00
Olaoluwa Osuntokun 3dc375603f Merge pull request #5441 from joostjager/cli-fix-fund-psbt
lncli: fix psbt fund parameter parsing
2021-06-30 17:56:34 -07:00
Olaoluwa Osuntokun 0ff5187dfe Merge pull request #5371 from bitcoincore-dev/docs-dev-testing
docs: bump docker lnd dev and testing version
2021-06-30 17:56:04 -07:00
Olaoluwa Osuntokun 20ef37d87d Merge pull request #5148 from yyforyongyu/4215-deadline-aware
sweeper+contractcourt: deadline aware in sweeping anchors
2021-06-29 16:39:12 -07:00
Olaoluwa Osuntokun cafa6246a9 Merge pull request #5431 from yyforyongyu/5259-follow-up
routing: rename method and add err check when launch shard
2021-06-28 16:16:13 -07:00
Olaoluwa Osuntokun 44e461b233 Merge pull request #5428 from wpaulino/enforce-anchor-reserve
lnwallet: prevent anchor reserve enforcement on legacy inbound channel
2021-06-28 16:08:43 -07:00
Olaoluwa Osuntokun dac0797857 Merge pull request #5420 from yyforyongyu/itest-use-require-net
itest: use require inside net.EnsureConnected/net.ConnectNodes
2021-06-28 16:07:33 -07:00
Olaoluwa Osuntokun 1910e263a8 lncli: check for existence of tls file (#5416) 2021-06-28 16:06:55 -07:00
Olaoluwa Osuntokun e62f0e1f3a Merge pull request #5429 from Roasbeef/itest-recovery-shutdown
lntest: retry node shutdown attempts to recovery tests
2021-06-24 18:43:39 -07:00
Olaoluwa Osuntokun 198ac3482c Merge pull request #5332 from yyforyongyu/5259-routing-fix-state
routing: fix payment state and refactor payment lifecycle tests
2021-06-24 18:42:17 -07:00
Olaoluwa Osuntokun 6a97e6432d Merge pull request #5419 from LN-Zap/upstream/fix-no-payment-address
lnd: only set payment address if not empty in PaymentRequest
2021-06-24 15:46:41 -07:00
Olaoluwa Osuntokun 5bd84e2a60 lntest: retry node shutdown attempts to recovery tests
In #5364 we added a new error path in the `StopDaemon` method to return
an error if shutdown was attempted while a rescan/recover instance was
in progress. Since the wallet actually won't fully stop (atm)
mid-recovery, the call effectively didn't do anything in that scenario,
so we started to return an error to properly reflect that. However this
causes certain itests to fail, as during recovery, the stop attempt will
fail leading to the test itself failing.

In this commit, we wrap the calls to stop a running daemon within a
`wait.NoError` call so we'll continually try to shut down the daemon
rather than quit on the first try.

Fixes #5423.
2021-06-24 15:37:32 -07:00
Olaoluwa Osuntokun 6dd7321a3f Merge pull request #5355 from carlaKC/4656-maxhtlcnumber
multi: set zero bandwidth hint for channels that do not have any available slots
2021-06-24 15:18:20 -07:00
Olaoluwa Osuntokun 1287328678 Merge pull request #5335 from guggero/abandonchannel-no-dev
RPC/CLI: Allow abandonchannel to be used in regular build
2021-06-23 16:05:34 -07:00
Olaoluwa Osuntokun 29d0b6491e Merge pull request #5404 from Roasbeef/revert-no-router-fetch
Revert "routing: no backend call to fetch best block"
2021-06-22 17:31:28 -07:00
Olaoluwa Osuntokun ff8153c332 docs/release-notes: add router height bug fix to 0.13.1 2021-06-22 17:24:17 -07:00
Olaoluwa Osuntokun df6dd30af7 Revert "routing: no backend call to fetch best block"
This reverts commit cdddaaca75.
2021-06-22 17:22:38 -07:00
Olaoluwa Osuntokun d49643c6d0 Merge pull request #5417 from Roasbeef/in-repo-change-log
docs/release-notes: add new in-tree location for release notes
2021-06-22 17:20:10 -07:00
Olaoluwa Osuntokun 5d29e9b099 Merge pull request #5409 from vwoo/docfix_neutrino_routing_options_move
sample-lnd.conf: fix, move astray neutrino and routing options
2021-06-21 19:43:43 -07:00
Olaoluwa Osuntokun d983263362 docs/release-notes: add new in-tree location for release notes
In this commit, we add a new folder within the `docs` directory that will
house the release notes for all versions of `lnd` going forward.  Moving to
use `git` for the release notes rather than the normal drafting procedure
lets us keep track of the set of changes more consistency over time, lets
contributors add their release notes over time, and also means we'll no
longer need to do a crunch at the tail end of the release process to fill in
the set of release notes.

For the 0.13.1 release notes, I've done a scan and added anything that has
been merged since the last major version tag.  In a follow up change, we'll
add a new Github action that fails the build if an entry in the release
notes linking to the newly added PR isn't committed as well. Until then, any
PRs merged in should ensure that they add an entry within the relevant
milestone.
2021-06-21 19:24:49 -07:00
Olaoluwa Osuntokun f9a51882c4 Merge pull request #5376 from de6df1re/lnrpc-doc-fix
lnrpc: fix v1 switch API doc
2021-06-18 14:13:39 -07:00
Olaoluwa Osuntokun fdc6d2607d Merge pull request #5369 from Crypt-iQ/coop_close_sanity_06082021
lnwallet+funding: sanitize upfront_shutdown_script
2021-06-18 14:13:25 -07:00
Olaoluwa Osuntokun 2fd75ace9d Merge pull request #5374 from yyforyongyu/itest-use-require-sendcoin
itest: use require inside net.SendCoins
2021-06-18 14:12:39 -07:00
Olaoluwa Osuntokun 9362f5d279 Merge pull request #5364 from guggero/prevent-stop-on-rescan
rpcserver: prevent shutdown during wallet recovery
2021-06-18 14:11:30 -07:00
Olaoluwa Osuntokun 2706f1972f Merge pull request #5358 from ErikEk/lnrpc-log-connections-to-transaction-subscription-stream
rpcserver: log connections to transaction subscription stream
2021-06-18 14:09:57 -07:00
Olaoluwa Osuntokun 16bce31e46 Merge pull request #5348 from yyforyongyu/fix-itest-channel-close
itest: fix wrong node queried for balance
2021-06-18 14:09:19 -07:00
Olaoluwa Osuntokun da94cbf1ec Merge pull request #5200 from champo/send_all_min_confs
sweep,rpc: honor minConfs paramater when SendAll is set
2021-06-18 14:08:45 -07:00
Olaoluwa Osuntokun 6f051fa5ea Merge pull request #5248 from joostjager/concurrent-onion
htlcswitch: concurrent onion decoding
2021-06-18 14:08:24 -07:00
Olaoluwa Osuntokun a4d4d5f8dc Merge pull request #5299 from C-Otto/insufficient-bandwidth-log
add detailed log message for "insufficient bandwidth" error
2021-06-18 14:07:15 -07:00
Olaoluwa Osuntokun 3831ce05a0 Merge pull request #5399 from carlaKC/monitoring-default
multi: enable monitoring build by default
2021-06-18 14:06:41 -07:00
Olaoluwa Osuntokun 6c7fb7c20a build: bump version to v0.13.99
A version bump to indicate that master is currently in-between major
versions.
2021-06-18 14:04:31 -07:00
Olaoluwa Osuntokun 725ff10480 build: bump version to v0.13.0-beta 2021-06-16 19:25:10 -07:00
Olaoluwa Osuntokun cf7d082b98 Merge pull request #5353 from guggero/remove-release-cache
GitHub: remove build cache for release builder
2021-06-16 19:23:42 -07:00
Olaoluwa Osuntokun 42099ef5e1 build: bump version to v0.13.0-beta.rc5 2021-06-02 17:18:24 -04:00
Olaoluwa Osuntokun c580005081 Merge pull request #5352 from guggero/drop-unused-arch
make: drop unused release targets
2021-06-02 14:13:14 -07:00
Olaoluwa Osuntokun 140907ce32 Merge pull request #5350 from Roasbeef/0-13-rc4-tag
build: bump version to v0.13.0-beta.rc4
2021-06-02 08:11:08 -07:00
Olaoluwa Osuntokun aa5c844633 Merge pull request #5351 from wpaulino/signet-bitcoind
config+chainreg: fix default rpc params for signet bitcoind
2021-06-02 08:09:58 -07:00
Olaoluwa Osuntokun 5ac65d961d build: bump version to v0.13.0-beta.rc4 2021-06-01 15:29:40 -07:00
Olaoluwa Osuntokun a45827ff4d docs: add prometheus flags to sample-lnd.conf (#5331) 2021-06-01 15:22:47 -07:00
Olaoluwa Osuntokun 22b1008916 Merge pull request #5343 from kaloudis/patch-1
Fix typo on FundPsbt fee definition error
2021-05-31 13:05:26 -07:00
Olaoluwa Osuntokun 7e91a022f3 Merge pull request #5336 from cfromknecht/reuse-amp-invoice
lnrpc: allow AMP pay-addr override + bump invoice timeouts
2021-05-31 13:02:34 -07:00
Olaoluwa Osuntokun ad0ecc4d58 Merge pull request #5333 from wpaulino/incompatible-account-addr-type
lnwallet: check if requested address type is compatible with account
2021-05-27 19:06:13 -07:00
Olaoluwa Osuntokun 9fbcc349d4 Merge pull request #5338 from guggero/btcutil-fix-update
mod: update btcutil dependency
2021-05-27 18:09:26 -07:00
Olaoluwa Osuntokun 9163d1a16f Merge pull request #5328 from guggero/neutrino-router-fix
rpcserver: check router state only if it is validating
2021-05-26 18:25:15 -07:00
Olaoluwa Osuntokun c96a4e2bf8 Merge pull request #5322 from wpaulino/key-import-docs
docs: add introductory documentation for new key import feature
2021-05-26 18:24:23 -07:00
Olaoluwa Osuntokun 0ed72b8c6a Merge pull request #5025 from guggero/signet
Add basic bitcoin signet support
2021-05-26 18:19:57 -07:00
Olaoluwa Osuntokun cede7a122a Merge pull request #5155 from bottlepay/random-coins
wallet: random coin selection
2021-05-26 15:28:25 -07:00
Olaoluwa Osuntokun 7f7e83b6aa Merge pull request #5334 from wpaulino/process-zombie-update-log-debug
discovery: demote err log to debug from processZombieUpdate
2021-05-26 15:27:24 -07:00
Olaoluwa Osuntokun 785d3c9b4f Merge pull request #5164 from cryptosharks131/fix-python-grpc-updatechannelpolicy
Update PolicyUpdateRequest to avoid python clash
2021-05-25 16:05:38 -07:00
Olaoluwa Osuntokun f15961f764 Merge pull request #5316 from halseth/breachtests-buffer-chan
breacharbiter_test: select on quit chan on publication
2021-05-24 18:05:11 -07:00
Olaoluwa Osuntokun dee6a1a29b Merge pull request #5314 from Roasbeef/13-rc3
build: bump version to v0.13.0-beta.rc3
2021-05-19 21:02:23 -07:00
Olaoluwa Osuntokun 7716175454 build: bump version to v0.13.0-beta.rc3 2021-05-19 18:26:22 -07:00
Olaoluwa Osuntokun f5ee874a0b Merge pull request #5305 from carlaKC/sessionkey-deserialize
channeldb: read HtlcAttemptInfo session key raw bytes
2021-05-19 17:14:17 -07:00
Olaoluwa Osuntokun c18f3333d8 Merge pull request #5247 from joostjager/deprecate-chan-capacity
lnrpc: deprecate route hop channel capacity field
2021-05-19 17:06:15 -07:00
Olaoluwa Osuntokun 47403c0be4 Merge pull request #5226 from yyforyongyu/small-fix-invoice
invoices: remove unused param in notifyClients
2021-05-19 16:36:06 -07:00
Olaoluwa Osuntokun 7f10e2bb75 Merge pull request #5309 from guggero/fix-router-annotations
lnrpc: fix typos in REST annotations for routerrpc
2021-05-19 11:24:49 -07:00
Olaoluwa Osuntokun 6c330d3121 Merge pull request #5303 from guggero/policy-nil-check
rpcserver: add nil check to policy ordering
2021-05-18 15:47:27 -07:00
Olaoluwa Osuntokun a2138f0038 build: bump version to v0.13.0-beta.rc1 2021-05-13 18:26:50 -07:00
Olaoluwa Osuntokun ea026257ee Merge pull request #5296 from Roasbeef/dep-update-2021-may
build: update neutrino+btcwallet modules to latest versions
2021-05-13 18:11:04 -07:00
Olaoluwa Osuntokun fb632ab4ee build: update neutrino+btcwallet modules to latest versions 2021-05-13 17:18:20 -07:00
Olaoluwa Osuntokun 7ab5906093 Merge pull request #5245 from bhandras/kvdb_module
kvdb: make kvdb a top level submodule to allow dependency in other projects
2021-05-13 15:59:20 -07:00
Olaoluwa Osuntokun 3cc9e63bb5 Merge pull request #5293 from Crypt-iQ/prevent_zombie_payments_05122021
multi: validate payment params at RPC layer
2021-05-13 15:48:09 -07:00
Olaoluwa Osuntokun 875a3d9659 Merge pull request #5291 from guggero/psbt-segwit-check
chanfunding: extend PSBT witness input check
2021-05-13 15:46:20 -07:00
Olaoluwa Osuntokun 6a2fb316ca Merge pull request #5274 from halseth/anchors-reserved-value-max
[anchors] cap value reserved for anchor fee bumping
2021-05-12 16:19:57 -07:00
Olaoluwa Osuntokun c0acdd8082 Merge pull request #5036 from halseth/breacharbiter-justice-splitting
[breacharbiter] Split justice tx in case of delayed confirmation.
2021-05-12 13:42:42 -07:00
Olaoluwa Osuntokun 86c5e483b2 Merge pull request #5206 from carlaKC/4987-heightexpirywatcher
invoices: add height based expiry watcher
2021-05-12 13:41:52 -07:00
Olaoluwa Osuntokun 93730088c5 Merge pull request #5256 from guggero/wallet-unlock-file
Auto-unlock wallet from password file
2021-05-12 13:41:30 -07:00
Olaoluwa Osuntokun dc73a23e81 Merge pull request #5253 from cfromknecht/amp-invoice
Support paying AMP invoices via SendPaymentV2
2021-05-12 13:38:42 -07:00
Olaoluwa Osuntokun d2c25124ed cmd/lncli: add basic AMP support for CLI 2021-05-10 22:02:15 -07:00
Olaoluwa Osuntokun ba5aaec632 Merge pull request #5266 from wpaulino/import-dry-run
walletrpc: expose dry run support for ImportAccount
2021-05-10 17:19:09 -07:00
Olaoluwa Osuntokun 0d3253c410 Merge pull request #5281 from guggero/router-chain-sync
itest flakes: fix multiple issues around router subsystem being out of sync
2021-05-10 13:11:37 -07:00