5482451297
The golang version always needs to be in sync between the go.mod, the PR checklist and the installation instructions. We also shorten the Pull Request template by removing everything that we have a CI check for and just refer to those checks instead.
12 lines
1.3 KiB
Markdown
12 lines
1.3 KiB
Markdown
#### Pull Request Checklist
|
|
|
|
- [ ] All changes are Go version 1.15 compliant
|
|
- [ ] Your PR passes all CI checks. If a check cannot be passed for a justifiable reason, that reason must be stated in the commit message and PR description.
|
|
- [ ] If this is your first time contributing, we recommend you read the [Code Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md)
|
|
- [ ] The code being submitted is commented according to [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation)
|
|
- [ ] Commits have a logical structure according to [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#IdealGitCommitStructure)
|
|
- [ ] For new code: Code is accompanied by tests which exercise both the positive and negative (error paths) conditions (if applicable)
|
|
- [ ] For bug fixes: If possible, code is accompanied by new tests which trigger the bug being fixed to prevent regressions
|
|
- [ ] Any new logging statements use an appropriate subsystem and logging level
|
|
- [ ] For code and documentation: lines are wrapped at 80 characters (the tab character should be counted as 8 characters, not 4, as some IDEs do per default)
|