16a4687718
This fixes itest flakes that happen when a payment is attempted that ends up causing a channel closure. completePaymentRequests() attempts to monitor the open channels after a payment is attempted in order to identify that payment was actually dispatched to a remote node before returning. However, when the payment actually causes a channel closure (for example, because the receiver sent an incorrect preimage) this logic fails in that the channel will no longer the found in the list of open channels. This could cause a flake when there was enough time for the channel to close before performing the check. One example of such a flaky test is failing_link. This fixes the issue by also checking whether the total number of channels was reduced, which indicates (assuming itest operations are being executed serially) that one of the attempted payments affected at least one channel. |
||
---|---|---|
.. | ||
lnd_channel_backup_test.go | ||
lnd_forward_interceptor_test.go | ||
lnd_macaroons_test.go | ||
lnd_max_channel_size_test.go | ||
lnd_mpp_test.go | ||
lnd_multi-hop_htlc_local_chain_claim_test.go | ||
lnd_multi-hop_htlc_local_timeout_test.go | ||
lnd_multi-hop_htlc_receiver_chain_claim_test.go | ||
lnd_multi-hop_htlc_remote_chain_claim_test.go | ||
lnd_multi-hop_local_force_close_on_chain_htlc_timeout_test.go | ||
lnd_multi-hop_remote_force_close_on_chain_htlc_timeout_test.go | ||
lnd_multi-hop_test.go | ||
lnd_multi-hop-error-propagation_test.go | ||
lnd_multi-hop-payments_test.go | ||
lnd_network_test.go | ||
lnd_onchain_test.go | ||
lnd_psbt_test.go | ||
lnd_rest_api_test.go | ||
lnd_send_multi_path_payment_test.go | ||
lnd_signer_test.go | ||
lnd_single_hop_invoice_test.go | ||
lnd_test_list_off_test.go | ||
lnd_test_list_on_test.go | ||
lnd_test.go | ||
lnd_wumbo_channels_test.go | ||
log_check_errors.sh | ||
log_error_whitelist.txt | ||
log_substitutions.txt | ||
test_harness.go |