Commit Graph

7530 Commits

Author SHA1 Message Date
Olaoluwa Osuntokun
4247ee20b3
Merge pull request #3225 from cfromknecht/relax-stat-tickers
routing+watchtower/wtclient: prints stats once per minute
2019-06-19 22:39:48 -07:00
Conner Fromknecht
3a4aba463b
routing+watchtower/wtclient: prints stats once per minute 2019-06-19 20:07:11 -07:00
Conner Fromknecht
fad8932d75
watchtower/multi: fix logging in wtclient 2019-06-19 19:57:59 -07:00
Olaoluwa Osuntokun
2305dd1c2c
Merge pull request #3222 from joostjager/fix-cli
lncli: add resetmc and small fixes
2019-06-19 19:24:31 -07:00
Joost Jager
865801c881
lncli: add reset mission control command 2019-06-19 12:37:32 +02:00
Joost Jager
26b2c79159
lncli: add usage to querymc command 2019-06-19 12:37:30 +02:00
Joost Jager
ad2759dc94
lncli: assign category to SendToRoute command 2019-06-19 12:37:28 +02:00
Olaoluwa Osuntokun
507ebea222
Merge pull request #3218 from Roasbeef/fee-estimate-fee-dust
lnwallet/btcwallet: use relay fee not tx fee rate for dust check
2019-06-19 01:13:18 -07:00
Olaoluwa Osuntokun
ac2cea4126
Merge pull request #3220 from wpaulino/set-stopping-on-shutdown
server: properly set stopping atomic var upon shutdown
2019-06-18 20:53:25 -07:00
Olaoluwa Osuntokun
4203542154
btcwallet: update to btcwallet version w/ SendOutputs dust fix 2019-06-18 19:55:26 -07:00
Olaoluwa Osuntokun
2012b5dc1a
lnwallet: fix logic in testCreateSimpleTx test case
In this commit, we fix a logic flaw in the testCreateSimpleTx test case
which emerged once we the bug fix for dust outputs landed. Before this
commit, we would erroneously fail during valid test execution.
2019-06-18 19:55:24 -07:00
Olaoluwa Osuntokun
eaa043f585 lnwallet/btcwallet: use relay fee not tx fee rate for dust check
In this commit we fix a hidden bug in the transaction creating logic
that was only manifested recently due to higher fees on Bitcoin's
mainnet. Before this commit, we would use the target fee rate to
determine if an output was dust or not. However, this is incorrect, as
instead the relay fee should be used as this matches the policy checks
widely deployed in Bitcoin full node today.

To fix this issue we now properly use the relay fee when computing dust.
This fixes the issue for the `EstimateFee` call, but the `SendOutputs`
call also has a similar issue. However, this must be fixed within
`btcwallet` itself, so it has been left out of this commit

Fixes #3217.
2019-06-18 19:55:16 -07:00
Wilmer Paulino
dff7fba40a
server: properly set stopping atomic var upon shutdown 2019-06-18 19:38:20 -07:00
Olaoluwa Osuntokun
b89b27e6ef
Merge pull request #3212 from cfromknecht/getnodeinfo-hide-chans-default
rpcserver: hide channels in getnodeinfo by default
2019-06-18 17:24:20 -07:00
Olaoluwa Osuntokun
5f4accd39f
Merge pull request #3195 from halseth/routeing-nil-copy-pubkey
routing+zpay32: copy pubkeys before nilling Curve and spewing
2019-06-18 17:19:25 -07:00
Johan T. Halseth
97dda4f8c8
channeldb/migrations: skip migration for empty outgoing payments bucket
Previously the migration would fail if the source node was not set in
the database. Since we know that the source node must have been set
before making any payments, we check whether there actually are any
payments to migrate, and return early if not.
2019-06-18 21:14:16 +02:00
Conner Fromknecht
d6d87e12fe
Merge pull request #3213 from Roasbeef/bump-fee-nil-fix
lnrpc/walletrpc: reject nil outpoints as args
2019-06-17 19:57:21 -07:00
Olaoluwa Osuntokun
df53c32489
Merge pull request #3139 from Roasbeef/zero-fees
rpc: update updatechanpolicy to allow zero fees
2019-06-17 18:16:38 -07:00
Olaoluwa Osuntokun
94a20e30e1
lnrpc/walletrpc: reject nil outpoints as args
In this commit, we modify the parsing of user provided outpoints to
ensure that we catch a nil (empty) output early. Otherwise, passing a
set of incorrect arguments would cause `lnd` to crash.
2019-06-17 16:56:16 -07:00
Conner Fromknecht
1c7ad4428c
cmd/lncli/commands: add include_channels flag to getnodeinfo 2019-06-17 16:18:18 -07:00
Olaoluwa Osuntokun
df40a9c1e1
Merge pull request #3177 from halseth/autopilot-targetconf-conf
[autopilot] make confirmation target configurable
2019-06-17 16:05:00 -07:00
Conner Fromknecht
0adc45ab5a
rpcserver: wrap closure args to 80 chars 2019-06-17 11:09:27 -07:00
Conner Fromknecht
a1a3290bda
rpcserver: conditionally include channels in GetNodeInfoResponse 2019-06-17 11:08:44 -07:00
Conner Fromknecht
79e0ca3e44
lnrpc: add include_channels flag to GetNodeInfoRequest 2019-06-17 10:57:45 -07:00
Johan T. Halseth
7df7449c47
Merge pull request #3187 from yaslama/UnknownAsDefaultAddressType
Use UnknownAddressType value as default in lnwallet.AddressType
2019-06-17 12:18:55 +02:00
Olaoluwa Osuntokun
c5357d383d
lnd: bump version to 0.7 2019-06-14 13:54:27 -07:00
Olaoluwa Osuntokun
9e24d3e8a5
build: add additional sub-servers to release.sh 2019-06-14 13:53:54 -07:00
Olaoluwa Osuntokun
e65b8e3805
Merge pull request #3198 from halseth/foreach-non-modify
Avoid modifying bucket during ForEach loop, and Cursor traversal
2019-06-14 22:46:23 +02:00
Conner Fromknecht
4d260f7452
Merge pull request #3203 from Roasbeef/update-btcd
build: update btcd version to latest w/ rbf support
2019-06-14 12:55:38 -07:00
Olaoluwa Osuntokun
a53323205c
Merge pull request #3133 from cfromknecht/wt-polish
watchtower: integrate altruist watchtower and watchtower client
2019-06-14 21:34:10 +02:00
Conner Fromknecht
47548e0eee
Merge pull request #3141 from wpaulino/instant-wallet-startup
build: update btcwallet dependency to include initial sync improvements
2019-06-14 12:27:05 -07:00
Johan T. Halseth
f98f452528
channeldb: avoid modifying bucket during cursor traversal
This is not safe according to bbolt documentation.
2019-06-14 21:09:03 +02:00
Johan T. Halseth
ed8d635cf1
contractcourt/briefcase: avoid bucket modification in ForEach loop
Since the contents were deleted before the bucket was deleted, we just
delete the bucket immediately.
2019-06-14 21:09:02 +02:00
Johan T. Halseth
b7a37728c0
channeldb/migrations: avoid modifying bucket during ForEach loop
bbolt documenation state that this is not safe and leads to undefined
behavior.
2019-06-14 21:09:02 +02:00
Wilmer Paulino
7b7a87cf04
build: update btcwallet dependency to include initial sync improvements 2019-06-14 01:36:04 -07:00
Johan T. Halseth
f63c5d0170
Merge pull request #3182 from yaslama/addressTypeInitialization
Initialize addressType to UnknownAddressType
2019-06-14 10:32:01 +02:00
Olaoluwa Osuntokun
18ec2bdbf4
Merge pull request #3011 from orbitalturtle/auto-regenerate-cert
Auto regenerate TLS cert
2019-06-14 06:34:41 +02:00
Olaoluwa Osuntokun
866fa2b8f9
Merge pull request #3173 from cfromknecht/aggregate-router-logging
routing/router: log aggregate graph processing stats
2019-06-14 06:27:11 +02:00
Conner Fromknecht
059887bd7b
watchtower/wtdb: apply sanity checks to session policy before accepting 2019-06-13 19:54:22 -07:00
Conner Fromknecht
1979f9a7c0
watchtower/multi: use sane sweep fee rate in unit tests 2019-06-13 19:54:22 -07:00
Conner Fromknecht
a543c781fe
watchtower/wtpolicy: add basic validity constraints 2019-06-13 19:54:22 -07:00
Conner Fromknecht
37052f1561
watchtower/wtdb: only accept properly sized blobs
Modifies the bbolt and mock tower databases to only accept blobs that
are the expected size of the session's blob type. This prevents resource
exhaustion attacks where a client may provide disproportionately large
encrypted blob, even though all supported blob types are of fixed-size.
2019-06-13 19:54:22 -07:00
Conner Fromknecht
dce24d1d47
watchtower/wtdb+wtserver: pass properly sized blob in unit tests 2019-06-13 19:54:22 -07:00
Conner Fromknecht
29009fdc34
watchtower/standalone: disable reward towers 2019-06-13 19:54:22 -07:00
Conner Fromknecht
6504058c74
watchtower/wtserver: add DisableReward config option 2019-06-13 19:54:21 -07:00
Conner Fromknecht
a246d8216a
watchtower/multi: define blob TypeAltruistCommit and TypeRewardCommit 2019-06-13 19:54:21 -07:00
Conner Fromknecht
2d47618055
watchtower/multi: define AltruistSessions feature bit as 0/1 2019-06-13 19:54:21 -07:00
Conner Fromknecht
86e1d111e5
watchtower/wtwire/message: bump wtwire messages outside reserved ranges
BOLT01 reserves the following ranges:
 - Setup & Control (types 0-31)
 - Channel (types 32-127)
 - Commitment (types 128-255)
 - Routing (types 256-511)

The wtwire messages now occupy 600-607.
2019-06-13 19:54:21 -07:00
Conner Fromknecht
7cabe2667f
watchtower/wtclient/client: use existing session with same TxPolicy
This commit modifies the client's filtering when selecting from existing
sessions. The new logic compares the configured TxPolicy with the
TxPolicy of the candidate sessions, which has the effect of ignoring
operational parameters such as MaxUpdates. Prior, changing MaxUpdates
would cause the client to request a new session even if it had perfectly
good slots available in a policy with an equal TxPolicy.
2019-06-13 19:54:21 -07:00
Conner Fromknecht
98c2d329e5
watchtower/multi: embed TxPolicy in wtpolicy.Policy
This commit splits out the parameters that shape the justice transaction
into their own struct, which then embedded within the overarching
wtpolicy.Policy which may have additional parameters describing
operation of the session.

This is done as a preliminary step to support comparison of sessions
based on matching TxPolicy configurations. This prevents otherwise
identical Policies from being counted as different if operational
parameters like MaxUpdates differ, even if it has no material difference
to the justice transaction.
2019-06-13 19:54:20 -07:00