Conner Fromknecht
a8130f0c40
Makefile: remove -u when installing go-acc
2019-09-18 13:43:35 -07:00
Lightning Koala
dcff77b63a
Update go version to 1.13
...
New go minimum version required is 1.13 as per [this change](https://github.com/lightningnetwork/lnd/pull/34589 ).
Docker build will fail due to missing trimpath.
2019-09-18 12:29:40 +01:00
Johan T. Halseth
ce9f7faff2
contractcourt/channel_arbitrator: handle breach channel at startup
...
Earlier the channel arbitrator would fail to recognize channels pending
close that were in the breached state. This lead to the state machine
not progressing correctly, and in some cases crashing since we would
attempt to force close an already closed channel.
A test TestChannelArbitratorForceCloseBreachedChannel is added to
exercise one of these scenarios.
2019-09-18 13:05:35 +02:00
Johan T. Halseth
26b7ec1b94
contractcourt/channel_arbitrator: define and react to breachClose
...
Earlier we would not react to breaches, as these are handled by other
subsystems. Now we advances our state machine in case of breach, such
that we'll gracefully exit, and won't have leftover state in case of a
restart.
A simple test TestChannelArbitratorBreachClose to exercise this behavior
is added.
2019-09-18 13:05:35 +02:00
Johan T. Halseth
504a910def
make: run linter on verbose
2019-09-18 09:07:53 +02:00
Johan T. Halseth
00d1890dd0
lint: skip files generated for mobile
2019-09-18 09:07:21 +02:00
Johan T. Halseth
1a4ba97562
Merge pull request #3274 from esneider/fix-typo-in-doc
...
Fix typo in doc
2019-09-18 08:37:06 +02:00
Wilmer Paulino
9e4c4c5041
Merge pull request #2084 from halseth/node-announcement-stale
...
Retransmit NodeAnnouncement on regular intervals
2019-09-17 11:37:05 -07:00
Olaoluwa Osuntokun
cd3c2b508e
Merge pull request #3511 from lieteau2/patch-1
...
Rename chainnotifer_server.go to chainnotifier_server.go
2019-09-17 03:19:18 +03:00
Conner Fromknecht
551693e1b8
Merge pull request #3496 from joostjager/fix-incoming-dust
...
cnct: do not create an action for incoming dust htlcs
2019-09-16 12:31:37 -07:00
Conner Fromknecht
46586e2a4c
Merge pull request #3495 from halseth/router-not-starte-deadlock
...
chainntnfs: start concurrent queues prior to connection
2019-09-16 12:19:54 -07:00
lieteau2
0ea1b3484e
Rename chainnotifer_server.go to chainnotifier_server.go
2019-09-16 10:57:50 -05:00
Joost Jager
95502da7e8
Merge pull request #3414 from joostjager/report-accept-height
...
lnwire+htlcswitch: report htlc accept height
2019-09-16 13:49:29 +02:00
Johan T. Halseth
92123c603d
gossiper: retransmit self NodeAnnouncement
2019-09-16 10:54:42 +02:00
Johan T. Halseth
24004fcb37
gossiper+server: define SelfNodeAnnouncement
2019-09-16 10:54:42 +02:00
Johan T. Halseth
e36d15582c
discovery/gossiper test: add TestRetransmit
...
This commit adds a test that ensures outdated announcements are
retransmitted when the RetransmitTicker ticks.
2019-09-16 10:54:38 +02:00
Johan T. Halseth
70d63abe9f
discovery/test: set global test timestamp
2019-09-16 10:23:01 +02:00
Johan T. Halseth
8b9fd039ec
discovery/gossiper test: remove mockGraphSource.SelfEdges
2019-09-16 10:23:01 +02:00
Johan T. Halseth
e201fbe396
discovery+server: RetransmitDelay->RetransmitTicker
...
Also let retransmitStaleChannels take a timestamp, to make it easier to
test.
2019-09-16 10:23:01 +02:00
Johan T. Halseth
74c9551564
discovery+server: make RebroadcastInterval part of config
2019-09-16 10:23:00 +02:00
Johan T. Halseth
3d8f194670
discovery/gossiper: extract adding nodeAnnouncement into method
2019-09-16 10:23:00 +02:00
Joost Jager
f60e4b1e14
lnwire+htlcswitch: report height for invalid payment details failure
...
Extends the invalid payment details failure with the new accept height
field. This allows sender to distinguish between a genuine invalid
details situation and a delay caused by intermediate nodes.
2019-09-16 10:10:20 +02:00
Joost Jager
1de08c4780
lnwire/test: fix TestFailIncorrectDetailsOptionalAmount
...
This test relied on specific internals of the failure encode function.
Changes to failure message pointer receiver everywhere subtly broke this
test.
2019-09-16 10:10:18 +02:00
Joost Jager
d3e206ef95
invoices: return accept height in hodl event
...
This is a preparation for passing back the accept height in the
incorrect payment details failure message to the sender.
2019-09-16 10:10:16 +02:00
Joost Jager
4e140213f9
htlcswitch+invoices: circuit key based hodl notifications
...
This commit modifies hodl htlc notification from invoice registry from a
single notification per hash to distinct notifications per htlc. This
prepares for htlc-specific information (accept height) to be added to the
notification.
2019-09-16 10:10:14 +02:00
Joost Jager
49a20a87a2
channeldb+invoices: make htlc cancelation stricter
...
Previously it was possible to cancel a canceled htlc. This would
subtract the htlc amount from the invoice amount again.
2019-09-16 10:10:13 +02:00
Johan T. Halseth
d195acc632
chainntnfs/neutrino: start concurrent queues prior to connection
...
Similar to what was done for btcd, just to make sure we won't be blocked
on any incoming notifications, start the queues first thing during
startup.
2019-09-16 08:54:06 +02:00
Johan T. Halseth
6b6beb4d7d
chainntnfs/btcd: start concurrent queues prior to connection
...
We would establish the connection to the chain backend and start getting
block notifications before we had started the concurrent queues, which
would lead to the OnBlockConnected call being blocked, and a deadlock
(since GetBestBlock would never return).
Instead we make sure to start the queues before establishing the
connection, consuming the notifications right away.
2019-09-16 08:54:06 +02:00
Wilmer Paulino
35027e52fc
Merge pull request #3497 from joostjager/nursery-err
...
utxonursery: lower shutdown message log level
2019-09-14 11:59:56 +03:00
Olaoluwa Osuntokun
550a7a0729
Merge pull request #3485 from joostjager/remove-migrations
...
channeldb: remove older migrations
2019-09-14 11:23:01 +03:00
Olaoluwa Osuntokun
7b1166bbb7
Merge pull request #3458 from Roasbeef/go1.13
...
build: update travis and Makefile to build using Go 1.13
2019-09-14 11:18:51 +03:00
Conner Fromknecht
35d4652d23
Merge pull request #3503 from joostjager/remove-whitespace-linter
...
build: pin golangci-lint version
2019-09-13 11:25:54 -07:00
Conner Fromknecht
72c5d11a1c
Merge pull request #3502 from joostjager/err-returns
...
multi: fix dropped errors
2019-09-13 11:24:04 -07:00
Lars Lehtonen
4d4da3c07c
brontide: fix goroutine in test
2019-09-13 16:50:53 +00:00
Johan T. Halseth
1dbb653b3a
Merge pull request #3501 from alrs/fix-test-errors
...
Cross-Project Sweep to Fix Dropped Test Errors
2019-09-13 14:15:34 +02:00
Joost Jager
23517587aa
build: disable funlen
2019-09-13 14:11:32 +02:00
Joost Jager
be7fc9dd3e
cnct: do not create an action for incoming dust htlcs
...
This commit fixes the 'unable to find incoming resolution' error that
occured when trying to resolve incoming htlcs below the dust limit that
are not actually present on the commitment tx.
2019-09-13 12:31:26 +02:00
Joost Jager
3131bc4d64
cnct/test: test outgoing dust htlc resolution
2019-09-13 12:31:24 +02:00
Joost Jager
d553c304b2
cnct: log resolver type on error
2019-09-13 12:31:22 +02:00
Joost Jager
1216dc6a5b
build: pin golangci-lint version
...
To prevent builds breaking when golangci-lint or any of the linters is
updated.
2019-09-13 11:46:23 +02:00
Joost Jager
3ab4c749c6
channeldb: remove unsupported migrations
...
To reduce maintenance on migration code, we move to only supporting
upgrades from previous major releases.
2019-09-13 10:13:00 +02:00
Joost Jager
f1942a4c33
channeldb: require minimum db upgrade version
2019-09-13 10:12:58 +02:00
Joost Jager
1e0ed1e52f
multi: fix dropped errors
2019-09-13 09:50:38 +02:00
Lars Lehtonen
3b29ecb921
routing: Fix dropped errors in tests.
...
lnd: Fix dropped errors in tests.
contractcourt: Fix dropped errors in tests.
htlcswitch: Fix dropped errors in tests.
invoices: Fix dropped error in tests.
lnwallet: Fix dropped errors in tests.
macaroons: Fix dropped error in tests.
2019-09-13 06:28:05 +00:00
Joost Jager
ffb8c0cfc3
Merge pull request #3489 from joostjager/lint-all
...
build: enable linters for future changes
2019-09-12 23:08:31 +02:00
Johan T. Halseth
b82286e83b
Merge pull request #3498 from alrs/fix-channeldb-errors
...
channeldb Error Handling Fixes
2019-09-12 21:20:10 +02:00
Joost Jager
5249a21a65
build: enable linters for future changes
2019-09-12 21:16:38 +02:00
Johan T. Halseth
8f74ec2f1a
Merge pull request #3491 from fiatjaf/patch-1
...
Fix error message for wrong size description_hash.
2019-09-12 21:08:02 +02:00
Lars Lehtonen
2f51ccd10b
channeldb: Fix dropped error in migrations test
...
channeldb: Fix dropped error and wrap with context
channeldb: Fix empty error condition in waitingproof test
channeldb: Fix empty error condition in codec
channeldb: Wrap error in context
2019-09-12 15:49:21 +00:00
Johan T. Halseth
01f696afce
Merge pull request #3487 from matheusd/lnd-fix-extra-dave
...
itest: Shutdown final Dave node in testChanRestore
2019-09-12 14:55:53 +02:00