Merge pull request #3503 from joostjager/remove-whitespace-linter

build: pin golangci-lint version

.golangci.yml

@@ -37,6 +37,10 @@ linters:
   # We don't care (enough) about misaligned structs to lint that.
   - maligned
 
+  # We have long functions, especially in tests. Moving or renaming those would
+  # trigger funlen problems that we may not want to solve at that time.
+  - funlen
+
 issues:
   # Only show newly introduced problems.
   new-from-rev: 01f696afce2f9c0d4ed854edefa3846891d01d8a

Makefile

@@ -4,7 +4,7 @@ MOBILE_PKG := $(PKG)/mobile
 
 BTCD_PKG := github.com/btcsuite/btcd
 GOVERALLS_PKG := github.com/mattn/goveralls
-LINT_PKG := github.com/golangci/golangci-lint/cmd/golangci-lint
+LINT_PKG := github.com/golangci/golangci-lint/cmd/golangci-lint@v1.18.0
 GOACC_PKG := github.com/ory/go-acc
 
 GO_BIN := ${GOPATH}/bin
@@ -71,7 +71,10 @@ $(GOVERALLS_BIN):
 
 $(LINT_BIN):
 	@$(call print, "Fetching linter")
-	GO111MODULE=off go get -u $(LINT_PKG)
+	# Switch to tmp directory to prevent lnd go.mod from being modified.
+	# Hopefully someday a flag for go get will be added for this.
+	cd /tmp
+	GO111MODULE=on go get $(LINT_PKG)
 
 $(GOACC_BIN):
 	@$(call print, "Fetching go-acc")