Commit Graph

10810 Commits

Author SHA1 Message Date
Wilmer Paulino
023f327cdd
lntest: add rebroadcast stale announcements err to whitelist 2021-01-06 14:33:41 -08:00
Wilmer Paulino
7ef1f3f636
discovery: use source of ann upon confirmed channel ann batch
We do this instead of using the source of the AnnounceSignatures
message, as we filter out the source when broadcasting any
announcements, leading to the remote node not receiving our channel
update. Note that this is done more for the sake of correctness and to
address a flake within the integration tests, as channel updates are
sent directly and reliably to channel counterparts.
2021-01-06 13:16:44 -08:00
Wilmer Paulino
00d4e92362
discovery: prevent rebroadcast of premature channel updates
As similarly done with premature channel announcements, we'll no longer
allow premature channel updates to be rebroadcast once mature. This is
no longer necessary as channel announcements that we're not aware of are
usually broadcast to us with their accompanying channel updates.
2021-01-06 12:52:41 -08:00
Oliver Gugger
faa399f942
Merge pull request #4883 from yyforyongyu/small-fix
trivial: fix make rpc-format
2021-01-04 09:59:07 +01:00
Olaoluwa Osuntokun
f3b23b8046
build: bump version to v0.12.0-beta.rc3 2020-12-31 15:58:17 -08:00
Olaoluwa Osuntokun
ad206123e5
Merge pull request #4881 from guggero/rpc-log-fix
rpcserver: fix log statement in channelbalance
2020-12-28 12:40:33 -08:00
Olaoluwa Osuntokun
0cebce8a78
Merge pull request #4887 from calvinrzachman/bit-align
ensure 64bit alignment of atomically accessed field in ChannelAcceptor
2020-12-28 12:40:04 -08:00
Calvin Zachman
19440c1e39 ensure 64bit alignment of atomically accessed field in ChannelAcceptor
- help lnd avoid a bug in the `sync/atomic` package which requires 64-bit alignment of atomically accessed fields
2020-12-28 10:04:13 -06:00
yyforyongyu
c171548944
trivial: fix make rpc-format 2020-12-24 21:41:42 +08:00
Oliver Gugger
49edb2b524
rpcserver: fix log statement in channelbalance
Fixes a typo and missing format 'verb' in the RPCS debug log.
2020-12-22 09:39:43 +01:00
Olaoluwa Osuntokun
9cd9bff59f
build: bump version to v0.12.0-beta.rc2 2020-12-18 16:27:14 -08:00
Johan T. Halseth
cc0321d188
Merge pull request #4872 from Roasbeef/fix-tweakless-downgrade
peer: ensure consistent local+global feature bits when downgrading
2020-12-18 09:53:45 +01:00
Olaoluwa Osuntokun
403d37f426
peer: ensure consistent local+global feature bits when downgrading
In this commit, we fix an issue that would cause peers running lnd 0.12
to not be able to connect to existing peers due to a feature bit
compatibility issue. In a recent PR we started to downgrade our required
feature bit for static key from required to optional, if we had a legacy
(non-tweakless) open with the peer then we would unset the required bit
and set the optional bit to ensure we could still connect to them.

The change implementing this new version of downgrade failed _also_
unset the bit (the required bit) in the "legacy global" feature bit
section. This caused the `RawFeatureVector.Merge` method to fail as we
would have the required bit set in the `GlobalFeatures` section, but the
optional bit set in the `Features` section. The `Merge` method ensures
that a required and optional bit can't be set in two different locations
for the same feature.

This PR fixes this issue by also unsetting the bit in the
`GlobalFeatures` field in the init message.

Fixes #4871
2020-12-17 17:04:15 -08:00
Eugene
e0439965bb
Merge pull request #4757 from Crypt-iQ/fmgr_1109
funding: move Manager to own package
2020-12-17 11:43:12 -05:00
eugene
dcdf36f410 lnd+funding: move Manager to funding, change references 2020-12-17 10:45:05 -05:00
eugene
e7e872f19a lnd: remove Manager's stop method, linter complaints 2020-12-17 09:50:55 -05:00
eugene
936227798a lnd: remove openChanReq, call InitFundingWorkflow with InitFundingMsg 2020-12-17 09:50:48 -05:00
eugene
e85baea1b3 lnd: export InitFundingMsg 2020-12-17 09:36:34 -05:00
eugene
105e961b20 lnd: export Manager's InitFundingWorkflow method 2020-12-17 09:36:34 -05:00
eugene
1b84d07c4d lnd+funding: register funding logger 2020-12-17 09:36:34 -05:00
eugene
6a209bbdaf lnd: export Manager, NewFundingManager 2020-12-17 09:36:34 -05:00
eugene
f43fd32daf lnd: remove PendingChannels call from fundingManager 2020-12-17 09:36:34 -05:00
eugene
9c72dd9eba funding+peer: rename Manager interface to Controller 2020-12-17 09:36:34 -05:00
eugene
caa0f5da6a multi: move and export funding-related vars to funding package
Also moves the lnd global MaxFundingAmount to server.go
2020-12-17 09:36:34 -05:00
eugene
f6524aabcb lnd+funding: use funding.WriteOutpoint instead of lnd version
This commit duplicates the utxonursery's writeOutpoint function
in the funding package so that when the rest of the fundingmanager
code is moved, it can use the WriteOutpoint function for its
channel opening state data.
2020-12-17 09:36:34 -05:00
eugene
61e0f67edf funding: rename from fmgr, change references 2020-12-17 09:36:34 -05:00
Olaoluwa Osuntokun
cc17dd5804
Merge pull request #4869 from bhandras/etcd_namespaces
etcd: add support for namespaces
2020-12-16 19:18:41 -08:00
Andras Banki-Horvath
5ee0d77414
build: extend sample-lnd.conf with the new etcd namespace 2020-12-16 18:34:41 +01:00
Andras Banki-Horvath
4a6af67241
etcd: add support for namespaces
This commit adds support for etcd namespaces. This is useful when
using a shared etcd database where separate users have access to
separate namespaces.
2020-12-16 18:25:38 +01:00
Olaoluwa Osuntokun
f9641cdc64 build: bump version to v0.12.0-beta.rc1 2020-12-15 14:30:36 -08:00
Olaoluwa Osuntokun
d2d87c7b24
Merge pull request #4837 from carlaKC/workflows-pindeps
github: add workflow that allows us to pin dependencies
2020-12-15 14:28:39 -08:00
Olaoluwa Osuntokun
0a171a9e5f
Merge pull request #4867 from guggero/wallet-drop-fix
lnd+walletunlocker: move wallet DB history drop to unlocker
2020-12-15 14:25:58 -08:00
Olaoluwa Osuntokun
63055eecd3
Merge pull request #4855 from halseth/anchors-clamp-max-feerate
multi: cap anchors feerate at configurable maximum
2020-12-15 14:25:15 -08:00
Oliver Gugger
03a21367d3
lnd+walletunlocker: move history drop to unlocker
Apparently dropping the wallet transaction history only fully takes
effect after opening the wallet from scratch again. To do this cleanly,
we need to do it in the unlocker instead of lnd.
2020-12-15 21:34:12 +01:00
Oliver Gugger
0c6cc71f86
walletunlocker: use noFreeListSync param 2020-12-15 21:21:29 +01:00
carla
d7e2fddb75
github: add workflow that allows us to pin dependencies
This commit adds a workflow that pins certain dependencies in go.mod
that we do not want to bump.
2020-12-15 21:17:11 +02:00
carla
d8978c6109
go.sum: cleanup unused entries
go mod tidy does not always remove unused entries (known issue for
gomod). This commit cleans up the entries we don't need.
2020-12-15 21:17:04 +02:00
Johan T. Halseth
413ece2ccc
itest: account for capped anchor commit fee rate in balance calc 2020-12-15 19:54:50 +01:00
Johan T. Halseth
99bbd992d2
sample config: add no-anchors and max-commit-fee-rate-anchors 2020-12-15 19:54:50 +01:00
Johan T. Halseth
0fd76e53b8
multi: cap anchors feerate at configurable maximum
This commit caps the update fee the initiator will send when the anchors
channel type is used. We do not limit anything on the receiver side.

10 sat/vbyte is the current default max fee rate we use. This should be
enough to ensure propagation before anchoring down the commitment
transaction.
2020-12-15 19:54:50 +01:00
Olaoluwa Osuntokun
d289a6ff78
Merge pull request #4840 from halseth/anchors-zero-fee-secondlevel
[anchors] zero-fee HTLC secondlevel transactions
2020-12-15 10:52:03 -08:00
Johan T. Halseth
64659e6156
protocol+rpctest: disable anchors by default for itests 2020-12-15 10:13:28 +01:00
Johan T. Halseth
d69a1a616d
sample config: add no-anchors 2020-12-15 10:13:27 +01:00
Johan T. Halseth
c92c06400b
config+protocol: enable anchor commitments (zero-fee HTLC ) by default 2020-12-15 10:13:25 +01:00
Johan T. Halseth
1923d40843
lnwallet+funding: enable AnchorsZeroFeeHtlcTx commit type if both nodes support
We assume the legacy anchor type is no longer advertised by us.
2020-12-15 10:13:18 +01:00
Johan T. Halseth
0b9bec7804
chanrestore: define ZeroHtlcTxFeeCommitVersion 2020-12-15 10:13:12 +01:00
Johan T. Halseth
d5cd9861d2
channeldb+lnwallet: define zero-fee channel type 2020-12-15 10:13:07 +01:00
Johan T. Halseth
abefa93065
lnwire+feature: define AnchorsZeroFeeHtlcTx feature 2020-12-15 10:13:04 +01:00
Olaoluwa Osuntokun
f8dda6f0ee
Merge pull request #4865 from guggero/restore-logic-fix
chanrestore: flip case logic for old backup logic
2020-12-14 16:29:02 -08:00
Oliver Gugger
693d0f61b7
chanrestore: flip case logic
If a channel backup from an old node is restored and a channel contained
within that file was unconfirmed at the time of the backup, the whole
channel short ID is 0:0:0. Unfortunately we got stuck in just the first
case and didn't fall through to the second one. To avoid that, we flip
the case logic because for the second case, the block height in the
short channel ID cannot be zero.
2020-12-14 21:59:49 +01:00