akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3248 from joostjager/querymc-binding-bug

Browse Source 
routerrpc: fix loop variable binding bug in querymc
This commit is contained in:
Olaoluwa Osuntokun 2019-06-27 17:25:58 -07:00 committed by GitHub
commit 3c4c4f873b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lnrpc/routerrpc/router_server.go
View File

@ -445,7 +445,10 @@ func (s *Server) QueryMissionControl(ctx context.Context,
snapshot := s.cfg.RouterBackend.MissionControl.GetHistorySnapshot() snapshot := s.cfg.RouterBackend.MissionControl.GetHistorySnapshot()
rpcNodes := make([]*NodeHistory, len(snapshot.Nodes)) rpcNodes := make([]*NodeHistory, len(snapshot.Nodes))
for i, node := range snapshot.Nodes { for i, n := range snapshot.Nodes {
// Copy node struct to prevent loop variable binding bugs.
node := n
channels := make([]*ChannelHistory, len(node.Channels)) channels := make([]*ChannelHistory, len(node.Channels))
for j, channel := range node.Channels { for j, channel := range node.Channels {
channels[j] = &ChannelHistory{ channels[j] = &ChannelHistory{