routerrpc: fix loop variable binding bug in querymc

This bug caused all node pubkey to be the same.
This commit is contained in:
Joost Jager 2019-06-26 14:19:17 +02:00
parent 0e28ecd616
commit e2af3c0fa7
No known key found for this signature in database
GPG Key ID: A61B9D4C393C59C7

@ -445,7 +445,10 @@ func (s *Server) QueryMissionControl(ctx context.Context,
snapshot := s.cfg.RouterBackend.MissionControl.GetHistorySnapshot()
rpcNodes := make([]*NodeHistory, len(snapshot.Nodes))
for i, node := range snapshot.Nodes {
for i, n := range snapshot.Nodes {
// Copy node struct to prevent loop variable binding bugs.
node := n
channels := make([]*ChannelHistory, len(node.Channels))
for j, channel := range node.Channels {
channels[j] = &ChannelHistory{