History

Conner Fromknecht 14a06526b8 routing/notifs: order invariant testing of ntfn delivery (#238 ) Modifies the test cases in `TestEdgeUpdateNotification` and `TestNodeUpdateNotification` to check for the possibility of notifications being delivered out of order. This addresses some sporadic failures that were observed when running the test suite. I looked through some of the open issues but didn't see any addressing this issue in particular, but if someone could point me to any relevant issues that would be much appreciated! Issue ----- Currently the test suite validates notifications received in the order they are submitted. The check fails because the verification of each notification is statically linked to the order in which they are delivered, seen [here](`1be4d67ce4/routing/notifications_test.go (L403)`) and [here](`1be4d67ce4/routing/notifications_test.go (L499)`) in `routing/notifications_test.go`. The notifications are typically delivered in this order, but causes the test to fail otherwise. Proposed Changes ------------------- Construct an index that maps a public key to its corresponding edges and/or nodes. When a notification is received, use its identifying public key and the index to look up the edge/node to use for validation. Entries are removed from the index after they are verified to ensure that the same entry is validated twice. The logic to dynamically handle the verification of incoming notifications rests can be found here [here](https://github.com/cfromknecht/lnd/blob/order-invariant-ntfns/routing/notifications_test.go#L420) and [here](https://github.com/cfromknecht/lnd/blob/order-invariant-ntfns/routing/notifications_test.go#L539). Encountered Errors -------------------- * `TestEdgeUpdateNotification`: notifications_test.go:379: min HTLC of edge doesn't match: expected 16.7401473 BTC, got 19.4852751 BTC * `TestNodeUpdateNotification`: notifications_test.go:485: node identity keys don't match: expected 027b139b2153ac5f3c83c2022e58b3219297d0fb3170739ee6391cddf2e06fe3e7, got 03921deafb61ee13d18e9d96c3ecd9e572e59c8dbd0bb922b5b6ac609d10fe4ee4 Recreating Failing Behavior --------------------------- The failures can be somewhat difficult to recreate, I was able to reproduce them by running the unit tests repeatedly until they showed up. I used the following commands to bring them out of hiding: ``` ./gotest.sh -i go test -test.v ./routing && while [ $? -eq 0 ]; do go test -test.v ./routing; done ``` I was unable to recreate these errors, or any others in this package, after making the proposed changes and leaving the script running continuously for ~30 minutes. Previously, I could consistently generate an error after ~20 seconds had elapsed on the latest commit in master at the time of writing: 78f6caf5d2e570fea0e5c05cc440cb7395a99c1d. Moar stability ftw!		2017-07-31 21:38:03 -07:00
..
chainview	routing/chainview: convert chainview integration tests to use sub-tests	2017-07-04 15:53:58 -07:00
testdata	routing: add proper test for excessive number of hops	2017-02-02 00:24:16 -08:00
errors.go	routing: reject channel announcement if connected vertexes are unknown	2017-05-14 19:27:24 -07:00
graph.go	routing: rewrite package to conform to BOLT07 and factor in fees+timelocks	2016-12-27 16:44:22 -08:00
heap_test.go	multi: run all test instances in parallel	2017-06-17 01:00:07 +02:00
heap.go	routing: introduce new heap for storing candidate shortest paths	2017-03-21 12:20:30 -07:00
log.go	lnd: remove seelog logger	2017-06-25 14:19:56 +01:00
notifications_test.go	routing/notifs: order invariant testing of ntfn delivery (#238 )	2017-07-31 21:38:03 -07:00
notifications.go	routing: fix vet error, ensure wait group in topologyClient isn't copied	2017-06-25 13:48:52 +01:00
pathfind_test.go	multi: run all test instances in parallel	2017-06-17 01:00:07 +02:00
pathfind.go	routing: add ToHopPayloads method to routing.Route	2017-06-16 22:37:47 +02:00
README.md	multi: fix formatting issues in packge README's	2017-03-27 16:25:25 -07:00
router_test.go	htlcswitch+router: add onion error obfuscation	2017-07-14 19:08:04 -07:00
router.go	htlcswitch+router: add onion error obfuscation	2017-07-14 19:08:04 -07:00

README.md

routing

The routing package implements authentication+validation of channel announcements, pruning of the channel graph, path finding within the network, sending outgoing payments into the network and synchronizing new peers to our channel graph state.

Installation and Updating

$ go get -u github.com/lightningnetwork/lnd/routing