9083007ece
Description of bug: When calling ReceiveNewCommitment() we will progress through methods fetchCommitmentView and addHTLC which will add HTLC outputs to the commitment transaction in the local commitment chain and save the pkScript to the relevant PaymentDescriptor which resides in the corresponding updateLog. Finally the local commitment will be added to the local commitment chain. When the same user next calls SignNextCommitment we will again progress through fetchCommitmentView and addHTLC. In addHTLC we will now overwrite the pkScripts in the PaymentDescriptors with the pkScript from the context of the remote commitment. When we later call RevokeCurrentCommitment and proceed into toChannelDelta, we will not be able to find the correct pkScript in the PaymentDescriptor to match it against the outputs in the commitment transaction. This will lead to the nested function locateOutputIndex returning incorrect values. Fixing the bug: We introduce three new fields in PaymentDescriptor: * ourPkScript * theirPkScript * theirPrevPkScript ourPkScript will include the pkScript for the HTLC from the context of the local commitment. theirPkScript will take the value of the latest pkScript for the HTLC from the context of the remote commitment. theirPrevPkScript will take the second-latest pkScript for the HTLC from the context of the remote commitment. This is the value we use in toChannelDelta when we save a revoked commitment from our peer. The appropriate value of these fields are set in the addHTLC method. Additionally we pass a boolean value to toChannelDelta so we know whether we are operating on a local or remote commitment and grab the correct pkScript in locateUpdateIndex. |
||
---|---|---|
brontide | ||
chainntnfs | ||
channeldb | ||
cmd/lncli | ||
contrib | ||
docker | ||
docs | ||
lnrpc | ||
lnwallet | ||
lnwire | ||
routing | ||
shachain | ||
zpay32 | ||
.gitignore | ||
.travis.yml | ||
breacharbiter.go | ||
config.go | ||
doc.go | ||
features.go | ||
fundingmanager.go | ||
glide.lock | ||
glide.yaml | ||
gotest.sh | ||
htlcswitch.go | ||
invoiceregistry.go | ||
LICENSE | ||
lnd_test.go | ||
lnd.go | ||
log.go | ||
networktest_test.go | ||
networktest.go | ||
params.go | ||
peer_test.go | ||
peer.go | ||
README.md | ||
release.sh | ||
rpcserver.go | ||
server.go | ||
signal.go | ||
utxonursery_test.go | ||
utxonursery.go | ||
version.go |
Lightning Network Daemon
[] (https://travis-ci.org/lightningnetwork/lnd) [] (https://github.com/lightningnetwork/lnd/blob/master/LICENSE) [] (https://webchat.freenode.net/?channels=lnd) [] (https://godoc.org/github.com/lightningnetwork/lnd)
The Lightning Network Daemon (lnd
) - is a complete implementation of a
Lightning Network node and currently
deployed on testnet4
- the Bitcoin Test Network. It utilizes an
upcoming upgrade to Bitcoin: Segregated Witness (segwit
). The
project's codebase uses the btcsuite set
of Bitcoin libraries, and is currently dependant on btcd.
In the current state lnd
is capable of:
- creating channels
- closing channels
- completely managing all channel states (including the exceptional ones!)
- maintaining a fully authenticated+validated channel graph
- performing path finding within the network, passively forwarding incoming payments
- sending outgoing onion-encrypted payments through the network
Lightning Network Specification Compliance
lnd
doesn't yet fully conform to the Lightning Network specification
(BOLT's). BOLT stands
for: Basic of Lightning Technologies. The specifications are currently being drafted
by several groups of implementers based around the world including the
developers of lnd
. The set of specification documents as well as our
implementation of the specification are still a work-in-progress. With that
said, lnd
the current status of lnd
's BOLT compliance is:
- BOLT 1: Base Protocol
lnd
currently utilizes a distinct wire format which was created before the emgergence of the current draft of BOLT specifications. We don't have aninit
message, but we do have analogues to all the other defined message types.
- BOLT 2: Peer Protocol for Channel Management
lnd
implements all the functionality defined within the document, however we currently use a different set of wire messages. Additionally,lnd
uses a distinct commitment update state-machine and doesn't yet support dynamically updating commitment fees.
- BOLT 3: Bitcoin Transaction and Script Formats
lnd
currently uses a commitment design from a prior iteration of the protocol. Revocation secret generation is handled byelkrem
and our scripts are slightly different.
- BOLT 4: Onion Routing Protocol
- BOLT 5: Recommendations for On-chain Transaction Handling
- BOLT 7: P2P Node and Channel Discovery
- BOLT 8: Encrypted and Authenticated Transport
Installation
In order to build from source, the following build dependencies are required:
-
Go: Installation instructions can be found here.
It is recommended to add
$GOPATH/bin
to yourPATH
at this point. Note: If you are building withGo 1.5
, then you'll need to enable the vendor experiment by setting theGO15VENDOREXPERIMENT
environment variable to1
. If you're usingGo 1.6
or later, then it is safe to skip this step. -
Glide: This project uses
Glide
to manage dependencies as well as to provide reproducible builds. To installGlide
, execute the following command (assumes you already have Go properly installed):$ go get -u github.com/Masterminds/glide
-
btcd: This project currently requires
btcd
with segwit support, which is not yet merged into the master branch. Instead, roasbeef maintains a fork with his segwit implementation applied. To install, please see the installation instructions.
With the preliminary steps completed, to install lnd
, lncli
, and all
related dependencies run the following commands:
$ git clone https://github.com/lightningnetwork/lnd $GOPATH/src/github.com/lightningnetwork/lnd
$ cd $GOPATH/src/github.com/lightningnetwork/lnd
$ glide install
$ go install . ./cmd/...
Updating
To update your version of lnd
to the latest version run the following
commands:
$ cd $GOPATH/src/github.com/lightningnetwork/lnd
$ git pull && glide install
$ go install . ./cmd/...
Tests
To check that lnd
was installed properly run the following command:
go install; go test -v -p 1 $(go list ./... | grep -v '/vendor/')
IRC
- irc.freenode.net
- channel #lnd
- webchat