lnd.xprv/contractcourt
Olaoluwa Osuntokun 5f0fad85be multi: address lingering TODO by no longer wiping out local HTLCs on remote close
In this commit, we fix a lingering TOOD statement in the channel arb.
Before this commitment, we would simply wipe our our local HTLC set of
the HTLC set that was on the remote commitment transaction on force
close. This was incorrect as if our commitment transaction had an HTLC
that the remote commitment didn't, then we would fail to cancel that
back, and cause both channels to time out on chain.

In order to remedy this, we introduce a new `HtlcSetKey` struct to track
all 3 possible in-flight set of HTLCs: ours, theirs, and their pending.

We also we start to tack on additional data to all the unilateral close
messages we send to subscribers. This new data is the CommitSet, or the
set of valid commitments at channel closure time. This new information
will be used by the channel arb in an upcoming commit to ensure it will
cancel back HTLCs in the case of split commitment state.

Finally, we start to thread through an optional *CommitSet to the
advanceState method. This additional information will give the channel
arb addition information it needs to ensure it properly cancels back
HTLCs that are about to time out or may time out depending on which
commitment is played.

Within the htlcswitch pakage, we modify the `SignNextCommitment` method
to return the new set of pending HTLCs for the remote party's commitment
transaction and `ReceiveRevocation` to return the latest set of
commitment transactions on the remote party's commitment as well. This
is a preparatory change which is part of a larger change to address a
lingering TODO in the cnct.

Additionally, rather than just send of the set of HTLCs after the we
revoke, we'll also send of the set of HTLCs after the remote party
revokes, and we create a pending commitment state for it.
2019-05-27 14:34:13 -07:00
..
briefcase_test.go cnct: use sweeper in commit resolver 2019-02-01 09:20:45 +01:00
briefcase.go multi: move Input interface and related code 2019-01-31 13:25:33 +01:00
chain_arbitrator_test.go contractcourt: add new ChainArbitrator struct as central coordinator of package 2018-01-22 19:19:36 -08:00
chain_arbitrator.go multi: address lingering TODO by no longer wiping out local HTLCs on remote close 2019-05-27 14:34:13 -07:00
chain_watcher_test.go multi: address lingering TODO by no longer wiping out local HTLCs on remote close 2019-05-27 14:34:13 -07:00
chain_watcher.go multi: address lingering TODO by no longer wiping out local HTLCs on remote close 2019-05-27 14:34:13 -07:00
channel_arbitrator_test.go multi: address lingering TODO by no longer wiping out local HTLCs on remote close 2019-05-27 14:34:13 -07:00
channel_arbitrator.go multi: address lingering TODO by no longer wiping out local HTLCs on remote close 2019-05-27 14:34:13 -07:00
commit_sweep_resolver.go cnct: fix error returning bug 2019-02-26 12:56:21 -03:00
contract_resolvers.go cnct: expose non-incubating htlcs after channel force close 2019-02-01 09:36:47 +01:00
htlc_incoming_contest_resolver.go cnct+htlcswitch+invoices: move invoice parameter check out of link 2019-05-15 14:42:12 +02:00
htlc_incoming_resolver_test.go cnct/test: add incoming contest resolver test 2019-05-15 14:42:18 +02:00
htlc_outgoing_contest_resolver.go contractcourt: extract which timeout HTLC output to watch into new method 2019-03-19 16:50:09 -07:00
htlc_success_resolver.go cnct+htlcswitch+invoices: move invoice parameter check out of link 2019-05-15 14:42:12 +02:00
htlc_timeout_resolver_test.go cnct/test: extend mockWitnessBeacon 2019-05-15 14:42:15 +02:00
htlc_timeout_resolver.go contractcourt: simplify htlcTimeoutResolver, unify with HTLC contest logic 2019-03-19 16:50:27 -07:00
interfaces.go cnct+htlcswitch+invoices: move invoice parameter check out of link 2019-05-15 14:42:12 +02:00
log.go multi: init subsystem loggers via build pkg 2018-10-05 13:04:45 +09:00
mock_registry_test.go cnct/test: add incoming contest resolver test 2019-05-15 14:42:18 +02:00
utils_test.go cnct/test: add incoming contest resolver test 2019-05-15 14:42:18 +02:00