403d37f426
In this commit, we fix an issue that would cause peers running lnd 0.12 to not be able to connect to existing peers due to a feature bit compatibility issue. In a recent PR we started to downgrade our required feature bit for static key from required to optional, if we had a legacy (non-tweakless) open with the peer then we would unset the required bit and set the optional bit to ensure we could still connect to them. The change implementing this new version of downgrade failed _also_ unset the bit (the required bit) in the "legacy global" feature bit section. This caused the `RawFeatureVector.Merge` method to fail as we would have the required bit set in the `GlobalFeatures` section, but the optional bit set in the `Features` section. The `Merge` method ensures that a required and optional bit can't be set in two different locations for the same feature. This PR fixes this issue by also unsetting the bit in the `GlobalFeatures` field in the init message. Fixes #4871 |
||
|---|---|---|
| .. | ||
| brontide_test.go | ||
| brontide.go | ||
| interfaces.go | ||
| log.go | ||
| test_utils.go | ||