AdamISZ
567306b010
Add a maxconfirms argument to ListUnspentWitness
...
This change was inspired by #1984 - the underlying call to
ListUnspent supports a (min, max) range so it makes sense that
the WalletController interface can also support this; a
default no-maximum can be expressed using a MaxInt32 value.
2018-10-28 15:55:18 +01:00
Olaoluwa Osuntokun
eaba39d20e
Merge pull request #1787 from cfromknecht/isolate-scanning-ntfns
...
chainntnfs: Isolate conf notifications during historical scans
2018-10-26 19:08:18 -07:00
Conner Fromknecht
ba28ec3be0
chainntnfs/neutrinonotify/neutrino: fix debug logs
2018-10-26 18:32:32 -07:00
Conner Fromknecht
e03c818aa7
chainntnfs/txconfnotifier: remove ntfn details, bound conf depth
...
Removes details field from conf notifications, in favor
of using the details on the confSet. We also bound the
requested conf depth to the reorg saftey limit, as the
behavior of state tracking within the notifier is
undefined otherwise.
2018-10-26 18:32:31 -07:00
Wilmer Paulino
589dc96d88
chainntnfs/tx_notifier: extract conf reorg dispatch into method
2018-10-26 18:32:31 -07:00
Wilmer Paulino
5ae8243d0d
chainntnfs/tx_notifier: remove cached conf details on reorg
...
In this commit, we address a small bug where it's possible to deliver a
confirmation notification with stale confirmation details upon
registration. This can happen if a transaction has confirmed but was
reorged out of the chain later on, and a subsequent notification is
registered.
2018-10-26 18:32:31 -07:00
Wilmer Paulino
b28145b69e
chainntnfs/tx_notifier: consume reorg notification for transactions on block inclusion
...
In this commit, we'll attempt to consume a reorg notification for a
transaction that was previously reorged out of the chain upon block
inclusion to ensure that it is not lingering due to a client not
handling it the first time.
2018-10-26 18:32:31 -07:00
Wilmer Paulino
a4dee14b20
chainntnfs/tx_notifier: mark rescan as complete for transactions confirmed at tip
...
In this commit, we mark the rescan status for a transaction as complete
if we happen to detect it has confirmed within a new block that extends
the chain. We do this as otherwise, it's possible for us to not
immediately dispatch the notification upon a subsequent registration due
to the rescan state machine.
2018-10-26 18:32:31 -07:00
Conner Fromknecht
eee5311557
chainntnfs/txconnotifier: add debug logs, log errs/warnings, godocs
2018-10-26 18:32:31 -07:00
Conner Fromknecht
2dcb86bced
chainntnfs/txconfnotifier: set confset details at tip
...
This commit ensures that a confSet's details
are assigned in the confNotifications index
after discovering the transaction at tip. The
recent changes allow a later notification to
be dispatched on registration if an earlier one
has already discovered the confirmation details.
Before this change, it was observed that a later
registration would attempt an immediate delivery,
but fail to do so because the confset's details
were nil. This commit remedies that dispatch path,
allowing the integration tests to pass again.
2018-10-26 18:32:30 -07:00
Conner Fromknecht
df9bb56068
chainntnfs/neutrino: use HistoricalConfDispatch in ntfn registry
2018-10-26 18:32:30 -07:00
Conner Fromknecht
6cd0f867ad
chainntnfs/btcd: use HistoricalConfDispatch in ntfn registry
2018-10-26 18:32:30 -07:00
Conner Fromknecht
a4c9f62c6b
chainntnfs/bitcoind: use HistoricalConfDispatch in ntfn registry
2018-10-26 18:32:30 -07:00
Conner Fromknecht
11c231d814
chainntnfs/txconfnotifier_test: remove clientID argument...
...
to UpdateConfDetails
2018-10-26 18:32:30 -07:00
Conner Fromknecht
32e7368e1e
chainntnfs/txconfnotifier: remove clientID from UpdateConfDetails signature
2018-10-26 18:32:30 -07:00
Conner Fromknecht
9ae6d43916
chainntnfs/txconfnotifier: split out ntfn dispatch into helper
2018-10-26 18:32:30 -07:00
Conner Fromknecht
217b1fc0ef
chainntnfs/txconfnotifier: return HistoricalConfDispatch from Register
2018-10-26 18:32:29 -07:00
Conner Fromknecht
f94de2308f
chainntnfs/txconfnotifier: return HistoricalConfDispatch from Register
2018-10-26 18:32:29 -07:00
Conner Fromknecht
74122e00f5
chainntnfs/txconfnotifier: add PkScript to ConfNtfn
2018-10-26 18:32:29 -07:00
Conner Fromknecht
37c864d6f6
chainntnfs/txconfnotifier: add HistoricalConfDispatch struct
2018-10-26 18:32:29 -07:00
Conner Fromknecht
e804b30669
chainntnfs/txconfnotifier_test: update to use multi-value Register
2018-10-26 18:32:29 -07:00
Conner Fromknecht
cf7700e6cb
chainntnfs/bitcoind+btcd+neutrino: let tcn query for height hint
2018-10-26 18:32:29 -07:00
Conner Fromknecht
8b8007bb5a
chainntnfs/txconfnotifier: query conf hint in Register
2018-10-26 18:32:28 -07:00
Conner Fromknecht
a1756b0b1b
chainntnfs/bitcoind+btcd+neutrino: pass nil conf details
2018-10-26 18:32:28 -07:00
Conner Fromknecht
1babec971f
chainntnfs/txconfnotifier: isolate scanning ntfns
2018-10-26 18:32:28 -07:00
Conner Fromknecht
2f0b5596da
chainntnfs/txconfnotifier: add rescanStates
2018-10-26 18:32:28 -07:00
Conner Fromknecht
012d17efaa
chainntnfs/txnotifier_test: update nil spend details to restore tests
2018-10-26 18:32:28 -07:00
Conner Fromknecht
7661d00d5a
chainntnfs/txconfnotifier_test: update height hint cache test
2018-10-26 18:32:28 -07:00
Conner Fromknecht
d3bde428ea
chainntnfs/txconfnotifier_test: use tcn instead of txConfNotifier
2018-10-26 18:32:28 -07:00
Olaoluwa Osuntokun
3b9aa2e7b5
Merge pull request #2053 from BobleChinois/docs/configuring_tor
...
update 'configuring_tor' file
2018-10-26 17:13:09 -07:00
Vincent Woo
8103db60de
Show how macaroon interceptor can work with streaming gRPC in Ruby doc
2018-10-26 14:17:35 -07:00
Olaoluwa Osuntokun
4cf332ba36
Merge pull request #2104 from wpaulino/funding-broadcast-err
...
fundingmanager: identify tx on funding broadcast error
2018-10-26 13:56:01 -07:00
Vincent Woo
6dd4fde56a
Fix incorrect hash key in gRPC Ruby documentation
2018-10-26 13:24:30 -07:00
Wilmer Paulino
a15be80a45
fundingmanager: identify tx on funding broadcast error
2018-10-26 10:07:36 -07:00
Olaoluwa Osuntokun
65b2ad9757
Merge pull request #2098 from Roasbeef/neutrino-update-cfheader-fix
...
build: update to latest neutrino commit
2018-10-25 18:49:03 -07:00
Olaoluwa Osuntokun
f0b8cb1293
Merge pull request #1981 from wpaulino/routing-hints-unadvertised-nodes
...
rpc+server: ensure we don't leak unadvertised nodes within invoice routing hints
2018-10-25 18:46:10 -07:00
Olaoluwa Osuntokun
da00323872
build: update to latest neutrino commit
...
In this commit, we update to the latest version of neutrino. This
version has an important bug fixes which fixes an issue where we
wouldn't detect a duplicate incoming cfheader message, and panic due to
trying to write the same header twice.
2018-10-25 17:52:44 -07:00
Olaoluwa Osuntokun
de186b4a06
Revert "make: ensure make fmt is run with -s flag"
...
This reverts commit e8003af3cd7b7a08f8e34233e2071a70245b3c69.
2018-10-25 17:11:33 -07:00
Olaoluwa Osuntokun
071cbcc1ef
Merge pull request #2092 from halseth/make-fmt
...
make: ensure make fmt is run with -s flag
2018-10-25 16:38:36 -07:00
Conner Fromknecht
b0318e2b74
config: validate node color after reading config
2018-10-24 22:10:18 -07:00
Olaoluwa Osuntokun
5c6c966891
Merge pull request #1535 from cfromknecht/wtwire-server
...
[watchtower/server] Server-Side Wire Protocol
2018-10-24 21:43:11 -07:00
Conner Fromknecht
712e7f08f0
watchtower/server/server_test: add test vectors for server behavior
2018-10-24 20:18:22 -07:00
Conner Fromknecht
db4c4488c5
watchtower/server/mock: create MockPeer for debug build
2018-10-24 20:18:22 -07:00
Conner Fromknecht
48643a1747
watchtower/server/interface: adds Server, Peer and DB
2018-10-24 20:18:22 -07:00
Conner Fromknecht
a3e1bb15c5
watchtower/server/log: adds wt SRVR sublogger
2018-10-24 20:18:21 -07:00
Conner Fromknecht
73709530e3
watchtower/server/server: server skeleton
2018-10-24 20:18:21 -07:00
Conner Fromknecht
fd6024c306
watchtower/wtdb/mock: adds MockDB for debug build
2018-10-24 20:18:21 -07:00
Conner Fromknecht
8b47a96459
watchtower/wtdb/session_state_update: adds session state
2018-10-24 20:18:21 -07:00
Conner Fromknecht
405838d29c
watchtower/wtdb/session_info: adds SessionInfo
2018-10-24 20:18:21 -07:00
Conner Fromknecht
e825a756f4
watchtower/wtdb/session_id: adds SessoinID, client pubkey
2018-10-24 20:18:21 -07:00
