Olaoluwa Osuntokun
c2e7ca9b5f
Merge pull request #4300 from guggero/no-fastsha
...
channeldb+htlcswitch: don't use fastsha256 in tests
2020-05-21 17:21:50 -07:00
Wilmer Paulino
77a4bc97a7
Merge pull request #4304 from guggero/peer-alignment
...
peer: fix struct alignment
2020-05-21 19:05:21 +00:00
Oliver Gugger
42ac187932
peer: fix struct alignment
...
Integers used atomically MUST be aligned properly, otherwise the
sync library will crash on purpose. Therefore non-aligned struct
members must come later.
2020-05-21 11:28:49 +02:00
Conner Fromknecht
64b8aa8f11
Merge pull request #4227 from guggero/signing-abstraction
...
multi: Remove need for DerivePrivKey from watchtower, brontide, netann and sphinx package
2020-05-20 16:07:44 -07:00
Wilmer Paulino
f287ac3cea
btcwallet: add transaction outputs bounds check to FetchInputInfo
...
This prevents a panic when providing an incompatible output index for
the transaction.
2020-05-20 11:42:12 -07:00
Joost Jager
d2f6140818
itest: extend whitelist
2020-05-20 17:24:36 +02:00
Joost Jager
e201ed8106
itest: switch over to routerrpc.SendPaymentV2
2020-05-20 17:23:52 +02:00
Joost Jager
ca9c58aec9
Merge pull request #4183 from joostjager/sync-local-payment
...
htlcswitch: sync local payment hand-off to link
2020-05-20 11:23:15 +02:00
Oliver Gugger
a17ddc5dd1
channeldb+htlcswitch: don't use fastsha256 in tests
...
The btcsuite/fastsha256 registers itself in the crypto package of
golang as a replacement for sha256. This causes problems in TLS1.3
connections that require the hash implementations to be serializable
and results in the "tls: internal error: failed to clone hash" error.
By removing all uses of the library we fix that error.
2020-05-20 11:07:38 +02:00
Oliver Gugger
3afaed8b5c
rpcserver: fix linter error
2020-05-20 09:12:53 +02:00
Oliver Gugger
36b90382d3
lnd+server+keychain: remove unused code
2020-05-20 09:07:21 +02:00
Oliver Gugger
08d6a61e2a
signrpc: use DigestSigner interface for signing
2020-05-20 09:06:59 +02:00
Oliver Gugger
4003f25281
signrpc: use ECDH interface for shared key generation
2020-05-20 09:06:58 +02:00
Oliver Gugger
f97e7b9951
watchtower: use ECDH interface for watchtower session
2020-05-20 09:06:57 +02:00
Oliver Gugger
535a22c590
server+brontide: use ECDH interface for brontide handshake
2020-05-20 09:06:56 +02:00
Oliver Gugger
ee74e4ba86
server+mod: use ECDH interface for sphinx router
2020-05-20 09:05:36 +02:00
Oliver Gugger
be890ef9be
lnd+server+netann: use signing interface in node signer
2020-05-20 09:05:35 +02:00
Oliver Gugger
6f702a43aa
watchtower: extend and rename SecretKeyRing
2020-05-20 09:05:15 +02:00
Oliver Gugger
b0cb110e86
watchtower: rename SessionPrivKey to SessionKeyECDH
2020-05-20 09:05:15 +02:00
Oliver Gugger
140731af00
lnd+watchtower: rename NodePrivKey to NodeKeyECDH
2020-05-20 09:05:14 +02:00
Oliver Gugger
7f1b865b53
multi: rename server's identityPriv to identityECDH
2020-05-20 09:05:14 +02:00
Oliver Gugger
cf0380ac81
keychain: add single key wrapper implementations
2020-05-20 09:04:05 +02:00
Oliver Gugger
6cf1844b0e
keychain: add new interface methods to wallet
2020-05-20 09:04:04 +02:00
Oliver Gugger
d6ba0a5b85
keychain: add new abstraction interfaces
2020-05-20 09:04:04 +02:00
Joost Jager
8119dc7a88
htlcswitch: rename to getLocalLink
...
Align function name with the contained logic.
2020-05-20 08:03:52 +02:00
Joost Jager
e00840e2ab
htlcswitch: return local add failure to caller
...
Fixes a pre-existing issue where nil was returned when a failure had
occurred during commiting of the circuit.
2020-05-20 08:03:50 +02:00
Joost Jager
c325bf8c57
htlcswitch: sync link hand-off
...
This commit extends the link with a new synchronous delivery point for
local UpdateAddHTLC messages. The switch method SendHTLC is updated to
use this delivery point and thereby becomes a synchronous call.
For MPP payments, synchronous hand-off is important. Otherwise the next
pathfinding round could start without the channel balance updated yet.
2020-05-20 08:03:48 +02:00
Joost Jager
de2df5606a
htlcswitch: extract handleDownstreamUpdateAdd in link
...
To be able to call just the UpdateAdd logic for synchronously handled
local adds in a later commit.
2020-05-20 08:03:46 +02:00
Joost Jager
55930df70d
htlcswitch: update commit tx per downstream msg type
...
Unroll common code to allow splitting in separate handlers per message
type.
2020-05-20 08:03:44 +02:00
Joost Jager
b559811bf5
htlcswitch: extract updateCommitTxOrFail in link
...
Deduplicate code and prepare for further split of
handleDownstreamPkt.
2020-05-20 08:03:42 +02:00
Joost Jager
7afb43a012
htlcswitch: bypass main loop for local sends
...
There is no concurrent access in this code path, so there is no need to
pass the call through the main event loop.
2020-05-20 08:03:40 +02:00
Joost Jager
fe35d35458
htlcswitch: simplify local sends
...
Embed forward method into SendHTLC and remove redundant type check.
2020-05-20 08:03:38 +02:00
Joost Jager
babb0a36b4
switch/test: use external interface for testing
...
Previously the forward(...) method was used in forwarding tests,
while that code path isn't used for forwards in reality.
2020-05-20 08:03:36 +02:00
Conner Fromknecht
afc60353a1
Merge pull request #4213 from carlaKC/txdetails-addlabel
...
lnrpc: add optional labels to on chain transactions
2020-05-19 14:44:55 -07:00
carla
d021eae392
itest: add label check to sweep coins test
...
Add a label to our sweep all coins itest and check that it is correctly
set.
2020-05-19 13:31:51 +02:00
carla
e8ca306f12
lnrpc: display transaction label in transaction details
2020-05-19 13:31:51 +02:00
carla
52137459e4
lncli: add label flag to send many and send coins
2020-05-19 13:31:51 +02:00
carla
93a1b61218
walletrpc: add transaction label to PublishTransaction
2020-05-19 13:31:51 +02:00
carla
099161ed0b
multi: add label to WalletController SendOutputs and dependent rpcs
...
Add a label parameter to the WalletController SendOutputs endpoint and
update rpcs that use it to allow optional provision of labels.
2020-05-19 13:31:51 +02:00
carla
75370ce6b4
multi: update WalletController PublishTransaction to include label
...
Add label parameter to PublishTransaction in WalletController
interface. A labels package is added to store generic labels that are
used for the different types of transactions that are published by lnd.
To keep commit size down, the two endpoints that require a label
parameter be passed down have a todo added, which will be removed in
subsequent commits.
2020-05-19 13:30:00 +02:00
Olaoluwa Osuntokun
c2516d9352
Merge pull request #4286 from guggero/remove-global-cfg
...
multi: remove global cfg variable
2020-05-18 19:45:43 -07:00
Olaoluwa Osuntokun
34e21eca78
Merge pull request #4291 from wpaulino/btcd-getblock-compat
...
build: update to latest btcd and btcwallet versions
2020-05-18 18:25:01 -07:00
Wilmer Paulino
db2589ee8d
itest: add disconnection error to whitelist
2020-05-18 16:14:31 -07:00
Oliver Gugger
4d3bd6f178
Merge pull request #4295 from guggero/fix-queue
...
mod: update to queue/v1.0.4
2020-05-18 14:51:16 +02:00
Carla Kirk-Cohen
bdb6a3cc7b
Merge pull request #4294 from carlaKC/actions-updatecheckout
...
github: update checkout action to v2
2020-05-18 14:05:04 +02:00
Oliver Gugger
bd40f73be3
mod: update to queue/v1.0.4
2020-05-18 11:52:49 +02:00
carla
d29271f1da
github: update checkout action to v2
...
Checkout v1 has a known flake:
https://github.com/actions/checkout/issues/23#issuecomment-572688577 .
For our linter to pass, we need to checkout our full history (default
depth is 1 commit). We could set fetch-depth, but we will eventually
move that depth past the linter's start point commit and need to
implement another fix. Indead, we add an extra step in our linter to
fetch full history so that the linter reference commit is found.
2020-05-18 11:39:09 +02:00
Wilmer Paulino
0e3fc4c7a6
build: update to latest btcd and btcwallet versions
...
This update introduces backwards compatibility for btcd nodes running
versions prior to v0.20.1-beta.
2020-05-15 17:00:16 -07:00
Olaoluwa Osuntokun
280bf8d26c
Merge pull request #4226 from breez/fix-chainrpc-crash
...
Fix crash when ChainNotifier is being accessed too early.
2020-05-15 16:17:40 -07:00
Olaoluwa Osuntokun
02f8a0db2b
Merge pull request #4277 from joostjager/fix-signer-err
...
lnwallet: return signer error
2020-05-15 16:15:50 -07:00
