akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

routing/pathfind_test: constructed sorted edge policies

Browse Source 
This commit fixes a potential bug in our test harness, by ensuring that
the constructed node policies are configured _after_ sorting. Currently
the node pubkeys are sorted, but additional parameters (max htlc,
disabled, etc) are applied using the unsorted policies.

Most of the constructors used today use the symmetric channel
constructor, so this shouldn't cause an issue with the majority of our
tests. We recently introduced an asymmetric channel constructor for
which this could have been an issue, however, no known issues were
discovered.

Lastly, we remove the direction from the configuration altogether, and
derive it purely from the final sorting of the pubkeys.
This commit is contained in:
Conner Fromknecht 2019-12-19 03:35:16 -08:00
parent 8ce9e15f4a
commit ff443a389b
No known key found for this signature in database
GPG Key ID: E7D737B67FA592C7
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
routing/pathfind_test.go
View File

@ -339,7 +339,6 @@ type testChannelPolicy struct {
FeeRate lnwire.MilliSatoshi FeeRate lnwire.MilliSatoshi
LastUpdate time.Time LastUpdate time.Time
Disabled bool Disabled bool
Direction bool
Features *lnwire.FeatureVector Features *lnwire.FeatureVector
} }
@ -359,7 +358,6 @@ func symmetricTestChannel(alias1, alias2 string, capacity btcutil.Amount,
} }
policy2 := *policy policy2 := *policy
policy2.Direction = !policy.Direction
return asymmetricTestChannel( return asymmetricTestChannel(
alias1, alias2, capacity, policy, &policy2, id, alias1, alias2, capacity, policy, &policy2, id,
@ -554,18 +552,16 @@ func createTestGraphFromChannels(testChannels []*testChannel, source string) (
return nil, err return nil, err
} }
if testChannel.Node1.testChannelPolicy != nil { if node1.testChannelPolicy != nil {
var msgFlags lnwire.ChanUpdateMsgFlags var msgFlags lnwire.ChanUpdateMsgFlags
if testChannel.Node1.MaxHTLC != 0 { if node1.MaxHTLC != 0 {
msgFlags |= lnwire.ChanUpdateOptionMaxHtlc msgFlags |= lnwire.ChanUpdateOptionMaxHtlc
} }
var channelFlags lnwire.ChanUpdateChanFlags var channelFlags lnwire.ChanUpdateChanFlags
if testChannel.Node1.Disabled { if node1.Disabled {
channelFlags |= lnwire.ChanUpdateDisabled channelFlags |= lnwire.ChanUpdateDisabled
} }
if testChannel.Node1.Direction {
channelFlags |= lnwire.ChanUpdateDirection
}
edgePolicy := &channeldb.ChannelEdgePolicy{ edgePolicy := &channeldb.ChannelEdgePolicy{
SigBytes: testSig.Serialize(), SigBytes: testSig.Serialize(),
MessageFlags: msgFlags, MessageFlags: msgFlags,
@ -583,18 +579,17 @@ func createTestGraphFromChannels(testChannels []*testChannel, source string) (
} }
} }
if testChannel.Node2.testChannelPolicy != nil { if node2.testChannelPolicy != nil {
var msgFlags lnwire.ChanUpdateMsgFlags var msgFlags lnwire.ChanUpdateMsgFlags
if testChannel.Node2.MaxHTLC != 0 { if node2.MaxHTLC != 0 {
msgFlags |= lnwire.ChanUpdateOptionMaxHtlc msgFlags |= lnwire.ChanUpdateOptionMaxHtlc
} }
channelFlags := lnwire.ChanUpdateChanFlags(0) var channelFlags lnwire.ChanUpdateChanFlags
if testChannel.Node2.Disabled { if node2.Disabled {
channelFlags |= lnwire.ChanUpdateDisabled channelFlags |= lnwire.ChanUpdateDisabled
} }
if testChannel.Node2.Direction {
channelFlags |= lnwire.ChanUpdateDirection channelFlags |= lnwire.ChanUpdateDirection
}
edgePolicy := &channeldb.ChannelEdgePolicy{ edgePolicy := &channeldb.ChannelEdgePolicy{
SigBytes: testSig.Serialize(), SigBytes: testSig.Serialize(),
MessageFlags: msgFlags, MessageFlags: msgFlags,