Merge pull request #4794 from halseth/bork-channels-revert
htlcswitch/link: revert borking channels on received Errors
This commit is contained in:
commit
fd00a3a5e7
@ -1902,8 +1902,15 @@ func (l *channelLink) handleUpstreamMsg(msg lnwire.Message) {
|
|||||||
// characters are printable ASCII.
|
// characters are printable ASCII.
|
||||||
l.fail(
|
l.fail(
|
||||||
LinkFailureError{
|
LinkFailureError{
|
||||||
code: ErrRemoteError,
|
code: ErrRemoteError,
|
||||||
PermanentFailure: true,
|
|
||||||
|
// TODO(halseth): we currently don't fail the
|
||||||
|
// channel permanently, as there are some sync
|
||||||
|
// issues with other implementations that will
|
||||||
|
// lead to them sending an error message, but
|
||||||
|
// we can recover from on next connection. See
|
||||||
|
// https://github.com/ElementsProject/lightning/issues/4212
|
||||||
|
PermanentFailure: false,
|
||||||
},
|
},
|
||||||
"ChannelPoint(%v): received error from peer: %v",
|
"ChannelPoint(%v): received error from peer: %v",
|
||||||
l.channel.ChannelPoint(), msg.Error(),
|
l.channel.ChannelPoint(), msg.Error(),
|
||||||
|
@ -5273,7 +5273,9 @@ func TestChannelLinkFail(t *testing.T) {
|
|||||||
c.HandleChannelUpdate(err)
|
c.HandleChannelUpdate(err)
|
||||||
},
|
},
|
||||||
false,
|
false,
|
||||||
true,
|
// TODO(halseth) For compatibility with CL we currently
|
||||||
|
// don't treat Errors as permanent errors.
|
||||||
|
false,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user