akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

contractcourt: change shouldGoOnChain signature.

Browse Source 
This commit changes the shouldGoOnChain signature to get the htlc
as parameter. I will allow the function to take decisions based on
whether the htlc is Incoming or Outgoing.
This commit is contained in:
Roei Erez 2020-02-03 12:46:21 +02:00
parent f289a39c1a
commit f8da26ee30
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
contractcourt/channel_arbitrator.go
View File

@ -1113,17 +1113,17 @@ func (c ChainActionMap) Merge(actions ChainActionMap) {
// we should go on chain to claim. We do this rather than waiting up until the // we should go on chain to claim. We do this rather than waiting up until the
// last minute as we want to ensure that when we *need* (HTLC is timed out) to // last minute as we want to ensure that when we *need* (HTLC is timed out) to
// sweep, the commitment is already confirmed. // sweep, the commitment is already confirmed.
func (c *ChannelArbitrator) shouldGoOnChain(htlcExpiry, broadcastDelta, func (c *ChannelArbitrator) shouldGoOnChain(htlc channeldb.HTLC,
currentHeight uint32) bool { broadcastDelta, currentHeight uint32) bool {
// We'll calculate the broadcast cut off for this HTLC. This is the // We'll calculate the broadcast cut off for this HTLC. This is the
// height that (based on our current fee estimation) we should // height that (based on our current fee estimation) we should
// broadcast in order to ensure the commitment transaction is confirmed // broadcast in order to ensure the commitment transaction is confirmed
// before the HTLC fully expires. // before the HTLC fully expires.
broadcastCutOff := htlcExpiry - broadcastDelta broadcastCutOff := htlc.RefundTimeout - broadcastDelta
log.Tracef("ChannelArbitrator(%v): examining outgoing contract: "+ log.Tracef("ChannelArbitrator(%v): examining outgoing contract: "+
"expiry=%v, cutoff=%v, height=%v", c.cfg.ChanPoint, htlcExpiry, "expiry=%v, cutoff=%v, height=%v", c.cfg.ChanPoint, htlc.RefundTimeout,
broadcastCutOff, currentHeight) broadcastCutOff, currentHeight)
// TODO(roasbeef): take into account default HTLC delta, don't need to // TODO(roasbeef): take into account default HTLC delta, don't need to
@ -1162,8 +1162,7 @@ func (c *ChannelArbitrator) checkCommitChainActions(height uint32,
for _, htlc := range htlcs.outgoingHTLCs { for _, htlc := range htlcs.outgoingHTLCs {
// We'll need to go on-chain for an outgoing HTLC if it was // We'll need to go on-chain for an outgoing HTLC if it was
// never resolved downstream, and it's "close" to timing out. // never resolved downstream, and it's "close" to timing out.
toChain := c.shouldGoOnChain( toChain := c.shouldGoOnChain(htlc, c.cfg.OutgoingBroadcastDelta,
htlc.RefundTimeout, c.cfg.OutgoingBroadcastDelta,
height, height,
) )
@ -1194,8 +1193,7 @@ func (c *ChannelArbitrator) checkCommitChainActions(height uint32,
continue continue
} }
toChain := c.shouldGoOnChain( toChain := c.shouldGoOnChain(htlc, c.cfg.IncomingBroadcastDelta,
htlc.RefundTimeout, c.cfg.IncomingBroadcastDelta,
height, height,
) )
@ -1245,8 +1243,7 @@ func (c *ChannelArbitrator) checkCommitChainActions(height uint32,
// mark it still "live". After we broadcast, we'll monitor it // mark it still "live". After we broadcast, we'll monitor it
// until the HTLC times out to see if we can also redeem it // until the HTLC times out to see if we can also redeem it
// on-chain. // on-chain.
case !c.shouldGoOnChain( case !c.shouldGoOnChain(htlc, c.cfg.OutgoingBroadcastDelta,
htlc.RefundTimeout, c.cfg.OutgoingBroadcastDelta,
height, height,
): ):
// TODO(roasbeef): also need to be able to query // TODO(roasbeef): also need to be able to query
@ -1415,8 +1412,7 @@ func (c *ChannelArbitrator) checkRemoteDanglingActions(
for _, htlc := range pendingRemoteHTLCs { for _, htlc := range pendingRemoteHTLCs {
// We'll now check if we need to go to chain in order to cancel // We'll now check if we need to go to chain in order to cancel
// the incoming HTLC. // the incoming HTLC.
goToChain := c.shouldGoOnChain( goToChain := c.shouldGoOnChain(htlc, c.cfg.OutgoingBroadcastDelta,
htlc.RefundTimeout, c.cfg.OutgoingBroadcastDelta,
height, height,
) )