From e175a645409c1d5c868f37fcc503e70b711f0cbf Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Tue, 12 May 2020 10:06:22 +0200 Subject: [PATCH] github: remove continue-on-error The continue-on-error was added to make sure the log files of the failed itests would always be uploaded. But this has the side effect of marking the whole job successful, even if the itest job itself failed. The failure condition in the log file steps already solve that, so the continue-on-error is not needed anymore. --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f60a9895..75a5a86e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -257,7 +257,6 @@ jobs: - name: ${{ matrix.backend }} integration run: make itest backend=${{ matrix.backend }} - continue-on-error: true - name: package logfiles run: tar -zcvf itest-logs-${{ matrix.backend }}.tar.gz lntest/itest/*.log