akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zpay32: invoice.MilliSat is uint64 which cannot be negative

Browse Source
This commit is contained in:
Andras Banki-Horvath 2020-04-09 19:14:01 +02:00
parent 1a13f822c6
commit da9d7dd363
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zpay32/amountunits.go
View File

@ -127,10 +127,6 @@ func decodeAmount(amount string) (lnwire.MilliSatoshi, error) {
// encodeAmount encodes the provided millisatoshi amount using as few characters // encodeAmount encodes the provided millisatoshi amount using as few characters
// as possible. // as possible.
func encodeAmount(msat lnwire.MilliSatoshi) (string, error) { func encodeAmount(msat lnwire.MilliSatoshi) (string, error) {
if msat < 0 {
return "", fmt.Errorf("amount must be positive: %v", msat)
}
// If possible to express in BTC, that will always be the shortest // If possible to express in BTC, that will always be the shortest
// representation. // representation.
if msat%mSatPerBtc == 0 { if msat%mSatPerBtc == 0 {

5
zpay32/invoice.go
View File

@ -571,11 +571,6 @@ func validateInvoice(invoice *Invoice) error {
return fmt.Errorf("net params not set") return fmt.Errorf("net params not set")
} }
// Ensure that if there is an amount set, it is not negative.
if invoice.MilliSat != nil && *invoice.MilliSat < 0 {
return fmt.Errorf("negative amount: %v", *invoice.MilliSat)
}
// The invoice must contain a payment hash. // The invoice must contain a payment hash.
if invoice.PaymentHash == nil { if invoice.PaymentHash == nil {
return fmt.Errorf("no payment hash found") return fmt.Errorf("no payment hash found")