akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3129 from Roasbeef/scb-fix-windows

Browse Source 
chanbackup: close temp SCB file before rename
This commit is contained in:
Conner Fromknecht 2019-05-28 16:11:30 -07:00 committed by GitHub
commit cd285d6bb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
chanbackup/backupfile.go
View File

@ -113,6 +113,13 @@ func (b *MultiFile) UpdateAndSwap(newBackup PackedMulti) error {
log.Infof("Swapping old multi backup file from %v to %v", log.Infof("Swapping old multi backup file from %v to %v",
b.tempFileName, b.fileName) b.tempFileName, b.fileName)
// Before we rename the swap (atomic name swap), we'll make
// sure to close the current file as some OSes don't support
// renaming a file that's already open (Windows).
if err := b.tempFile.Close(); err != nil {
return fmt.Errorf("unable to close file: %v", err)
}
// Finally, we'll attempt to atomically rename the temporary file to // Finally, we'll attempt to atomically rename the temporary file to
// the main back up file. If this succeeds, then we'll only have a // the main back up file. If this succeeds, then we'll only have a
// single file on disk once this method exits. // single file on disk once this method exits.