routing: use FailureReasonError for internal path finding errors

This commit is contained in:
Joost Jager 2019-11-21 12:08:09 +01:00
parent b5f1bde604
commit c15b0316a2
No known key found for this signature in database
GPG Key ID: A61B9D4C393C59C7

@ -186,6 +186,19 @@ func (p *paymentLifecycle) resumePayment() ([32]byte, *route.Route, error) {
} }
// errorToPaymentFailure takes a path finding error and converts it into a
// payment-level failure.
func errorToPaymentFailure(err error) channeldb.FailureReason {
switch err {
case errNoTlvPayload, errNoPathFound, errMaxHopsExceeded,
errPrebuiltRouteTried:
return channeldb.FailureReasonNoRoute
}
return channeldb.FailureReasonError
}
// createNewPaymentAttempt creates and stores a new payment attempt to the // createNewPaymentAttempt creates and stores a new payment attempt to the
// database. // database.
func (p *paymentLifecycle) createNewPaymentAttempt() (lnwire.ShortChannelID, func (p *paymentLifecycle) createNewPaymentAttempt() (lnwire.ShortChannelID,
@ -230,11 +243,14 @@ func (p *paymentLifecycle) createNewPaymentAttempt() (lnwire.ShortChannelID,
log.Warnf("Failed to find route for payment %x: %v", log.Warnf("Failed to find route for payment %x: %v",
p.payment.PaymentHash, err) p.payment.PaymentHash, err)
// Convert error to payment-level failure.
failure := errorToPaymentFailure(err)
// If we're unable to successfully make a payment using // If we're unable to successfully make a payment using
// any of the routes we've found, then mark the payment // any of the routes we've found, then mark the payment
// as permanently failed. // as permanently failed.
saveErr := p.router.cfg.Control.Fail( saveErr := p.router.cfg.Control.Fail(
p.payment.PaymentHash, channeldb.FailureReasonNoRoute, p.payment.PaymentHash, failure,
) )
if saveErr != nil { if saveErr != nil {
return lnwire.ShortChannelID{}, nil, saveErr return lnwire.ShortChannelID{}, nil, saveErr