Merge pull request #4919 from joostjager/getnodeinfo-notfound

rpcserver: use NotFound http status code in GetNodeInfo
This commit is contained in:
Conner Fromknecht 2021-01-31 09:43:33 -08:00 committed by GitHub
commit bd1c5378bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -73,6 +73,8 @@ import (
"github.com/lightningnetwork/lnd/zpay32"
"github.com/tv42/zbase32"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"gopkg.in/macaroon-bakery.v2/bakery"
)
@ -5308,7 +5310,10 @@ func (r *rpcServer) GetNodeInfo(ctx context.Context,
// to this public key. If the node cannot be found, then an error will
// be returned.
node, err := graph.FetchLightningNode(nil, pubKey)
if err != nil {
switch {
case err == channeldb.ErrGraphNodeNotFound:
return nil, status.Error(codes.NotFound, err.Error())
case err != nil:
return nil, err
}