akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1471 from cfromknecht/lnwire-query-sids-corpus

Browse Source 
[lnwire]: align behavior of query sids corpus for zero-length slices
This commit is contained in:
Olaoluwa Osuntokun 2018-07-03 21:58:00 -05:00 committed by GitHub
commit bc04bfdde2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lnwire/lnwire_test.go
View File

@ -668,11 +668,9 @@ func TestLightningWireProtocol(t *testing.T) {
numChanIDs := rand.Int31n(5000) numChanIDs := rand.Int31n(5000)
req.ShortChanIDs = make([]ShortChannelID, numChanIDs)
for i := int32(0); i < numChanIDs; i++ { for i := int32(0); i < numChanIDs; i++ {
req.ShortChanIDs[i] = NewShortChanIDFromInt( req.ShortChanIDs = append(req.ShortChanIDs,
uint64(r.Int63()), NewShortChanIDFromInt(uint64(r.Int63())))
)
} }
v[0] = reflect.ValueOf(req) v[0] = reflect.ValueOf(req)

5
lnwire/query_short_chan_ids.go
View File

@ -146,10 +146,13 @@ func decodeShortChanIDs(r io.Reader) (ShortChanIDEncoding, []ShortChannelID, err
// compute the number of bytes encoded based on the size of the // compute the number of bytes encoded based on the size of the
// query body. // query body.
numShortChanIDs := len(queryBody) / 8 numShortChanIDs := len(queryBody) / 8
shortChanIDs := make([]ShortChannelID, numShortChanIDs) if numShortChanIDs == 0 {
return encodingType, nil, nil
}
// Finally, we'll read out the exact number of short channel // Finally, we'll read out the exact number of short channel
// ID's to conclude our parsing. // ID's to conclude our parsing.
shortChanIDs := make([]ShortChannelID, numShortChanIDs)
bodyReader := bytes.NewReader(queryBody) bodyReader := bytes.NewReader(queryBody)
for i := 0; i < numShortChanIDs; i++ { for i := 0; i < numShortChanIDs; i++ {
if err := readElements(bodyReader, &shortChanIDs[i]); err != nil { if err := readElements(bodyReader, &shortChanIDs[i]); err != nil {