akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #5543 from Roasbeef/release-notes-master-special-case

Browse Source 
scripts: account for master branch merges in release notes script
This commit is contained in:
Oliver Gugger 2021-07-21 09:45:11 +02:00 committed by GitHub
commit b16877236a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/release-notes/release-notes-0.14.0.md
View File

@ -4,8 +4,9 @@
[A new pre-submit check has been [A new pre-submit check has been
added](https://github.com/lightningnetwork/lnd/pull/5520) to ensure that all added](https://github.com/lightningnetwork/lnd/pull/5520) to ensure that all
PRs add an entry in the release notes folder that at leasts links to PR being PRs ([aside from merge
added. commits](https://github.com/lightningnetwork/lnd/pull/5543)) add an entry in
the release notes folder that at leasts links to PR being added.
# Code Health # Code Health

7
scripts/check-release-notes.sh
View File

@ -6,6 +6,13 @@ set -e
# format of the string stored in the variable is: refs/pull/:PRNUMBER/merge. # format of the string stored in the variable is: refs/pull/:PRNUMBER/merge.
PR_NUMBER=$(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }') PR_NUMBER=$(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }')
# If this is a PR being merged into the main repo, then the PR number will
# actually be "master" here, so we'll ignore this case, and assume that in
# order for it to be merged it had to pass the check in its base branch.
if [ $PR_NUMBER == "master" ]; then
exit 0
fi
# Ensure that the PR number at least shows up in the release notes folder under # Ensure that the PR number at least shows up in the release notes folder under
# one of the contained milestones. # one of the contained milestones.
if ! grep -r -q "lightningnetwork/lnd/pull/$PR_NUMBER" docs/release-notes; then if ! grep -r -q "lightningnetwork/lnd/pull/$PR_NUMBER" docs/release-notes; then