akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

invoices: fail HTLCs that target the wrong type of invoice

Browse Source
This commit is contained in:
Conner Fromknecht 2021-05-06 09:17:58 -07:00
parent dba055de2d
commit b0949054e5
No known key found for this signature in database
GPG Key ID: E7D737B67FA592C7
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
invoices/resolution_result.go
View File

@ -110,6 +110,10 @@ const (
// payment. // payment.
ResultMppInProgress ResultMppInProgress
// ResultHtlcInvoiceTypeMismatch is returned when an AMP HTLC targets a
// non-AMP invoice and vice versa.
ResultHtlcInvoiceTypeMismatch
// ResultAmpError is returned when we receive invalid AMP parameters. // ResultAmpError is returned when we receive invalid AMP parameters.
ResultAmpError ResultAmpError
@ -176,6 +180,9 @@ func (f FailResolutionResult) FailureString() string {
case ResultMppInProgress: case ResultMppInProgress:
return "mpp reception in progress" return "mpp reception in progress"
case ResultHtlcInvoiceTypeMismatch:
return "htlc invoice type mismatch"
case ResultAmpError: case ResultAmpError:
return "invalid amp parameters" return "invalid amp parameters"

15
invoices/update.go
View File

@ -125,6 +125,21 @@ func updateMpp(ctx *invoiceUpdateCtx,
inv *channeldb.Invoice) (*channeldb.InvoiceUpdateDesc, inv *channeldb.Invoice) (*channeldb.InvoiceUpdateDesc,
HtlcResolution, error) { HtlcResolution, error) {
// Reject HTLCs to AMP invoices if they are missing an AMP payload, and
// HTLCs to MPP invoices if they have an AMP payload.
switch {
case inv.Terms.Features.RequiresFeature(lnwire.AMPRequired) &&
ctx.amp == nil:
return nil, ctx.failRes(ResultHtlcInvoiceTypeMismatch), nil
case !inv.Terms.Features.RequiresFeature(lnwire.AMPRequired) &&
ctx.amp != nil:
return nil, ctx.failRes(ResultHtlcInvoiceTypeMismatch), nil
}
setID := ctx.setID() setID := ctx.setID()
// Start building the accept descriptor. // Start building the accept descriptor.