akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lnwallet: create channel close summary when commitment broadcast detected

Browse Source 
This commit modifies the closeObserver goroutine to ensure that a close
summary has been inserted into the database before signalling any
observers that a unilateral channel closure was detected. This fixes a
slight bug where a peer would force close a channel, but we wouldn’t
properly detect that and clean up the channel state if had a failed
cooperative channel closure.
This commit is contained in:
Olaoluwa Osuntokun 2017-01-14 18:01:18 -08:00
parent 1e8a80170f
commit ae72475612
No known key found for this signature in database
GPG Key ID: 9CC5B105D03521A2
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lnwallet/channel.go
View File

@ -697,6 +697,7 @@ func (lc *LightningChannel) closeObserver(channelCloseNtfn *chainntnfs.SpendEven
lc.RLock() lc.RLock()
if lc.status == channelClosed || lc.status == channelDispute || if lc.status == channelClosed || lc.status == channelDispute ||
lc.status == channelClosing { lc.status == channelClosing {
lc.RUnlock() lc.RUnlock()
return return
} }
@ -727,6 +728,17 @@ func (lc *LightningChannel) closeObserver(channelCloseNtfn *chainntnfs.SpendEven
case broadcastStateNum == currentStateNum: case broadcastStateNum == currentStateNum:
walletLog.Infof("Unilateral close of ChannelPoint(%v) "+ walletLog.Infof("Unilateral close of ChannelPoint(%v) "+
"detected", lc.channelState.ChanID) "detected", lc.channelState.ChanID)
// As we've deleted that the channel has been closed,
// immediately delete the state from disk, creating a close
// summary for future usage by related sub-systems.
if err := lc.DeleteState(); err != nil {
walletLog.Errorf("unable to delete channel state: %v",
err)
}
// Notify any subscribers that we've detected a unilateral
// commitment transaction broadcast.
close(lc.UnilateralCloseSignal) close(lc.UnilateralCloseSignal)
// If the state number broadcast is lower than the remote node's // If the state number broadcast is lower than the remote node's