akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4224 from guggero/psbt-warning

Browse Source 
lncli+docs: add safety warning about not publishing PSBT manually
This commit is contained in:
Olaoluwa Osuntokun 2020-04-28 19:40:15 -07:00 committed by GitHub
commit 948fe8cfdb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/lncli/cmd_open_channel.go
View File

@ -33,6 +33,10 @@ If you are using a wallet that can fund a PSBT directly (currently not possible
with bitcoind), you can use this PSBT that contains the same address and amount: with bitcoind), you can use this PSBT that contains the same address and amount:
%s %s
!!! WARNING !!!
DO NOT PUBLISH the finished transaction by yourself or with another tool.
lnd MUST publish it in the proper funding flow order OR THE FUNDS CAN BE LOST!
Paste the funded PSBT here to continue the funding flow. Paste the funded PSBT here to continue the funding flow.
Base64 encoded PSBT: ` Base64 encoded PSBT: `

19
docs/psbt.md
View File

@ -34,6 +34,15 @@ about the pending channel. If the remote node is an `lnd` node, we know it's
after 10 minutes. **So as long as the whole process takes less than 10 minutes, after 10 minutes. **So as long as the whole process takes less than 10 minutes,
everything should work fine.** everything should work fine.**
### Safety warning
**DO NOT PUBLISH** the finished transaction by yourself or with another tool.
lnd MUST publish it in the proper funding flow order **OR THE FUNDS CAN BE
LOST**!
This is very important to remember when using wallets like `Wasabi` for
instance, where the "publish" button is very easy to hit by accident.
### 1. Use the new `--psbt` flag in `lncli openchannel` ### 1. Use the new `--psbt` flag in `lncli openchannel`
The new `--psbt` flag in the `openchannel` command starts an interactive dialog The new `--psbt` flag in the `openchannel` command starts an interactive dialog
@ -201,7 +210,15 @@ $ bitcoin-cli walletprocesspsbt cHNidP8BAH0CAAAAAbxLLf9+AYfqfF69QAQuETnL6cas7GDi
``` ```
Interpreting the output, we now have a complete, final, and signed transaction Interpreting the output, we now have a complete, final, and signed transaction
inside the PSBT. Let's give it to `lncli` to continue: inside the PSBT.
**!!! WARNING !!!**
**DO NOT PUBLISH** the finished transaction by yourself or with another tool.
lnd MUST publish it in the proper funding flow order **OR THE FUNDS CAN BE
LOST**!
Let's give it to `lncli` to continue:
```bash ```bash
... ...