lnrpc/signrpc: add lnrpc.SubServerDriver for signrpc

In this commit, we create a lnrpc.SubServerDriver for signrpc. Note that
this file will only have its init() method executed if the proper build
flag is on. As a result, only if the build flag is set, will the RPC
server be registered, and visible at the packge lnrpc level for the root
server to manipulate.

lnrpc/signrpc/config_active.go

@@ -1,4 +1,4 @@
-// +build signerrpc
+// +build signrpc
 
 package signrpc
 

lnrpc/signrpc/config_default.go

@@ -1,10 +1,6 @@
-// +build !signerrpc
+// +build !signrpc
 
 package signrpc
 
-// Config is the primary configuration struct for the signer RPC server. It
-// contains all the items required for the signer rpc server to carry out its
-// duties. The fields with struct tags are meant to be parsed as normal
-// configuration options, while if able to be populated, the latter fields MUST
-// also be specified.
+// Config is empty for non-signrpc builds.
 type Config struct{}

lnrpc/signrpc/driver.go

@@ -34,10 +34,13 @@ func createNewSubServer(configRegistry lnrpc.SubServerConfigDispatcher) (
 			&Config{}, signServerConf)
 	}
 
+	// Before we try to make the new signer service instance, we'll perform
+	// some sanity checks on the arguments to ensure that they're useable.
+
+	switch {
 	// If the macaroon service is set (we should use macaroons), then
 	// ensure that we know where to look for them, or create them if not
 	// found.
-	switch {
 	case config.MacService != nil && config.NetworkDir == "":
 		return nil, nil, fmt.Errorf("NetworkDir must be set to create " +
 			"Signrpc")
@@ -52,7 +55,9 @@ func createNewSubServer(configRegistry lnrpc.SubServerConfigDispatcher) (
 func init() {
 	subServer := &lnrpc.SubServerDriver{
 		SubServerName: subServerName,
-		New: func(c lnrpc.SubServerConfigDispatcher) (lnrpc.SubServer, lnrpc.MacaroonPerms, error) {
+		New: func(c lnrpc.SubServerConfigDispatcher) (
+			lnrpc.SubServer, lnrpc.MacaroonPerms, error) {
+
 			return createNewSubServer(c)
 		},
 	}

lnrpc/sub_server.go

@@ -1,24 +1,24 @@
 package lnrpc
 
 import (
-	fmt "fmt"
+	"fmt"
 	"sync"
 
 	"google.golang.org/grpc"
 	"gopkg.in/macaroon-bakery.v2/bakery"
 )
 
-// MacaroonPerms is a map from the FullMethod of an invoked gRPC command.  to
-// the set of operations that the macaroon presented with the command MUST
+// MacaroonPerms is a map from the FullMethod of an invoked gRPC command. It
+// maps the set of operations that the macaroon presented with the command MUST
 // satisfy. With this map, all sub-servers are able to communicate to the
 // primary macaroon service what type of macaroon must be passed with each
 // method present on the service of the sub-server.
 type MacaroonPerms map[string][]bakery.Op
 
 // SubServer is a child server of the main lnrpc gRPC server. Sub-servers allow
-// lnd to expose discrete services that can be use with or independent of the
+// lnd to expose discrete services that can be used with or independent of the
 // main RPC server. The main rpcserver will create, start, stop, and manage
-// each ubs-server in a generalized manner.
+// each sub-server in a generalized manner.
 type SubServer interface {
 	// Start starts the sub-server and all goroutines it needs to operate.
 	Start() error