lnwallet: add select on quit when waiting for job from sigPool

In this commit we ensure that the channel is always able to exit by
adding a select statement with a quit case when we’re waiting on the
result of a job that was previously sent into the sigPool.

lnwallet/channel.go

@@ -2938,16 +2938,19 @@ func (lc *LightningChannel) SignNextCommitment() (*btcec.Signature, []*btcec.Sig
 	// gather each of the signatures in order.
 	htlcSigs := make([]*btcec.Signature, 0, len(sigBatch))
 	for _, htlcSigJob := range sigBatch {
-		jobResp := <-htlcSigJob.resp
+		select {
+		case jobResp := <-htlcSigJob.resp:
+			// If an error occurred, then we'll cancel any other
+			// active jobs.
+			if jobResp.err != nil {
+				close(cancelChan)
+				return nil, nil, err
+			}
 
-		// If an error occurred, then we'll cancel any other active
+			htlcSigs = append(htlcSigs, jobResp.sig)
-		// jobs.
+		case <-lc.quit:
-		if jobResp.err != nil {
+			return nil, nil, fmt.Errorf("channel shutting down")
-			close(cancelChan)
-			return nil, nil, err
 		}
-
-		htlcSigs = append(htlcSigs, jobResp.sig)
 	}
 
 	// As we're about to proposer a new commitment state for the remote
@@ -3432,9 +3435,14 @@ func (lc *LightningChannel) ReceiveNewCommitment(commitSig *btcec.Signature,
 	for i := 0; i < len(verifyJobs); i++ {
 		// In the case that a single signature is invalid, we'll exit
 		// early and cancel all the outstanding verification jobs.
-		if err := <-verifyResps; err != nil {
+		select {
-			close(cancelChan)
+		case err := <-verifyResps:
-			return fmt.Errorf("invalid htlc signature: %v", err)
+			if err != nil {
+				close(cancelChan)
+				return fmt.Errorf("invalid htlc signature: %v", err)
+			}
+		case <-lc.quit:
+			return fmt.Errorf("channel shutting down")
 		}
 	}