From 821de3e1079b42037c1a3ee33c0d975066b4ab62 Mon Sep 17 00:00:00 2001 From: Olaoluwa Osuntokun Date: Thu, 3 Jan 2019 17:54:49 -0800 Subject: [PATCH] test: remove FullSync call from breacharbiter_test.go In this commit, we remove an extra openChannel.FullSync() call from breacharbiter_test.go. Before this collective diff, calling SyncPending() then FullSync() didn't result in an error. However, a prior commit now makes this an error to ensure we don't attempt to override any existing channels. This is the only area in the codebase that we made this mistake which in this case, was benign. --- breacharbiter_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/breacharbiter_test.go b/breacharbiter_test.go index dcdb0f8d..986cfb2d 100644 --- a/breacharbiter_test.go +++ b/breacharbiter_test.go @@ -1580,9 +1580,6 @@ func createInitChannels(revocationWindow int) (*lnwallet.LightningChannel, *lnwa if err := channelAlice.State().SyncPending(addr, 101); err != nil { return nil, nil, nil, err } - if err := channelAlice.State().FullSync(); err != nil { - return nil, nil, nil, err - } addr = &net.TCPAddr{ IP: net.ParseIP("127.0.0.1"), @@ -1591,9 +1588,6 @@ func createInitChannels(revocationWindow int) (*lnwallet.LightningChannel, *lnwa if err := channelBob.State().SyncPending(addr, 101); err != nil { return nil, nil, nil, err } - if err := channelBob.State().FullSync(); err != nil { - return nil, nil, nil, err - } cleanUpFunc := func() { dbBob.Close()