funding+rpc: raise min channel size to 20k satoshis

In this commit, we raise the min channel size to 20k satoshis. This
will be evaluated before we check for dusty commitments. The goal of
this is to ensure ample room for fees at current, and future fee
levels.
This commit is contained in:
Olaoluwa Osuntokun 2018-03-18 16:58:39 -07:00
parent ce85632390
commit 8127685462
No known key found for this signature in database
GPG Key ID: 964EA263DD637C21
2 changed files with 17 additions and 10 deletions

@ -60,6 +60,10 @@ const (
// for the funding transaction to be confirmed before forgetting about // for the funding transaction to be confirmed before forgetting about
// the channel. 288 blocks is ~48 hrs // the channel. 288 blocks is ~48 hrs
maxWaitNumBlocksFundingConf = 288 maxWaitNumBlocksFundingConf = 288
// minChanFundingSize is the smallest channel that we'll allow to be
// created over the RPC interface.
minChanFundingSize = btcutil.Amount(20000)
) )
// reservationWithCtx encapsulates a pending channel reservation. This wrapper // reservationWithCtx encapsulates a pending channel reservation. This wrapper

@ -701,17 +701,12 @@ func (r *rpcServer) OpenChannel(in *lnrpc.OpenChannelRequest,
"channel size is: %v", maxFundingAmount) "channel size is: %v", maxFundingAmount)
} }
const minChannelSize = btcutil.Amount(6000) // Restrict the size of the channel we'll actually open. At a later
// level, we'll ensure that the output we create after accounting for
// Restrict the size of the channel we'll actually open. Atm, we // fees that a dust output isn't created.
// require the amount to be above 6k satoshis we currently hard-coded if localFundingAmt < minChanFundingSize {
// a 5k satoshi fee in several areas. As a result 6k sat is the min
// channel size that allows us to safely sit above the dust threshold
// after fees are applied
// TODO(roasbeef): remove after dynamic fees are in
if localFundingAmt < minChannelSize {
return fmt.Errorf("channel is too small, the minimum channel "+ return fmt.Errorf("channel is too small, the minimum channel "+
"size is: %v (6k sat)", minChannelSize) "size is: %v SAT", int64(minChanFundingSize))
} }
var ( var (
@ -864,6 +859,14 @@ func (r *rpcServer) OpenChannelSync(ctx context.Context,
"initial state must be below the local funding amount") "initial state must be below the local funding amount")
} }
// Restrict the size of the channel we'll actually open. At a later
// level, we'll ensure that the output we create after accounting for
// fees that a dust output isn't created.
if localFundingAmt < minChanFundingSize {
return nil, fmt.Errorf("channel is too small, the minimum channel "+
"size is: %v SAT", int64(minChanFundingSize))
}
// Based on the passed fee related parameters, we'll determine an // Based on the passed fee related parameters, we'll determine an
// appropriate fee rate for the funding transaction. // appropriate fee rate for the funding transaction.
feeRate, err := determineFeePerVSize( feeRate, err := determineFeePerVSize(