akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tlv: simplify byte slice comparison as recommenteded by static analysis

Browse Source
This commit is contained in:
Andras Banki-Horvath 2020-04-09 19:19:12 +02:00
parent da9d7dd363
commit 72ed30e3e5
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tlv/truncated_test.go
View File

@ -77,7 +77,7 @@ func TestTUint16(t *testing.T) {
t.Fatalf("unable to encode tuint16: %v", err) t.Fatalf("unable to encode tuint16: %v", err)
} }
if bytes.Compare(b.Bytes(), test.bytes) != 0 { if !bytes.Equal(b.Bytes(), test.bytes) {
t.Fatalf("encoding mismatch, "+ t.Fatalf("encoding mismatch, "+
"expected: %x, got: %x", "expected: %x, got: %x",
test.bytes, b.Bytes()) test.bytes, b.Bytes())
@ -201,7 +201,7 @@ func TestTUint32(t *testing.T) {
t.Fatalf("unable to encode tuint32: %v", err) t.Fatalf("unable to encode tuint32: %v", err)
} }
if bytes.Compare(b.Bytes(), test.bytes) != 0 { if !bytes.Equal(b.Bytes(), test.bytes) {
t.Fatalf("encoding mismatch, "+ t.Fatalf("encoding mismatch, "+
"expected: %x, got: %x", "expected: %x, got: %x",
test.bytes, b.Bytes()) test.bytes, b.Bytes())
@ -371,7 +371,7 @@ func TestTUint64(t *testing.T) {
t.Fatalf("unable to encode tuint64: %v", err) t.Fatalf("unable to encode tuint64: %v", err)
} }
if bytes.Compare(b.Bytes(), test.bytes) != 0 { if !bytes.Equal(b.Bytes(), test.bytes) {
t.Fatalf("encoding mismatch, "+ t.Fatalf("encoding mismatch, "+
"expected: %x, got: %x", "expected: %x, got: %x",
test.bytes, b.Bytes()) test.bytes, b.Bytes())

2
tlv/varint_test.go
View File

@ -80,7 +80,7 @@ func testWriteVarInt(t *testing.T, test varIntTest) {
test.Value, err) test.Value, err)
} }
if bytes.Compare(w.Bytes(), test.Bytes) != 0 { if !bytes.Equal(w.Bytes(), test.Bytes) {
t.Fatalf("expected bytes: %v, got %v", t.Fatalf("expected bytes: %v, got %v",
test.Bytes, w.Bytes()) test.Bytes, w.Bytes())
} }