akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

notes to self

Browse Source 
* CAS vs locks
* Daemon storage redundancy+error-detection
* Proper bucket indexing
This commit is contained in:
Olaoluwa Osuntokun 2015-12-15 16:18:43 -06:00
parent 41065a4538
commit 6bb5febe9e
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wallet/wallet.go
View File

@ -216,6 +216,9 @@ func NewLightningWallet(privWalletPass, pubWalletPass, hdSeed []byte, dataDir st
wallet: wallet, wallet: wallet,
lnNamespace: lnNamespace, lnNamespace: lnNamespace,
msgChan: make(chan interface{}, msgBufferSize), msgChan: make(chan interface{}, msgBufferSize),
// TODO(roasbeef): make this atomic.Uint32 instead? Which is
// faster, locks or CAS? I'm guessing CAS because assembly:
// * https://golang.org/src/sync/atomic/asm_amd64.s
nextFundingID: 0, nextFundingID: 0,
fundingLimbo: make(map[uint64]*ChannelReservation), fundingLimbo: make(map[uint64]*ChannelReservation),
quit: make(chan struct{}), quit: make(chan struct{}),
@ -632,6 +635,7 @@ func (l *LightningWallet) handleFundingCounterPartySigs(msg *addCounterPartySigs
writeErr := l.lnNamespace.Update(func(tx walletdb.Tx) error { writeErr := l.lnNamespace.Update(func(tx walletdb.Tx) error {
// Get the bucket dedicated to storing the meta-data for open // Get the bucket dedicated to storing the meta-data for open
// channels. // channels.
// TODO(roasbeef): CHECKSUMS, REDUNDANCY, etc etc.
rootBucket := tx.RootBucket() rootBucket := tx.RootBucket()
openChanBucket, err := rootBucket.CreateBucketIfNotExists(openChannelBucket) openChanBucket, err := rootBucket.CreateBucketIfNotExists(openChannelBucket)
if err != nil { if err != nil {
@ -640,7 +644,7 @@ func (l *LightningWallet) handleFundingCounterPartySigs(msg *addCounterPartySigs
// Create a new sub-bucket within the open channel bucket // Create a new sub-bucket within the open channel bucket
// specifically for this channel. // specifically for this channel.
// TODO(roasbeef): should def be indexed by LNID // TODO(roasbeef): should def be indexed by LNID, cuz mal etc.
chanBucket, err := openChanBucket.CreateBucketIfNotExists(txID.Bytes()) chanBucket, err := openChanBucket.CreateBucketIfNotExists(txID.Bytes())
if err != nil { if err != nil {
return err return err