akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

discovery: set source of node announcement broadcast to belonging node

Browse Source 
We do this to ensure the node announcement propagates to our channel
counterparty. At times, the node announcement does not propagate to them
when opening our first channel due to a race condition between
IsPublicNode and processing announcement signatures. This isn't
necessary for channel updates and announcement signatures as we send
those to our channel counterparty directly through the reliable sender.
This commit is contained in:
Wilmer Paulino 2019-06-18 17:32:56 -07:00
parent d6d87e12fe
commit 67132d4ee3
No known key found for this signature in database
GPG Key ID: 6DF57B9F9514972F
1 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
discovery/gossiper.go
View File

@ -2382,28 +2382,38 @@ func (d *AuthenticatedGossiper) processNetworkAnnouncement(
} }
// We'll also send along the node announcements for each channel // We'll also send along the node announcements for each channel
// participant if we know of them. // participant if we know of them. To ensure our node
// announcement propagates to our channel counterparty, we'll
// set the source for each announcement to the node it belongs
// to, otherwise we won't send it since the source gets skipped.
// This isn't necessary for channel updates and announcement
// signatures since we send those directly to our channel
// counterparty through the gossiper's reliable sender.
node1Ann, err := d.fetchNodeAnn(chanInfo.NodeKey1Bytes) node1Ann, err := d.fetchNodeAnn(chanInfo.NodeKey1Bytes)
if err != nil { if err != nil {
log.Debugf("Unable to fetch node announcement for "+ log.Debugf("Unable to fetch node announcement for "+
"%x: %v", chanInfo.NodeKey1Bytes, err) "%x: %v", chanInfo.NodeKey1Bytes, err)
} else { } else {
announcements = append(announcements, networkMsg{ if nodeKey1, err := chanInfo.NodeKey1(); err == nil {
peer: nMsg.peer, announcements = append(announcements, networkMsg{
source: nMsg.source, peer: nMsg.peer,
msg: node1Ann, source: nodeKey1,
}) msg: node1Ann,
})
}
} }
node2Ann, err := d.fetchNodeAnn(chanInfo.NodeKey2Bytes) node2Ann, err := d.fetchNodeAnn(chanInfo.NodeKey2Bytes)
if err != nil { if err != nil {
log.Debugf("Unable to fetch node announcement for "+ log.Debugf("Unable to fetch node announcement for "+
"%x: %v", chanInfo.NodeKey2Bytes, err) "%x: %v", chanInfo.NodeKey2Bytes, err)
} else { } else {
announcements = append(announcements, networkMsg{ if nodeKey2, err := chanInfo.NodeKey2(); err == nil {
peer: nMsg.peer, announcements = append(announcements, networkMsg{
source: nMsg.source, peer: nMsg.peer,
msg: node2Ann, source: nodeKey2,
}) msg: node2Ann,
})
}
} }
nMsg.err <- nil nMsg.err <- nil