akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lnwallet: fix race condition when forwarding by creating new pubkey

Browse Source 
This commit fixes a race condition that would at times occur in the
htlcswitch.TestChannelLinkBidirectionalOneHopPayments test case. A race
condition would occur in the goroutine running ReceiveNewCommitment
compared with the grouting that would obtain the snapshot in order to
make a forwarding decision.

We fix this by creating a new public key for each new commitment
transaction such that we complete avoid the read/write race condition.
This commit is contained in:
Olaoluwa Osuntokun 2017-06-19 17:43:45 +02:00
parent 9dd5af4990
commit 5dd7b157a0
No known key found for this signature in database
GPG Key ID: 9CC5B105D03521A2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lnwallet/channel.go
View File

@ -1838,11 +1838,15 @@ func (lc *LightningChannel) ReceiveNewCommitment(rawSig []byte) error {
// Ensure that the newly constructed commitment state has a valid
// signature.
theirMultiSigKey.Curve = btcec.S256()
verifyKey := btcec.PublicKey{
X: theirMultiSigKey.X,
Y: theirMultiSigKey.Y,
Curve: btcec.S256(),
}
sig, err := btcec.ParseSignature(rawSig, btcec.S256())
if err != nil {
return err
} else if !sig.Verify(sigHash, theirMultiSigKey) {
} else if !sig.Verify(sigHash, &verifyKey) {
return fmt.Errorf("invalid commitment signature")
}