From 85b53c357f4808ffa91991ca560eb2127d3a4a3c Mon Sep 17 00:00:00 2001 From: "Johan T. Halseth" Date: Thu, 13 Aug 2020 14:36:41 +0200 Subject: [PATCH] htlcswitch: use kvdb.View for loading fwdpkgs Not necessary to open a write tx. --- channeldb/forwarding_package.go | 4 ++-- htlcswitch/switch.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/channeldb/forwarding_package.go b/channeldb/forwarding_package.go index 073ff405..dced6e95 100644 --- a/channeldb/forwarding_package.go +++ b/channeldb/forwarding_package.go @@ -326,7 +326,7 @@ type SettleFailAcker interface { type GlobalFwdPkgReader interface { // LoadChannelFwdPkgs loads all known forwarding packages for the given // channel. - LoadChannelFwdPkgs(tx kvdb.RwTx, + LoadChannelFwdPkgs(tx kvdb.RTx, source lnwire.ShortChannelID) ([]*FwdPkg, error) } @@ -364,7 +364,7 @@ func (*SwitchPackager) AckSettleFails(tx kvdb.RwTx, } // LoadChannelFwdPkgs loads all forwarding packages for a particular channel. -func (*SwitchPackager) LoadChannelFwdPkgs(tx kvdb.RwTx, +func (*SwitchPackager) LoadChannelFwdPkgs(tx kvdb.RTx, source lnwire.ShortChannelID) ([]*FwdPkg, error) { return loadChannelFwdPkgs(tx, source) diff --git a/htlcswitch/switch.go b/htlcswitch/switch.go index 0eb7ffe8..28a0bb04 100644 --- a/htlcswitch/switch.go +++ b/htlcswitch/switch.go @@ -1811,7 +1811,7 @@ func (s *Switch) reforwardResponses() error { func (s *Switch) loadChannelFwdPkgs(source lnwire.ShortChannelID) ([]*channeldb.FwdPkg, error) { var fwdPkgs []*channeldb.FwdPkg - if err := kvdb.Update(s.cfg.DB, func(tx kvdb.RwTx) error { + if err := kvdb.View(s.cfg.DB, func(tx kvdb.RTx) error { var err error fwdPkgs, err = s.cfg.SwitchPackager.LoadChannelFwdPkgs( tx, source,