akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

peer: avoid possible GC leak by setting popped queue element to nil

Browse Source
This commit is contained in:
Olaoluwa Osuntokun 2017-09-24 20:08:26 -07:00
parent 457aebd16f
commit 37d03d1e56
No known key found for this signature in database
GPG Key ID: 964EA263DD637C21
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
peer.go
View File

@ -537,6 +537,7 @@ func (c *chanMsgStream) msgConsumer() {
// slice's reference down one in order to remove the message // slice's reference down one in order to remove the message
// from the queue. // from the queue.
msg := c.msgs[0] msg := c.msgs[0]
c.msgs[0] = nil // Set to nil to prevent GC leak.
c.msgs = c.msgs[1:] c.msgs = c.msgs[1:]
// We'll send a message to the funding manager and wait iff an // We'll send a message to the funding manager and wait iff an
@ -859,6 +860,9 @@ func (p *peer) queueHandler() {
// If there weren't any messages to send, or the writehandler // If there weren't any messages to send, or the writehandler
// is still blocked, then we'll accept a new message into the // is still blocked, then we'll accept a new message into the
// queue from outside sub-systems. // queue from outside sub-systems.
//
// TODO(roasbeef): need send clause here as well to account for
// writeHandler blocking?
select { select {
case <-p.quit: case <-p.quit:
return return