akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

server: fix panic when error occures on peer intialization (#163)

Browse Source 
If an error occurs during, peer initialization then 'p' is nil. This 
may cause a panic while accessing the peer's member 
variables.

To avoid such panics, we now omit the call to `p.Disconnect` 
and also directly access the `connmgr.ConReq` variable if it's 
non-nil.
This commit is contained in:
andrew.shvv 2017-03-16 22:37:36 +03:00 committed by Olaoluwa Osuntokun
parent d0509955a7
commit 35813ad939
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server.go
View File

@ -449,10 +449,9 @@ func (s *server) peerConnected(conn net.Conn, connReq *connmgr.ConnReq, inbound
p, err := newPeer(conn, connReq, s, peerAddr, inbound) p, err := newPeer(conn, connReq, s, peerAddr, inbound)
if err != nil { if err != nil {
srvrLog.Errorf("unable to create peer %v", err) srvrLog.Errorf("unable to create peer %v", err)
if p.connReq != nil { if connReq != nil {
s.connMgr.Remove(p.connReq.ID()) s.connMgr.Remove(connReq.ID())
} }
p.Disconnect()
return return
} }