itest: use require inside net.EnsureConnected/net.ConnectNodes

lntest/harness.go

@@ -172,9 +172,7 @@ func (n *NetworkHarness) SetUp(t *testing.T,
 	// both nodes are fully started since the Connect RPC is guarded behind
 	// the server.Started() flag that waits for all subsystems to be ready.
 	ctxb := context.Background()
-	if err := n.ConnectNodes(ctxb, n.Alice, n.Bob); err != nil {
+	n.ConnectNodes(ctxb, t, n.Alice, n.Bob)
-		return err
-	}
 
 	// Load up the wallets of the seeder nodes with 10 outputs of 1 BTC
 	// each.
@@ -544,7 +542,9 @@ tryconnect:
 // behave the same as ConnectNodes. If a pending connection request has already
 // been made, the method will block until the two nodes appear in each other's
 // peers list, or until the 15s timeout expires.
-func (n *NetworkHarness) EnsureConnected(ctx context.Context, a, b *HarnessNode) error {
+func (n *NetworkHarness) EnsureConnected(ctx context.Context,
+	t *testing.T, a, b *HarnessNode) {
+
 	// errConnectionRequested is used to signal that a connection was
 	// requested successfully, which is distinct from already being
 	// connected to the peer.
@@ -606,15 +606,21 @@ func (n *NetworkHarness) EnsureConnected(ctx context.Context, a, b *HarnessNode)
 	// If both reported already being connected to each other, we can exit
 	// early.
 	case aErr == nil && bErr == nil:
-		return nil
 
 	// Return any critical errors returned by either alice.
 	case aErr != nil && aErr != errConnectionRequested:
-		return aErr
+		t.Fatalf(
+			"ensure connection between %s and %s failed "+
+				"with error from %s: %v",
+			a.Cfg.Name, b.Cfg.Name, a.Cfg.Name, aErr,
+		)
 
 	// Return any critical errors returned by either bob.
 	case bErr != nil && bErr != errConnectionRequested:
-		return bErr
+		t.Fatalf("ensure connection between %s and %s failed "+
+			"with error from %s: %v",
+			a.Cfg.Name, b.Cfg.Name, b.Cfg.Name, bErr,
+		)
 
 	// Otherwise one or both requested a connection, so we wait for the
 	// peers lists to reflect the connection.
@@ -644,11 +650,12 @@ func (n *NetworkHarness) EnsureConnected(ctx context.Context, a, b *HarnessNode)
 	err := wait.Predicate(func() bool {
 		return findSelfInPeerList(a, b) && findSelfInPeerList(b, a)
 	}, DefaultTimeout)
-	if err != nil {
-		return fmt.Errorf("peers not connected within 15 seconds")
-	}
 
-	return nil
+	require.NoErrorf(
+		t, err, "unable to connect %s to %s, "+
+			"got error: peers not connected within %v seconds",
+		a.Cfg.Name, b.Cfg.Name, DefaultTimeout,
+	)
 }
 
 // ConnectNodes establishes an encrypted+authenticated p2p connection from node
@@ -657,11 +664,14 @@ func (n *NetworkHarness) EnsureConnected(ctx context.Context, a, b *HarnessNode)
 //
 // NOTE: This function may block for up to 15-seconds as it will not return
 // until the new connection is detected as being known to both nodes.
-func (n *NetworkHarness) ConnectNodes(ctx context.Context, a, b *HarnessNode) error {
+func (n *NetworkHarness) ConnectNodes(ctx context.Context, t *testing.T,
+	a, b *HarnessNode) {
+
 	bobInfo, err := b.GetInfo(ctx, &lnrpc.GetInfoRequest{})
-	if err != nil {
+	require.NoErrorf(
-		return err
+		t, err, "unable to connect %s to %s, got error: %v",
-	}
+		a.Cfg.Name, b.Cfg.Name, err,
+	)
 
 	req := &lnrpc.ConnectPeerRequest{
 		Addr: &lnrpc.LightningAddress{
@@ -670,9 +680,11 @@ func (n *NetworkHarness) ConnectNodes(ctx context.Context, a, b *HarnessNode) er
 		},
 	}
 
-	if err := n.connect(ctx, req, a); err != nil {
+	err = n.connect(ctx, req, a)
-		return err
+	require.NoErrorf(
-	}
+		t, err, "unable to connect %s to %s, got error: %v",
+		a.Cfg.Name, b.Cfg.Name, err,
+	)
 
 	err = wait.Predicate(func() bool {
 		// If node B is seen in the ListPeers response from node A,
@@ -691,11 +703,12 @@ func (n *NetworkHarness) ConnectNodes(ctx context.Context, a, b *HarnessNode) er
 
 		return false
 	}, DefaultTimeout)
-	if err != nil {
-		return fmt.Errorf("peers not connected within 15 seconds")
-	}
 
-	return nil
+	require.NoErrorf(
+		t, err, "unable to connect %s to %s, "+
+			"got error: peers not connected within %v seconds",
+		a.Cfg.Name, b.Cfg.Name, DefaultTimeout,
+	)
 }
 
 // DisconnectNodes disconnects node a from node b by sending RPC message

lntest/itest/lnd_channel_backup_test.go

@@ -477,9 +477,7 @@ func testChannelBackupUpdates(net *lntest.NetworkHarness, t *harnessTest) {
 	// With Carol up, we'll now connect her to Alice, and open a channel
 	// between them.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Alice)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 
 	// Next, we'll open two channels between Alice and Carol back to back.
 	var chanPoints []*lnrpc.ChannelPoint
@@ -608,9 +606,7 @@ func testExportChannelBackup(net *lntest.NetworkHarness, t *harnessTest) {
 	// With Carol up, we'll now connect her to Alice, and open a channel
 	// between them.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Alice)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 
 	// Next, we'll open two channels between Alice and Carol back to back.
 	var chanPoints []*lnrpc.ChannelPoint
@@ -863,9 +859,7 @@ func testChanRestoreScenario(t *harnessTest, net *lntest.NetworkHarness,
 
 	// Next, we'll connect Dave to Carol, and open a new channel to her
 	// with a portion pushed.
-	if err := net.ConnectNodes(ctxt, dave, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, carol)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 
 	// We will either open a confirmed or unconfirmed channel, depending on
 	// the requirements of the test case.
@@ -1086,10 +1080,7 @@ func testChanRestoreScenario(t *harnessTest, net *lntest.NetworkHarness,
 	// Now that we have our new node up, we expect that it'll re-connect to
 	// Carol automatically based on the restored backup.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, carol)
+	net.EnsureConnected(ctxt, t.t, dave, carol)
-	if err != nil {
-		t.Fatalf("node didn't connect after recovery: %v", err)
-	}
 
 	// TODO(roasbeef): move dave restarts?
 

lntest/itest/lnd_etcd_failover_test.go

@@ -101,9 +101,7 @@ func testEtcdFailoverCase(net *lntest.NetworkHarness, ht *harnessTest,
 	info1, err := carol1.GetInfo(ctxt, &lnrpc.GetInfoRequest{})
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol1, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, ht.t, carol1, net.Alice)
-		ht.Fatalf("unable to connect Carol to Alice: %v", err)
-	}
 
 	// Open a channel with 100k satoshis between Carol and Alice with Alice
 	// being the sole funder of the channel.

lntest/itest/lnd_forward_interceptor_test.go

@@ -248,8 +248,7 @@ func newInterceptorTestContext(t *harnessTest,
 	for i := 0; i < len(nodes); i++ {
 		for j := i + 1; j < len(nodes); j++ {
 			ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-			err := net.EnsureConnected(ctxt, nodes[i], nodes[j])
+			net.EnsureConnected(ctxt, t.t, nodes[i], nodes[j])
-			require.NoError(t.t, err, "unable to connect nodes")
 		}
 	}
 

lntest/itest/lnd_funding_test.go

@@ -52,8 +52,7 @@ func testBasicChannelFunding(net *lntest.NetworkHarness, t *harnessTest) {
 		// Before we start the test, we'll ensure both sides are
 		// connected to the funding flow can properly be executed.
 		ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-		err := net.EnsureConnected(ctxt, carol, dave)
+		net.EnsureConnected(ctxt, t.t, carol, dave)
-		require.NoError(t.t, err, "unable to connect peers")
 
 		carolChan, daveChan, closeChan, err := basicChannelFundingTest(
 			t, net, carol, dave, nil,
@@ -290,8 +289,7 @@ func testUnconfirmedChannelFunding(net *lntest.NetworkHarness, t *harnessTest) {
 	// as she doesn't have any other funds since it's a new node.
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.ConnectNodes(ctxt, carol, net.Alice)
+	net.ConnectNodes(ctxt, t.t, carol, net.Alice)
-	require.NoError(t.t, err, "unable to connect carol to alice")
 
 	chanOpenUpdate := openChannelStream(
 		ctxt, t, net, carol, net.Alice,
@@ -394,8 +392,7 @@ func testExternalFundingChanPoint(net *lntest.NetworkHarness, t *harnessTest) {
 	// Before we start the test, we'll ensure both sides are connected to
 	// the funding flow can properly be executed.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err := net.EnsureConnected(ctxt, carol, dave)
+	net.EnsureConnected(ctxt, t.t, carol, dave)
-	require.NoError(t.t, err)
 
 	// At this point, we're ready to simulate our external channel funding
 	// flow. To start with, we'll create a pending channel with a shim for

lntest/itest/lnd_hold_persistence_test.go

@@ -35,9 +35,7 @@ func testHoldInvoicePersistence(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Connect Alice to Carol.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxb, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxb, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	// Open a channel between Alice and Carol which is private so that we
 	// cover the addition of hop hints for hold invoices.

lntest/itest/lnd_max_channel_size_test.go

@@ -35,13 +35,10 @@ func testMaxChannelSize(net *lntest.NetworkHarness, t *harnessTest) {
 	// Next we'll connect both nodes, then attempt to make a wumbo channel
 	// funding request, which should fail as it exceeds the default wumbo
 	// soft limit of 10 BTC.
-	err := net.EnsureConnected(ctxb, wumboNode, wumboNode2)
+	net.EnsureConnected(ctxb, t.t, wumboNode, wumboNode2)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 
 	chanAmt := funding.MaxBtcFundingAmountWumbo + 1
-	_, err = net.OpenChannel(
+	_, err := net.OpenChannel(
 		ctxb, wumboNode, wumboNode2, lntest.OpenChannelParams{
 			Amt: chanAmt,
 		},
@@ -61,10 +58,7 @@ func testMaxChannelSize(net *lntest.NetworkHarness, t *harnessTest) {
 	miniNode := net.NewNode(t.t, "mini", nil)
 	defer shutdownAndAssert(net, t, miniNode)
 
-	err = net.EnsureConnected(ctxb, wumboNode, miniNode)
+	net.EnsureConnected(ctxb, t.t, wumboNode, miniNode)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 
 	_, err = net.OpenChannel(
 		ctxb, wumboNode, miniNode, lntest.OpenChannelParams{
@@ -95,10 +89,7 @@ func testMaxChannelSize(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, wumboNode3)
 
 	// Creating a wumbo channel between these two nodes should succeed.
-	err = net.EnsureConnected(ctxb, wumboNode, wumboNode3)
+	net.EnsureConnected(ctxb, t.t, wumboNode, wumboNode3)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 	chanPoint := openChannelAndAssert(
 		ctxb, t, net, wumboNode, wumboNode3,
 		lntest.OpenChannelParams{

lntest/itest/lnd_mpp_test.go

@@ -271,9 +271,7 @@ func newMppTestContext(t *harnessTest,
 	for i := 0; i < len(nodes); i++ {
 		for j := i + 1; j < len(nodes); j++ {
 			ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-			if err := net.EnsureConnected(ctxt, nodes[i], nodes[j]); err != nil {
+			net.EnsureConnected(ctxt, t.t, nodes[i], nodes[j])
-				t.Fatalf("unable to connect nodes: %v", err)
-			}
 		}
 	}
 

lntest/itest/lnd_multi-hop-error-propagation_test.go

@@ -95,9 +95,7 @@ func testHtlcErrorPropagation(net *lntest.NetworkHarness, t *harnessTest) {
 	// The channel created will be of lower capacity that the one created
 	// above.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Bob, carol)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	const bobChanAmt = funding.MaxBtcFundingAmount
 	chanPointBob := openChannelAndAssert(

lntest/itest/lnd_multi-hop-payments_test.go

@@ -51,9 +51,7 @@ func testMultiHopPayments(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -80,9 +78,7 @@ func testMultiHopPayments(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 

lntest/itest/lnd_multi-hop_test.go

@@ -89,9 +89,7 @@ func testMultiHopHtlcClaims(net *lntest.NetworkHarness, t *harnessTest) {
 
 			ctxb := context.Background()
 			ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-			if err := net.ConnectNodes(ctxt, alice, bob); err != nil {
+			net.ConnectNodes(ctxt, t, alice, bob)
-				t.Fatalf("unable to connect alice to bob: %v", err)
-			}
 
 			for _, subTest := range subTests {
 				subTest := subTest
@@ -211,10 +209,7 @@ func createThreeHopNetwork(t *harnessTest, net *lntest.NetworkHarness,
 	ctxb := context.Background()
 
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	err := net.EnsureConnected(ctxt, alice, bob)
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 
 	// Make sure there are enough utxos for anchoring.
 	for i := 0; i < 2; i++ {
@@ -237,7 +232,7 @@ func createThreeHopNetwork(t *harnessTest, net *lntest.NetworkHarness,
 	)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = alice.WaitForNetworkChannelOpen(ctxt, aliceChanPoint)
+	err := alice.WaitForNetworkChannelOpen(ctxt, aliceChanPoint)
 	if err != nil {
 		t.Fatalf("alice didn't report channel: %v", err)
 	}
@@ -258,9 +253,7 @@ func createThreeHopNetwork(t *harnessTest, net *lntest.NetworkHarness,
 	carol := net.NewNode(t.t, "Carol", carolFlags)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, bob, carol)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 
 	// Make sure Carol has enough utxos for anchoring. Because the anchor by
 	// itself often doesn't meet the dust limit, a utxo from the wallet

lntest/itest/lnd_onchain_test.go

@@ -177,8 +177,7 @@ func testAnchorReservedValue(net *lntest.NetworkHarness, t *harnessTest) {
 
 	ctxb := context.Background()
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	err := net.ConnectNodes(ctxt, alice, bob)
+	net.ConnectNodes(ctxt, t.t, alice, bob)
-	require.NoError(t.t, err)
 
 	// Send just enough coins for Alice to open a channel without a change output.
 	const (
@@ -193,7 +192,7 @@ func testAnchorReservedValue(net *lntest.NetworkHarness, t *harnessTest) {
 	resErr := lnwallet.ErrReservedValueInvalidated.Error()
 
 	ctxt, _ = context.WithTimeout(context.Background(), defaultTimeout)
-	_, err = net.OpenChannel(
+	_, err := net.OpenChannel(
 		ctxt, alice, bob,
 		lntest.OpenChannelParams{
 			Amt: chanAmt,

lntest/itest/lnd_psbt_test.go

@@ -37,16 +37,14 @@ func testPsbtChanFunding(net *lntest.NetworkHarness, t *harnessTest) {
 	// the funding flow can be properly executed.
 	ctxt, cancel := context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
-	err := net.EnsureConnected(ctxt, carol, dave)
+	net.EnsureConnected(ctxt, t.t, carol, dave)
-	require.NoError(t.t, err)
+	net.EnsureConnected(ctxt, t.t, carol, net.Alice)
-	err = net.EnsureConnected(ctxt, carol, net.Alice)
-	require.NoError(t.t, err)
 
 	// At this point, we can begin our PSBT channel funding workflow. We'll
 	// start by generating a pending channel ID externally that will be used
 	// to track this new funding type.
 	var pendingChanID [32]byte
-	_, err = rand.Read(pendingChanID[:])
+	_, err := rand.Read(pendingChanID[:])
 	require.NoError(t.t, err)
 
 	// We'll also test batch funding of two channels so we need another ID.

lntest/itest/lnd_rest_api_test.go

@@ -499,8 +499,7 @@ func wsTestCaseBiDirectionalSubscription(ht *harnessTest,
 
 	// Before we start opening channels, make sure the two nodes are
 	// connected.
-	err = net.EnsureConnected(context.Background(), net.Alice, net.Bob)
+	net.EnsureConnected(context.Background(), ht.t, net.Alice, net.Bob)
-	require.NoError(ht.t, err)
 
 	// Open 3 channels to make sure multiple requests and responses can be
 	// sent over the web socket.

lntest/itest/lnd_routing_test.go

@@ -104,9 +104,7 @@ func testSingleHopSendToRouteCase(net *lntest.NetworkHarness, t *harnessTest,
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -473,9 +471,7 @@ func testMultiHopSendToRoute(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Bob)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, net.Bob)
 
@@ -659,9 +655,7 @@ func testSendToRouteErrorPropagation(net *lntest.NetworkHarness, t *harnessTest)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, charlie)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, charlie); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, charlie)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointCarol := openChannelAndAssert(
@@ -779,9 +773,7 @@ func testPrivateChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -808,9 +800,7 @@ func testPrivateChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -859,9 +849,7 @@ func testPrivateChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	// Now create a _private_ channel directly between Carol and
 	// Alice of 100k.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Alice)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanOpenUpdate := openChannelStream(
 		ctxt, t, net, carol, net.Alice,
@@ -1112,10 +1100,7 @@ func testUpdateChannelPolicyForPrivateChannel(net *lntest.NetworkHarness,
 
 	// Connect Carol to Bob.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	require.NoError(t.t,
+	net.ConnectNodes(ctxt, t.t, carol, net.Bob)
-		net.ConnectNodes(ctxt, carol, net.Bob),
-		"unable to connect carol to bob",
-	)
 
 	// Open a channel with 100k satoshis between Bob and Carol.
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
@@ -1250,9 +1235,7 @@ func testInvoiceRoutingHints(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointCarol := openChannelAndAssert(
 		ctxt, t, net, net.Alice, carol,
@@ -1268,9 +1251,7 @@ func testInvoiceRoutingHints(net *lntest.NetworkHarness, t *harnessTest) {
 	// advertised, otherwise we'd end up leaking information about nodes
 	// that wish to stay unadvertised.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Bob, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointBobCarol := openChannelAndAssert(
 		ctxt, t, net, net.Bob, carol,
@@ -1288,9 +1269,7 @@ func testInvoiceRoutingHints(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, dave)
-		t.Fatalf("unable to connect alice to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointDave := openChannelAndAssert(
 		ctxt, t, net, net.Alice, dave,
@@ -1306,9 +1285,7 @@ func testInvoiceRoutingHints(net *lntest.NetworkHarness, t *harnessTest) {
 	// inactive channels.
 	eve := net.NewNode(t.t, "Eve", nil)
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, eve); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, eve)
-		t.Fatalf("unable to connect alice to eve: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointEve := openChannelAndAssert(
 		ctxt, t, net, net.Alice, eve,
@@ -1485,9 +1462,7 @@ func testMultiHopOverPrivateChannels(net *lntest.NetworkHarness, t *harnessTest)
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Bob, carol)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointBob := openChannelAndAssert(
 		ctxt, t, net, net.Bob, carol,
@@ -1531,9 +1506,7 @@ func testMultiHopOverPrivateChannels(net *lntest.NetworkHarness, t *harnessTest)
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -1674,9 +1647,7 @@ func testQueryRoutes(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Bob)
-		t.Fatalf("unable to connect carol to bob: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, net.Bob)
 
@@ -1694,9 +1665,7 @@ func testQueryRoutes(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, carol)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -1973,9 +1942,7 @@ func testRouteFeeCutoff(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Alice)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -1993,9 +1960,7 @@ func testRouteFeeCutoff(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Bob)
-		t.Fatalf("unable to connect dave to bob: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointBobDave := openChannelAndAssert(
 		ctxt, t, net, net.Bob, dave,
@@ -2006,9 +1971,7 @@ func testRouteFeeCutoff(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Open a channel between Carol and Dave.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointCarolDave := openChannelAndAssert(
 		ctxt, t, net, carol, dave,

lntest/itest/lnd_test.go

@@ -1275,9 +1275,7 @@ func testPaymentFollowingChannelOpen(net *lntest.NetworkHarness, t *harnessTest)
 
 	// We ensure that Bob reconnects to Alice.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, net.Bob, net.Alice); err != nil {
+	net.EnsureConnected(ctxt, t.t, net.Bob, net.Alice)
-		t.Fatalf("peers unable to reconnect after restart: %v", err)
-	}
 
 	// We mine one block for the channel to be confirmed.
 	_ = mineBlocks(t, net, 6, 1)[0]
@@ -1659,9 +1657,7 @@ func testUpdateChannelPolicy(net *lntest.NetworkHarness, t *harnessTest) {
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
-	if err := net.ConnectNodes(ctxb, carol, net.Bob); err != nil {
+	net.ConnectNodes(ctxb, t.t, carol, net.Bob)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 
 	// Open the channel Carol->Bob with a custom min_htlc value set. Since
 	// Carol is opening the channel, she will require Bob to not forward
@@ -1938,9 +1934,7 @@ func testUpdateChannelPolicy(net *lntest.NetworkHarness, t *harnessTest) {
 	}
 
 	// We'll now open a channel from Alice directly to Carol.
-	if err := net.ConnectNodes(ctxb, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxb, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPoint3 := openChannelAndAssert(
 		ctxt, t, net, net.Alice, carol,
@@ -2392,9 +2386,7 @@ func testDisconnectingTargetPeer(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Start by connecting Alice and Bob with no channels.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to connect Alice's peer to Bob's: err %v", err)
-	}
 
 	// Check existing connection.
 	assertNumConnections(t, alice, bob, 1)
@@ -2456,9 +2448,7 @@ func testDisconnectingTargetPeer(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Reconnect the nodes so that the channel can become active.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to connect Alice's peer to Bob's: err %v", err)
-	}
 
 	// The channel should be listed in the peer information returned by both
 	// peers.
@@ -2489,9 +2479,7 @@ func testDisconnectingTargetPeer(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Reconnect both nodes before force closing the channel.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to connect Alice's peer to Bob's: err %v", err)
-	}
 
 	// Finally, immediately close the channel. This function will also block
 	// until the channel is closed and will additionally assert the relevant
@@ -2518,9 +2506,7 @@ func testDisconnectingTargetPeer(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Finally, re-connect both nodes.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to connect Alice's peer to Bob's: err %v", err)
-	}
 
 	// Check existing connection.
 	assertNumConnections(t, alice, net.Bob, 1)
@@ -2552,9 +2538,7 @@ func testChannelFundingPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	// Create a new channel that requires 5 confs before it's considered
 	// open, then broadcast the funding transaction
@@ -2609,9 +2593,7 @@ func testChannelFundingPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	// The following block ensures that after both nodes have restarted,
 	// they have reconnected before the execution of the next test.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, net.Alice, carol); err != nil {
+	net.EnsureConnected(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("peers unable to reconnect after restart: %v", err)
-	}
 
 	// Next, mine enough blocks s.t the channel will open with a single
 	// additional block mined.
@@ -2753,9 +2735,7 @@ func testChannelBalance(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Before beginning, make sure alice and bob are connected.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, net.Alice, net.Bob); err != nil {
+	net.EnsureConnected(ctxt, t.t, net.Alice, net.Bob)
-		t.Fatalf("unable to connect alice and bob: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPoint := openChannelAndAssert(
@@ -2850,9 +2830,7 @@ func testChannelUnsettledBalance(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Connect Alice to Carol.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxb, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxb, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	// Open a channel between Alice and Carol.
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
@@ -3196,9 +3174,7 @@ func channelForceClosureTest(net *lntest.NetworkHarness, t *harnessTest,
 	// We must let Alice have an open channel before she can send a node
 	// announcement, so we open a channel with Carol,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	// Before we start, obtain Carol's current wallet balance, we'll check
 	// to ensure that at the end of the force closure by Alice, Carol
@@ -4473,9 +4449,7 @@ func testSphinxReplayPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -4496,9 +4470,7 @@ func testSphinxReplayPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, fred)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, fred, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, fred, carol)
-		t.Fatalf("unable to connect fred to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, fred)
 
@@ -4698,9 +4670,7 @@ func testListChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, bob)
 
 	// Connect Alice to Bob.
-	if err := net.ConnectNodes(ctxb, alice, bob); err != nil {
+	net.ConnectNodes(ctxb, t.t, alice, bob)
-		t.Fatalf("unable to connect alice to bob: %v", err)
-	}
 
 	// Give Alice some coins so she can fund a channel.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
@@ -4843,9 +4813,7 @@ func testUpdateChanStatus(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, bob)
 
 	// Connect Alice to Bob.
-	if err := net.ConnectNodes(ctxb, alice, bob); err != nil {
+	net.ConnectNodes(ctxb, t.t, alice, bob)
-		t.Fatalf("unable to connect alice to bob: %v", err)
-	}
 
 	// Give Alice some coins so she can fund a channel.
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
@@ -4885,14 +4853,10 @@ func testUpdateChanStatus(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, bob, carol)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 
 	carolSub := subscribeGraphNotifications(ctxb, t, carol)
 	defer close(carolSub.quit)
@@ -5014,9 +4978,7 @@ func testUpdateChanStatus(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Reconnecting the nodes should propagate a "Disabled = false" update.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, alice, bob); err != nil {
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to reconnect Alice to Bob: %v", err)
-	}
 	expectedPolicy.Disabled = false
 	waitForChannelUpdate(
 		t, carolSub,
@@ -5060,9 +5022,7 @@ func testUpdateChanStatus(net *lntest.NetworkHarness, t *harnessTest) {
 	// Bob sends a "Disabled = false" update upon detecting the
 	// reconnect.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, alice, bob); err != nil {
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to reconnect Alice to Bob: %v", err)
-	}
 	expectedPolicy.Disabled = false
 	waitForChannelUpdate(
 		t, carolSub,
@@ -5095,9 +5055,7 @@ func testUpdateChanStatus(net *lntest.NetworkHarness, t *harnessTest) {
 	// BOTH Alice and Bob should set the channel state back to "enabled"
 	// on reconnect.
 	sendReq(alice, chanPoint, routerrpc.ChanStatusAction_AUTO)
-	if err := net.EnsureConnected(ctxt, alice, bob); err != nil {
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to reconnect Alice to Bob: %v", err)
-	}
 	expectedPolicy.Disabled = false
 	waitForChannelUpdate(
 		t, carolSub,
@@ -6000,9 +5958,7 @@ func testMaxPendingChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect carol to alice: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	carolBalance := btcutil.Amount(maxPendingChannels) * amount
@@ -6158,9 +6114,7 @@ func testFailingChannel(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Let Alice connect and open a channel to Carol,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPoint := openChannelAndAssert(
 		ctxt, t, net, net.Alice, carol,
@@ -6357,9 +6311,7 @@ func testGarbageCollectLinkNodes(net *lntest.NetworkHarness, t *harnessTest) {
 	carol := net.NewNode(t.t, "Carol", nil)
 	defer shutdownAndAssert(net, t, carol)
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice and carol: %v", err)
-	}
 
 	// Open a channel between Alice and Carol which will later be force
 	// closed.
@@ -6377,9 +6329,7 @@ func testGarbageCollectLinkNodes(net *lntest.NetworkHarness, t *harnessTest) {
 	dave := net.NewNode(t.t, "Dave", nil)
 	defer shutdownAndAssert(net, t, dave)
 
-	if err := net.ConnectNodes(ctxt, net.Alice, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, dave)
-		t.Fatalf("unable to connect alice to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	persistentChanPoint := openChannelAndAssert(
 		ctxt, t, net, net.Alice, dave,
@@ -6604,9 +6554,7 @@ func testRevokedCloseRetribution(net *lntest.NetworkHarness, t *harnessTest) {
 	// We must let Bob communicate with Carol before they are able to open
 	// channel, so we connect Bob and Carol,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, net.Bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, net.Bob)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 
 	// Before we make a channel, we'll load up Carol with some coins sent
 	// directly from the miner.
@@ -6872,9 +6820,7 @@ func testRevokedCloseRetributionZeroValueRemoteOutput(net *lntest.NetworkHarness
 	// We must let Dave have an open channel before she can send a node
 	// announcement, so we open a channel with Carol,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, carol)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 
 	// Before we make a channel, we'll load up Dave with some coins sent
 	// directly from the miner.
@@ -7115,9 +7061,7 @@ func testRevokedCloseRetributionRemoteHodl(net *lntest.NetworkHarness,
 	// We must let Dave communicate with Carol before they are able to open
 	// channel, so we connect Dave and Carol,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, carol)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 
 	// Before we make a channel, we'll load up Dave with some coins sent
 	// directly from the miner.
@@ -7621,9 +7565,7 @@ func testRevokedCloseRetributionAltruistWatchtowerCase(
 
 	// We must let Dave have an open channel before she can send a node
 	// announcement, so we open a channel with Carol,
-	if err := net.ConnectNodes(ctxb, dave, carol); err != nil {
+	net.ConnectNodes(ctxb, t.t, dave, carol)
-		t.Fatalf("unable to connect dave to carol: %v", err)
-	}
 
 	// Before we make a channel, we'll load up Dave with some coins sent
 	// directly from the miner.
@@ -7983,11 +7925,7 @@ func assertDLPExecuted(net *lntest.NetworkHarness, t *harnessTest,
 	// To make sure the nodes are initiating DLP now, we have to manually
 	// re-connect them.
 	ctxb := context.Background()
-	err := net.ConnectNodes(ctxb, carol, dave)
+	net.EnsureConnected(ctxb, t.t, carol, dave)
-	if err != nil && !strings.Contains(err.Error(), "already connected") {
-		t.Fatalf("unable to connect Carol to Dave to initiate DLP: %v",
-			err)
-	}
 
 	// Upon reconnection, the nodes should detect that Dave is out of sync.
 	// Carol should force close the channel using her latest commitment.
@@ -7995,7 +7933,7 @@ func assertDLPExecuted(net *lntest.NetworkHarness, t *harnessTest,
 	if anchors {
 		expectedTxes = 2
 	}
-	_, err = waitForNTxsInMempool(
+	_, err := waitForNTxsInMempool(
 		net.Miner.Client, expectedTxes, minerMempoolTimeout,
 	)
 	if err != nil {
@@ -8146,10 +8084,7 @@ func testDataLossProtection(net *lntest.NetworkHarness, t *harnessTest) {
 		// We must let the node communicate with Carol before they are
 		// able to open channel, so we connect them.
 		ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-		if err := net.EnsureConnected(ctxt, carol, node); err != nil {
+		net.EnsureConnected(ctxt, t.t, carol, node)
-			t.Fatalf("unable to connect %v to carol: %v",
-				node.Name(), err)
-		}
 
 		// We'll first open up a channel between them with a 0.5 BTC
 		// value.
@@ -8472,14 +8407,10 @@ func testRejectHTLC(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	// Connect Alice to Carol.
-	if err := net.ConnectNodes(ctxb, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxb, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 
 	// Connect Carol to Bob.
-	if err := net.ConnectNodes(ctxb, carol, net.Bob); err != nil {
+	net.ConnectNodes(ctxb, t.t, carol, net.Bob)
-		t.Fatalf("unable to conenct carol to net.Bob: %v", err)
-	}
 
 	// Send coins to Carol.
 	net.SendCoins(ctxb, t.t, btcutil.SatoshiPerBitcoin, carol)
@@ -8757,8 +8688,7 @@ func testGraphTopologyNtfns(net *lntest.NetworkHarness, t *harnessTest, pinned b
 
 	// Connect Alice and Bob.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, alice, bob)
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-	require.NoError(t.t, err)
 
 	// Alice stimmy.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
@@ -8917,9 +8847,7 @@ out:
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, bob, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, bob, carol)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPoint = openChannelAndAssert(
 		ctxt, t, net, bob, carol,
@@ -8935,9 +8863,7 @@ out:
 	// Bob, since a node will update its node announcement after a new
 	// channel is opened.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, alice, bob); err != nil {
+	net.EnsureConnected(ctxt, t.t, alice, bob)
-		t.Fatalf("unable to connect alice to bob: %v", err)
-	}
 
 	// We should receive an update advertising the newly connected node,
 	// Bob's new node announcement, and the channel between Bob and Carol.
@@ -9021,9 +8947,7 @@ func testNodeAnnouncement(net *lntest.NetworkHarness, t *harnessTest) {
 	// We must let Dave have an open channel before he can send a node
 	// announcement, so we open a channel with Bob,
 	ctxt, _ := context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Bob, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Bob, dave)
-		t.Fatalf("unable to connect bob to carol: %v", err)
-	}
 
 	// Alice shouldn't receive any new updates yet since the channel has yet
 	// to be opened.
@@ -9694,9 +9618,7 @@ func testSwitchCircuitPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -9725,9 +9647,7 @@ func testSwitchCircuitPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -9839,16 +9759,10 @@ func testSwitchCircuitPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Ensure all of the intermediate links are reconnected.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, net.Alice, dave)
+	net.EnsureConnected(ctxt, t.t, net.Alice, dave)
-	if err != nil {
-		t.Fatalf("unable to reconnect alice and dave: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, net.Bob, net.Alice)
+	net.EnsureConnected(ctxt, t.t, net.Bob, net.Alice)
-	if err != nil {
-		t.Fatalf("unable to reconnect bob and alice: %v", err)
-	}
 
 	// Ensure all nodes in the network still have 5 outstanding htlcs.
 	err = wait.Predicate(func() bool {
@@ -9867,10 +9781,7 @@ func testSwitchCircuitPersistence(net *lntest.NetworkHarness, t *harnessTest) {
 	}
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, carol)
+	net.EnsureConnected(ctxt, t.t, dave, carol)
-	if err != nil {
-		t.Fatalf("unable to reconnect dave and carol: %v", err)
-	}
 
 	// After the payments settle, there should be no active htlcs on any of
 	// the nodes in the network.
@@ -10004,9 +9915,7 @@ func testSwitchOfflineDelivery(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -10035,9 +9944,7 @@ func testSwitchOfflineDelivery(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -10147,9 +10054,7 @@ func testSwitchOfflineDelivery(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Then, reconnect them to ensure Dave doesn't just fail back the htlc.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to reconnect alice to dave: %v", err)
-	}
 
 	// Wait to ensure that the payment remain are not failed back after
 	// reconnecting. All node should report the number payments initiated
@@ -10199,9 +10104,7 @@ func testSwitchOfflineDelivery(net *lntest.NetworkHarness, t *harnessTest) {
 	// Now that the settles have reached Dave, reconnect him with Alice,
 	// allowing the settles to return to the sender.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, dave, net.Alice); err != nil {
+	net.EnsureConnected(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to reconnect alice to dave: %v", err)
-	}
 
 	// Wait until all outstanding htlcs in the network have been settled.
 	err = wait.Predicate(func() bool {
@@ -10333,9 +10236,7 @@ func testSwitchOfflineDeliveryPersistence(net *lntest.NetworkHarness, t *harness
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -10365,9 +10266,7 @@ func testSwitchOfflineDeliveryPersistence(net *lntest.NetworkHarness, t *harness
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -10475,10 +10374,7 @@ func testSwitchOfflineDeliveryPersistence(net *lntest.NetworkHarness, t *harness
 	// Make Carol and Dave are reconnected before waiting for the htlcs to
 	// clear.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, carol)
+	net.EnsureConnected(ctxt, t.t, dave, carol)
-	if err != nil {
-		t.Fatalf("unable to reconnect dave and carol: %v", err)
-	}
 
 	// Wait for Carol to report no outstanding htlcs, and also for Dav to
 	// receive all the settles from Carol.
@@ -10508,10 +10404,7 @@ func testSwitchOfflineDeliveryPersistence(net *lntest.NetworkHarness, t *harness
 	// Force Dave and Alice to reconnect before waiting for the htlcs to
 	// clear.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, net.Alice)
+	net.EnsureConnected(ctxt, t.t, dave, net.Alice)
-	if err != nil {
-		t.Fatalf("unable to reconnect dave and carol: %v", err)
-	}
 
 	// After reconnection succeeds, the settles should be propagated all
 	// the way back to the sender. All nodes should report no active htlcs.
@@ -10564,10 +10457,7 @@ func testSwitchOfflineDeliveryPersistence(net *lntest.NetworkHarness, t *harness
 	// Before completing the final payment request, ensure that the
 	// connection between Dave and Carol has been healed.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, carol)
+	net.EnsureConnected(ctxt, t.t, dave, carol)
-	if err != nil {
-		t.Fatalf("unable to reconnect dave and carol: %v", err)
-	}
 
 	// Using Carol as the source, pay to the 5 invoices from Bob created
 	// above.
@@ -10653,9 +10543,7 @@ func testSwitchOfflineDeliveryOutgoingOffline(
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, dave, net.Alice); err != nil {
+	net.ConnectNodes(ctxt, t.t, dave, net.Alice)
-		t.Fatalf("unable to connect dave to alice: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, dave)
 
@@ -10682,9 +10570,7 @@ func testSwitchOfflineDeliveryOutgoingOffline(
 	// intermediary hops before starting the settle.
 	carol := net.NewNode(t.t, "Carol", []string{"--hodl.exit-settle"})
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, carol, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, carol, dave)
-		t.Fatalf("unable to connect carol to dave: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
 	net.SendCoins(ctxt, t.t, btcutil.SatoshiPerBitcoin, carol)
 
@@ -10829,10 +10715,7 @@ func testSwitchOfflineDeliveryOutgoingOffline(
 	// Ensure that Dave is reconnected to Alice before waiting for the
 	// htlcs to clear.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	err = net.EnsureConnected(ctxt, dave, net.Alice)
+	net.EnsureConnected(ctxt, t.t, dave, net.Alice)
-	if err != nil {
-		t.Fatalf("unable to reconnect alice and dave: %v", err)
-	}
 
 	// Since Carol has been shutdown permanently, we will wait until all
 	// other nodes in the network report no active htlcs.
@@ -10901,9 +10784,7 @@ func testSendUpdateDisableChannel(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, carol)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Alice, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Alice, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointAliceCarol := openChannelAndAssert(
 		ctxt, t, net, net.Alice, carol,
@@ -10930,13 +10811,9 @@ func testSendUpdateDisableChannel(net *lntest.NetworkHarness, t *harnessTest) {
 
 	// Connect Eve to Carol and Bob, and open a channel to carol.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, eve, carol); err != nil {
+	net.ConnectNodes(ctxt, t.t, eve, carol)
-		t.Fatalf("unable to connect alice to carol: %v", err)
-	}
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, eve, net.Bob); err != nil {
+	net.ConnectNodes(ctxt, t.t, eve, net.Bob)
-		t.Fatalf("unable to connect eve to bob: %v", err)
-	}
 
 	ctxt, _ = context.WithTimeout(ctxb, channelOpenTimeout)
 	chanPointEveCarol := openChannelAndAssert(
@@ -10953,9 +10830,7 @@ func testSendUpdateDisableChannel(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, dave)
 
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.ConnectNodes(ctxt, net.Bob, dave); err != nil {
+	net.ConnectNodes(ctxt, t.t, net.Bob, dave)
-		t.Fatalf("unable to connect bob to dave: %v", err)
-	}
 
 	daveSub := subscribeGraphNotifications(ctxb, t, dave)
 	defer close(daveSub.quit)
@@ -11019,9 +10894,7 @@ func testSendUpdateDisableChannel(net *lntest.NetworkHarness, t *harnessTest) {
 	// Reconnect Carol and Eve, this should cause them to reenable the
 	// channel from both ends after a short delay.
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, carol, eve); err != nil {
+	net.EnsureConnected(ctxt, t.t, carol, eve)
-		t.Fatalf("unable to reconnect Carol to Eve: %v", err)
-	}
 
 	expectedPolicy.Disabled = false
 	waitForChannelUpdate(
@@ -11044,9 +10917,7 @@ func testSendUpdateDisableChannel(net *lntest.NetworkHarness, t *harnessTest) {
 	}
 	time.Sleep(time.Second)
 	ctxt, _ = context.WithTimeout(ctxb, defaultTimeout)
-	if err := net.EnsureConnected(ctxt, eve, carol); err != nil {
+	net.EnsureConnected(ctxt, t.t, eve, carol)
-		t.Fatalf("unable to reconnect Carol to Eve: %v", err)
-	}
 
 	// Since the disable should have been canceled by both Carol and Eve, we
 	// expect no channel updates to appear on the network.
@@ -11808,12 +11679,9 @@ func TestLightningNetworkDaemon(t *testing.T) {
 				require.NoError(t1, lndHarness.TearDown())
 			}()
 
-			err = lndHarness.EnsureConnected(
+			lndHarness.EnsureConnected(
-				context.Background(), lndHarness.Alice,
+				context.Background(), t1,
-				lndHarness.Bob,
+				lndHarness.Alice, lndHarness.Bob,
-			)
-			require.NoError(t1,
-				err, "unable to connect alice to bob",
 			)
 
 			logLine := fmt.Sprintf(

lntest/itest/lnd_wallet_import_test.go

@@ -334,8 +334,7 @@ func fundChanAndCloseFromImportedAccount(t *harnessTest, srcNode, destNode,
 	// nodes first.
 	ctxt, cancel = context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
-	err = t.lndHarness.EnsureConnected(ctxt, srcNode, destNode)
+	t.lndHarness.EnsureConnected(ctxt, t.t, srcNode, destNode)
-	require.NoError(t.t, err)
 
 	// The source node will then fund the channel through a PSBT shim.
 	var pendingChanID [32]byte

lntest/itest/lnd_wumbo_channels_test.go

@@ -34,13 +34,10 @@ func testWumboChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	// Next we'll connect both nodes, then attempt to make a wumbo channel
 	// funding request to the mini node we created above. The wumbo request
 	// should fail as the node isn't advertising wumbo channels.
-	err := net.EnsureConnected(ctxb, wumboNode, miniNode)
+	net.EnsureConnected(ctxb, t.t, wumboNode, miniNode)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 
 	chanAmt := funding.MaxBtcFundingAmount + 1
-	_, err = net.OpenChannel(
+	_, err := net.OpenChannel(
 		ctxb, wumboNode, miniNode, lntest.OpenChannelParams{
 			Amt: chanAmt,
 		},
@@ -64,10 +61,7 @@ func testWumboChannels(net *lntest.NetworkHarness, t *harnessTest) {
 	defer shutdownAndAssert(net, t, wumboNode2)
 
 	// Creating a wumbo channel between these two nodes should succeed.
-	err = net.EnsureConnected(ctxb, wumboNode, wumboNode2)
+	net.EnsureConnected(ctxb, t.t, wumboNode, wumboNode2)
-	if err != nil {
-		t.Fatalf("unable to connect peers: %v", err)
-	}
 	chanPoint := openChannelAndAssert(
 		ctxb, t, net, wumboNode, wumboNode2,
 		lntest.OpenChannelParams{