htlcswitch/link: only resovle+gc fwdpkgs for live channels

This commit is contained in:
Conner Fromknecht 2018-08-21 18:47:52 -07:00
parent e5a61183b5
commit 211a0299e9
No known key found for this signature in database
GPG Key ID: E7D737B67FA592C7

@ -847,18 +847,23 @@ func (l *channelLink) htlcManager() {
// After cleaning up any memory pertaining to incoming packets, we now // After cleaning up any memory pertaining to incoming packets, we now
// replay our forwarding packages to handle any htlcs that can be // replay our forwarding packages to handle any htlcs that can be
// processed locally, or need to be forwarded out to the switch. // processed locally, or need to be forwarded out to the switch. We will
if err := l.resolveFwdPkgs(); err != nil { // only attempt to resolve packages if our short chan id indicates that
l.fail(LinkFailureError{code: ErrInternalError}, // the channel is not pending, otherwise we should have no htlcs to
"unable to resolve fwd pkgs: %v", err) // reforward.
return if l.ShortChanID() != sourceHop {
} if err := l.resolveFwdPkgs(); err != nil {
l.fail(LinkFailureError{code: ErrInternalError},
"unable to resolve fwd pkgs: %v", err)
return
}
// With our link's in-memory state fully reconstructed, spawn a // With our link's in-memory state fully reconstructed, spawn a
// goroutine to manage the reclamation of disk space occupied by // goroutine to manage the reclamation of disk space occupied by
// completed forwarding packages. // completed forwarding packages.
l.wg.Add(1) l.wg.Add(1)
go l.fwdPkgGarbager() go l.fwdPkgGarbager()
}
out: out:
for { for {
@ -1670,6 +1675,11 @@ func (l *channelLink) UpdateShortChanID() (lnwire.ShortChannelID, error) {
} }
}() }()
// Now that the short channel ID has been properly updated, we can begin
// garbage collecting any forwarding packages we create.
l.wg.Add(1)
go l.fwdPkgGarbager()
return sid, nil return sid, nil
} }