akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #2030 from halseth/authsig-len

Browse Source 
Validate own node announcement, signature length
This commit is contained in:
Olaoluwa Osuntokun 2018-12-05 21:08:46 -08:00 committed by GitHub
commit 1d1e9f2c44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
channeldb/graph.go
View File

@ -2839,6 +2839,12 @@ func putLightningNode(nodeBucket *bbolt.Bucket, aliasBucket *bbolt.Bucket,
}
}
sigLen := len(node.AuthSigBytes)
if sigLen > 80 {
return fmt.Errorf("max sig len allowed is 80, had %v",
sigLen)
}
err = wire.WriteVarBytes(&b, 0, node.AuthSigBytes)
if err != nil {
return err

2
discovery/gossiper.go
View File

@ -1577,7 +1577,6 @@ func (d *AuthenticatedGossiper) processNetworkAnnouncement(
case *lnwire.NodeAnnouncement:
timestamp := time.Unix(int64(msg.Timestamp), 0)
if nMsg.isRemote {
// We'll quickly ask the router if it already has a
// newer update for this node so we can skip validating
// signatures if not required.
@ -1593,7 +1592,6 @@ func (d *AuthenticatedGossiper) processNetworkAnnouncement(
nMsg.err <- err
return nil
}
}
features := lnwire.NewFeatureVector(
msg.Features, lnwire.GlobalFeatures,