akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rpcserver: allow creation of invoices with zero amount

Browse Source
This commit is contained in:
Wilmer Paulino 2018-01-22 15:01:43 -05:00
parent 78b9dc4b96
commit 1570c0ece8
No known key found for this signature in database
GPG Key ID: 6DF57B9F9514972F
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
rpcserver.go
View File

@ -1939,14 +1939,10 @@ func (r *rpcServer) AddInvoice(ctx context.Context,
amt := btcutil.Amount(invoice.Value) amt := btcutil.Amount(invoice.Value)
amtMSat := lnwire.NewMSatFromSatoshis(amt) amtMSat := lnwire.NewMSatFromSatoshis(amt)
switch {
// The value of an invoice MUST NOT be zero.
case invoice.Value == 0:
return nil, fmt.Errorf("zero value invoices are disallowed")
// The value of the invoice must also not exceed the current soft-limit // The value of the invoice must also not exceed the current soft-limit
// on the largest payment within the network. // on the largest payment within the network.
case amtMSat > maxPaymentMSat: if amtMSat > maxPaymentMSat {
return nil, fmt.Errorf("payment of %v is too large, max "+ return nil, fmt.Errorf("payment of %v is too large, max "+
"payment allowed is %v", amt, maxPaymentMSat.ToSatoshis()) "payment allowed is %v", amt, maxPaymentMSat.ToSatoshis())
} }
@ -1962,9 +1958,12 @@ func (r *rpcServer) AddInvoice(ctx context.Context,
// expiry, fallback address, and the amount field. // expiry, fallback address, and the amount field.
var options []func(*zpay32.Invoice) var options []func(*zpay32.Invoice)
// Add the amount. This field is optional by the BOLT-11 format, but // We only include the amount in the invoice if it is greater than 0.
// we require it for now. // By not including the amount, we enable the creation of invoices that
options = append(options, zpay32.Amount(amtMSat)) // allow the payee to specify the amount of satoshis they wish to send.
if amtMSat > 0 {
options = append(options, zpay32.Amount(amtMSat))
}
// If specified, add a fallback address to the payment request. // If specified, add a fallback address to the payment request.
if len(invoice.FallbackAddr) > 0 { if len(invoice.FallbackAddr) > 0 {