akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

brontide/noise_test: defer wait group decrement

Browse Source 
If any of the checks in the goroutine fail, the test will deadlock since
the waitgroup is never released.
This commit is contained in:
Conner Fromknecht 2019-04-22 16:04:37 -07:00
parent e3728da478
commit 12ec999252
No known key found for this signature in database
GPG Key ID: E7D737B67FA592C7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
brontide/noise_test.go
View File

@ -269,6 +269,8 @@ func TestWriteMessageChunking(t *testing.T) {
var wg sync.WaitGroup var wg sync.WaitGroup
wg.Add(1) wg.Add(1)
go func() { go func() {
defer wg.Done()
bytesWritten, err := localConn.Write(largeMessage) bytesWritten, err := localConn.Write(largeMessage)
if err != nil { if err != nil {
t.Fatalf("unable to write message: %v", err) t.Fatalf("unable to write message: %v", err)
@ -280,7 +282,6 @@ func TestWriteMessageChunking(t *testing.T) {
t.Fatalf("bytes not fully written!") t.Fatalf("bytes not fully written!")
} }
wg.Done()
}() }()
// Attempt to read the entirety of the message generated above. // Attempt to read the entirety of the message generated above.