akovalenko/lnd.xprv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4241 from Roasbeef/listpayment-copy

Browse Source 
channeldb: eliminate extra copy in QueryPayments
This commit is contained in:
Olaoluwa Osuntokun 2020-05-05 15:36:46 -07:00 committed by GitHub
commit 0dfb946afd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
channeldb/payments.go
View File

@ -460,7 +460,7 @@ type PaymentsQuery struct {
type PaymentsResponse struct { type PaymentsResponse struct {
// Payments is the set of payments returned from the database for the // Payments is the set of payments returned from the database for the
// PaymentsQuery. // PaymentsQuery.
Payments []MPPayment Payments []*MPPayment
// FirstIndexOffset is the index of the first element in the set of // FirstIndexOffset is the index of the first element in the set of
// returned MPPayments. Callers can use this to resume their query // returned MPPayments. Callers can use this to resume their query
@ -536,7 +536,7 @@ func (db *DB) QueryPayments(query PaymentsQuery) (PaymentsResponse, error) {
continue continue
} }
resp.Payments = append(resp.Payments, *payment) resp.Payments = append(resp.Payments, payment)
} }
// Need to swap the payments slice order if reversed order. // Need to swap the payments slice order if reversed order.

2
rpcserver.go
View File

@ -5191,7 +5191,7 @@ func (r *rpcServer) ListPayments(ctx context.Context,
for _, payment := range paymentsQuerySlice.Payments { for _, payment := range paymentsQuerySlice.Payments {
payment := payment payment := payment
rpcPayment, err := r.routerBackend.MarshallPayment(&payment) rpcPayment, err := r.routerBackend.MarshallPayment(payment)
if err != nil { if err != nil {
return nil, err return nil, err
} }