From 0ca65208c5855eb5938d3d260d5b1b29ed78ac72 Mon Sep 17 00:00:00 2001 From: Olaoluwa Osuntokun Date: Wed, 3 Apr 2019 13:13:03 -0700 Subject: [PATCH] signal: don't attempt to catch SIGSTOP In this commit, we modify the set of default signals we attempt to catch in order to execute a graceful shutdown. Before this commit, we would attempt to catch/register for `SIGSTOP`. There're two issues with this 1. `SIGSTOP` is meant to be used in combination with `SIGCONCT` to allow a process to be paused/resumed. Therefore, our action of shutting down once received was incorrect. 2. `SIGSTOP` doesn't exist on windows, so users aren't able to compile on this platform without modifying the codebase. --- signal/signal.go | 1 - 1 file changed, 1 deletion(-) diff --git a/signal/signal.go b/signal/signal.go index c6c90395..29cbb9f5 100644 --- a/signal/signal.go +++ b/signal/signal.go @@ -32,7 +32,6 @@ func init() { os.Kill, syscall.SIGABRT, syscall.SIGTERM, - syscall.SIGSTOP, syscall.SIGQUIT, } signal.Notify(interruptChannel, signalsToCatch...)