From 090e97cd3b330ab31287af8e3fdeb6d77a8ffefe Mon Sep 17 00:00:00 2001 From: Conner Fromknecht Date: Fri, 10 Aug 2018 14:29:58 -0700 Subject: [PATCH] channeldb/db_test: move migration helper back to meta_test --- channeldb/db_test.go | 55 -------------------------------------------- 1 file changed, 55 deletions(-) diff --git a/channeldb/db_test.go b/channeldb/db_test.go index 7edae3c5..f3e3c96e 100644 --- a/channeldb/db_test.go +++ b/channeldb/db_test.go @@ -5,8 +5,6 @@ import ( "os" "path/filepath" "testing" - - "github.com/go-errors/errors" ) func TestOpenWithCreate(t *testing.T) { @@ -35,56 +33,3 @@ func TestOpenWithCreate(t *testing.T) { t.Fatalf("channeldb failed to create data directory") } } - -// applyMigration is a helper test function that encapsulates the general steps -// which are needed to properly check the result of applying migration function. -func applyMigration(t *testing.T, beforeMigration, afterMigration func(d *DB), - migrationFunc migration, shouldFail bool) { - - cdb, cleanUp, err := makeTestDB() - defer cleanUp() - if err != nil { - t.Fatal(err) - } - - // beforeMigration usually used for populating the database - // with test data. - beforeMigration(cdb) - - // Create test meta info with zero database version and put it on disk. - // Than creating the version list pretending that new version was added. - meta := &Meta{DbVersionNumber: 0} - if err := cdb.PutMeta(meta); err != nil { - t.Fatalf("unable to store meta data: %v", err) - } - - versions := []version{ - { - number: 0, - migration: nil, - }, - { - number: 1, - migration: migrationFunc, - }, - } - - defer func() { - if r := recover(); r != nil { - err = errors.New(r) - } - - if err == nil && shouldFail { - t.Fatal("error wasn't received on migration stage") - } else if err != nil && !shouldFail { - t.Fatal("error was received on migration stage") - } - - // afterMigration usually used for checking the database state and - // throwing the error if something went wrong. - afterMigration(cdb) - }() - - // Sync with the latest version - applying migration function. - err = cdb.syncVersions(versions) -}