2018-12-18 06:43:50 +03:00
#### Pull Request Checklist
2018-12-20 04:02:25 +03:00
- [ ] If this is your first time contributing, we recommend you read the [Code
Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md)
2019-03-24 13:37:57 +03:00
- [ ] All changes are Go version 1.12 compliant
- [ ] The code being submitted is commented according to [Code Documentation and Commenting ](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation )
- [ ] For new code: Code is accompanied by tests which exercise both
2018-12-18 06:43:50 +03:00
the positive and negative (error paths) conditions (if applicable)
2019-03-24 13:37:57 +03:00
- [ ] For bug fixes: Code is accompanied by new tests which trigger
2018-12-18 06:43:50 +03:00
the bug being fixed to prevent regressions
2019-03-24 13:37:57 +03:00
- [ ] Any new logging statements use an appropriate subsystem and
2018-12-18 06:43:50 +03:00
logging level
2019-03-24 13:37:57 +03:00
- [ ] Code has been formatted with `go fmt`
2020-03-04 17:24:30 +03:00
- [ ] Protobuf files (`lnrpc/**/*.proto`) have been formatted with
`make rpc-format` and compiled with `make rpc`
2019-03-24 13:37:57 +03:00
- [ ] For code and documentation: lines are wrapped at 80 characters
2018-12-18 06:43:50 +03:00
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
2019-03-24 13:37:57 +03:00
- [ ] Running `make check` does not fail any tests
- [ ] Running `go vet` does not report any issues
- [ ] Running `make lint` does not report any **new** issues that did not
2018-12-18 06:43:50 +03:00
already exist
2018-12-20 04:02:25 +03:00
- [ ] All commits build properly and pass tests. Only in exceptional
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.
2019-03-24 13:37:57 +03:00
- [ ] Commits have a logical structure according to [Ideal Git Commit Structure ](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#IdealGitCommitStructure )