lnd.xprv/.golangci.yml

run:
  # timeout for analysis
  deadline: 10m

  # Skip autogenerated files for mobile.
  skip-files:
    - "mobile\\/.*generated\\.go"

  skip-dirs:
    - channeldb/migration_01_to_11
    - channeldb/migration/lnwire21

  build-tags:
    - autopilotrpc
    - chainrpc
    - invoicesrpc
    - signrpc
    - walletrpc
    - watchtowerrpc

linters-settings:
  govet:
    # Don't report about shadowed variables
    check-shadowing: false
  gofmt:
    # simplify code: gofmt with `-s` option, true by default
    simplify: true

linters:
  enable-all: true
  disable:
  # Global variables are used in many places throughout the code base.
  - gochecknoglobals

  # Some lines are over 80 characters on purpose and we don't want to make them
  # even longer by marking them as 'nolint'.
  - lll

  # We don't care (enough) about misaligned structs to lint that.
  - maligned

  # We have long functions, especially in tests. Moving or renaming those would
  # trigger funlen problems that we may not want to solve at that time.
  - funlen

  # Disable for now as we haven't yet tuned the sensitivity to our codebase
  # yet.  Enabling by default for example, would also force new contributors to
  # potentially extensively refactor code, when they want to smaller change to
  # land.
  - gocyclo

  # Instances of table driven tests that don't pre-allocate shouldn't trigger
  # the linter.
  - prealloc

  # Init functions are used by loggers throughout the codebase.
  - gochecknoinits

issues:
  # Only show newly introduced problems.
  new-from-rev: 01f696afce2f9c0d4ed854edefa3846891d01d8a

  exclude-rules:
    # Exclude gosec from running for tests so that tests with weak randomness
    # (math/rand) will pass the linter.
    - path: _test\.go
      linters:
        - gosec

    # Fix false positives because of build flags in itest directory.
    - path: lntest/itest/.*
      linters:
        - unused
        - deadcode
        - unparam
        - govet
make: change linter gometalinter->golangci-lint 2019-07-22 12:05:57 +03:00			`run:`
			`# timeout for analysis`
travis+lint: fix memory usage There is a setting to control how often the garbage collector is run. Apparently this is a tradeoff between CPU and memory usage. If we can limit the memory being used in that way, this allows us to use multiple worker again, so overall this shouldn't be much slower than before. 2020-09-04 15:10:03 +03:00			`deadline: 10m`
build: enable linters for future changes 2019-09-11 15:21:04 +03:00
lint: skip files generated for mobile 2019-09-17 16:21:31 +03:00			`# Skip autogenerated files for mobile.`
			`skip-files:`
			`- "mobile\\/.*generated\\.go"`

channeldb: make copy for migrations This commit is a direct copy of the complete channeldb package. It only changes the package declaration at the top of every file. We make this full copy so that review can be focused on the actual changes made. Otherwise changes may drown in all the file moves. Linting for the new package is disabled, as it contains lots of pre-existing issues. 2019-10-24 13:04:26 +03:00			`skip-dirs:`
			`- channeldb/migration_01_to_11`
channeldb/migration: copy current lnwire to migration dir To avoid code changing underneath the static migrations, we copy the lnwire dependency in its current form into the migration directory. Ideally the migrations doesn't depend on any code that might change, this takes us a step closer. 2021-01-15 13:12:08 +03:00			`- channeldb/migration/lnwire21`
channeldb: make copy for migrations This commit is a direct copy of the complete channeldb package. It only changes the package declaration at the top of every file. We make this full copy so that review can be focused on the actual changes made. Otherwise changes may drown in all the file moves. Linting for the new package is disabled, as it contains lots of pre-existing issues. 2019-10-24 13:04:26 +03:00
build: lint with build tags 2019-09-10 13:35:31 +03:00			`build-tags:`
			`- autopilotrpc`
			`- chainrpc`
			`- invoicesrpc`
			`- signrpc`
			`- walletrpc`
			`- watchtowerrpc`
make: change linter gometalinter->golangci-lint 2019-07-22 12:05:57 +03:00
			`linters-settings:`
			`govet:`
			`# Don't report about shadowed variables`
			`check-shadowing: false`
			`gofmt:`
			# simplify code: gofmt with `-s` option, true by default
			`simplify: true`

			`linters:`
build: enable linters for future changes 2019-09-11 15:21:04 +03:00			`enable-all: true`
			`disable:`
			`# Global variables are used in many places throughout the code base.`
			`- gochecknoglobals`

			`# Some lines are over 80 characters on purpose and we don't want to make them`
			`# even longer by marking them as 'nolint'.`
			`- lll`

			`# We don't care (enough) about misaligned structs to lint that.`
			`- maligned`

build: disable funlen 2019-09-13 12:15:43 +03:00			`# We have long functions, especially in tests. Moving or renaming those would`
			`# trigger funlen problems that we may not want to solve at that time.`
			`- funlen`

build: nerf linter 2019-09-17 06:46:01 +03:00			`# Disable for now as we haven't yet tuned the sensitivity to our codebase`
			`# yet. Enabling by default for example, would also force new contributors to`
			`# potentially extensively refactor code, when they want to smaller change to`
			`# land.`
			`- gocyclo`

			`# Instances of table driven tests that don't pre-allocate shouldn't trigger`
			`# the linter.`
			`- prealloc`

chanfitness: Add channel event store This commit adds a channel event store to the channel fitness package which is used to manage tracking of a node's channels. It adds tracking for channel open/closed and peer online/offline events for all channels that a node has open. Events are consumed from channelNotifier and peerNotifier event subscriptions. If either of these subscriptions is cancelled, channel scoring stops, because both subscriptions are expected to run until node shutdown. Two functions are exposed to allow external callers to get uptime information about a channel. GetLifespan returns the period over which the channel has been monitored. GetUptime returns the channel's uptime over a specified period. Callers can use these functions to get the channel's remote peer uptime over its entire lifetime, or a subset of that period. 2019-08-08 20:39:38 +03:00			`# Init functions are used by loggers throughout the codebase.`
			`- gochecknoinits`

build: enable linters for future changes 2019-09-11 15:21:04 +03:00			`issues:`
			`# Only show newly introduced problems.`
			`new-from-rev: 01f696afce2f9c0d4ed854edefa3846891d01d8a`
lnwire: Add upfront shutdown messages and feature bit This commit adds the feature bit and additional fields required in `open_channel` and `accept_channel` wire messages for `option_upfront_shutdown_script`. 2019-12-03 12:38:21 +03:00
			`exclude-rules:`
			`# Exclude gosec from running for tests so that tests with weak randomness`
			`# (math/rand) will pass the linter.`
			`- path: _test\.go`
			`linters:`
			`- gosec`
lntest: fix most linter warnings, silence rest We fix all linter issues except for the 'lostcontext' and 'unparam' ones as those are too numerous and would increase the diff even more. Therefore we silence them in the itest directory for now. Because the linter is still not build tag aware, we also have to silence the unused and deadcode sub linters to not get false positives. 2020-01-10 17:27:50 +03:00
			`# Fix false positives because of build flags in itest directory.`
			`- path: lntest/itest/.*`
			`linters:`
			`- unused`
			`- deadcode`
			`- unparam`
			`- govet`